Stas Skipper
  • My pronounces are: your/fucking/boss

  • Joined on 2025-09-03
Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

explained alr

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

unit type for ids here as well

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

Vote kind should be a enum. Not a string. We are here forcing type-safety, only for you, wigga, to break it with your strings. wigga.

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

declare enum here with 3 possible context, associate a binary data with them:

Skipper suggested changes for MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

Separate database interactions in ProposalManager into separate DBAL trait, so we could mock it in the future using automock crate and test properly.

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

signature check is quite complex, so separate it into several helpers and put them into crypto submodule

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

why the fuck do you store binary data inside relational database. declare tables, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

ProposalKindTag should be derived using this enum and strum crate, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

2n+1 query problem here, replace those queries with aggregate ones

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

OperatorId unit type

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

there is exists() function in diesel, which returns true / false if record exist

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

why the fuck do you store binary data inside relational database. declare tables, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

expires_at already implied when the proposal expires, so remove expired from a list of possible values, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

let's use OperatorId unit type here

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

here accept enum from previous comment instead of random byte slice

Skipper commented on pull request MarketTakers/arbiter#102 2026-08-25 13:11:51 +00:00
feat(proto)!: Shamir re-key, governance and bootstrapping vault state

Add error on submission of invalid committee parameters

Skipper commented on pull request MarketTakers/arbiter#102 2026-08-25 13:11:51 +00:00
feat(proto)!: Shamir re-key, governance and bootstrapping vault state

this should be an enum instead

Skipper commented on pull request MarketTakers/arbiter#102 2026-08-25 13:11:51 +00:00
feat(proto)!: Shamir re-key, governance and bootstrapping vault state

comment from @CleverWild: blyat