Stas Skipper
  • My pronounces are: your/fucking/boss

  • Joined on 2025-09-03
Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

let's use OperatorId unit type here

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

here accept enum from previous comment instead of random byte slice

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

Vote kind should be a enum. Not a string. We are here forcing type-safety, only for you, wigga, to break it with your strings. wigga.

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

there is exists() function in diesel, which returns true / false if record exist

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

expires_at already implied when the proposal expires, so remove expired from a list of possible values, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

remove this, separation of concerns

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

extract this signature concatenation into either a separate function, or better into crypto submodule.

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

add maximum ttl check here

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

OperatorId unit type

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

ProposalManager should focus on one thing, and one thing only, the vote coordination: not the outcome execution.

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

Explain what is the UpdateShamirParameters. Do you want to edit the quorum after committee has already formed??? wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

Scope creep, remove this for now

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

signature check is quite complex, so separate it into several helpers and put them into crypto submodule

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

explained alr

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

why the fuck do you store binary data inside relational database. declare tables, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

why the fuck do you store binary data inside relational database. declare tables, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

there is exists() function in diesel

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

there should be no default and salt should always be supplied by our daemon, wigga

Skipper commented on pull request MarketTakers/arbiter#103 2026-08-25 13:48:33 +00:00
WIP: feat-shamir (old)

Wigga, please. Remove homebrew protocol, instead, make those as protobuf entities. And convert to them using already established traits, wigga