refactor(server): extract shared runtime and implement service install/run in arbiter-server.exe #44
Reference in New Issue
Block a user
Delete Branch "win-service"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
plz clarify
@@ -0,0 +2,4 @@use clap::{Args, Parser, Subcommand};const DEFAULT_LISTEN_ADDR: &str = "127.0.0.1:50051";there was a port hardcoded in arbiter-proto. use that instead
@@ -0,0 +15,4 @@#[derive(Debug, Subcommand)]pub enum Command {/// Run server in foreground mode.Run(RunArgs),does this run without specifying anything?
Meaning: it should run even if no command specified
Yup. See
Optionin the struct above.@@ -0,0 +25,4 @@}}pub async fn run_server_until_shutdown<F>(config: RunConfig, shutdown: F) -> miette::Result<()>I would put that in lib.rs instead
@@ -0,0 +64,4 @@addr: SocketAddr,bootstrapper: &ActorRef<crate::actors::bootstrap::Bootstrapper>,tls: &crate::context::tls::TlsManager,) -> miette::Result<ArbiterUrl> {why this small chunk is a separate function?
The Eye of Sauron didn't notice this during the refactor.
@@ -0,0 +58,4 @@name: OsString::from(SERVICE_NAME),display_name: OsString::from(SERVICE_DISPLAY_NAME),service_type: ServiceType::OWN_PROCESS,start_type: ServiceStartType::OnDemand,does this run service on pc boot?
Nope. Wrong flag.
@@ -0,0 +207,4 @@// because service-account and interactive-user access requirements are different in production.let target = data_dir.as_os_str();let status = Command::new("icacls")clarify meaning of this in comment
Approved, but I will add macos part now
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.