MarketTakers/arbiter
5
0
Fork 0
Code Issues 27 Pull Requests 4 Packages Projects Releases Wiki Activity

feat(server): implement useragent_delete_grant hard delete cleanup #53

Open
CleverWild wants to merge 1 commits from impl-useragent_delete_grant into main
pull from: impl-useragent_delete_grant
merge into: MarketTakers:main
Conversation 1 Commits 1 Files Changed 2 +398 -23
CleverWild commented 2026-04-05 16:05:05 +00:00
Member
Copy Link

Add transactional grant deletion that cleans all dependent tables and integrity
envelopes.

The test that was included is passing.

Add transactional grant deletion that cleans all dependent tables and integrity envelopes. The test that was included is passing.
CleverWild requested review from Skipper 2026-04-05 16:05:06 +00:00
Skipper commented 2026-04-05 16:26:34 +00:00
Owner
Copy Link

Well, after some chill I though of another idea: we could just use shared_grant_id (id of evm_basic_grant) instead of grant specific id.
In this way, we would avoid writing generic invocation of each policy type (we already have 3 other places in code with same list of generic items :( )

Well, after some chill I though of another idea: we could just use `shared_grant_id` (id of `evm_basic_grant`) instead of grant specific id. In this way, we would avoid writing generic invocation of each policy type (we already have 3 other places in code with same list of generic items :( )
Skipper changed target branch from integrity-envelope to main 2026-04-05 16:26:52 +00:00
Skipper added 1 commit 2026-04-05 16:26:52 +00:00
feat(server): implement useragent_delete_grant hard delete cleanup
Some checks failed
ci/woodpecker/pr/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline failed
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
3aae3e1d83
Some checks failed
ci/woodpecker/pr/server-audit Pipeline was successful
Required
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline failed
Required
Details
ci/woodpecker/pr/server-test Pipeline was successful
Required
Details
This pull request has changes conflicting with the target branch.
  • server/crates/arbiter-server/src/actors/evm/mod.rs
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin impl-useragent_delete_grant:impl-useragent_delete_grant
git checkout impl-useragent_delete_grant
Sign in to join this conversation.
Reviewers
No Reviewers
Skipper
Labels
Clear labels
Compat
Breaking
Breaking change that won't be backward compatible
Difficulty
High
3
Hard difficulty. Experience needed to fix: A lot.
Difficulty
Low
1
Easy difficulty. Experience needed to fix: Not much. Good first issue.
Difficulty
Medium
2
Medium difficulty. Experience needed to fix: Intermediate.
Kind
Bug
This is a bug.
Kind
Enhancement
Improve existing functionality.
Kind
Feature
New functionality
Kind
RFC
Request for comments
Kind
Security
This is security issue
Kind
Testing
This is testing issue.
Kind
Tracking issue
An issue tracking the progress of sth. like the implementation of an RFC
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Pending
4
Requires review by dev
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CleverWild Skipper goodvin testuser
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#53
Delete Branch "impl-useragent_delete_grant"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?