security: batch of fixes #95

Merged

Skipper merged 14 commits from zeroized-bootstrap-token into main 2026-06-29 18:00:14 +00:00

Conversation 5 Commits 14 Files Changed 24 +580 -179

CleverWild commented 2026-06-18 15:16:24 +00:00

Member

Copy Link

closes #73
closes #71
closes #67
closes #65
closes #64 (todo: Frontend)
closes #63
closes #60
closes #59
closes #54

closes #73 closes #71 closes #67 closes #65 closes #64 (todo: Frontend) closes #63 closes #60 closes #59 closes #54

CleverWild added 1 commit 2026-06-18 15:16:25 +00:00

security(memory): zeroization of bootstrap token dc03923c24

CleverWild requested review from Skipper 2026-06-18 15:16:31 +00:00

CleverWild added 1 commit 2026-06-18 17:30:36 +00:00

security(server): use SysRng directly for bootstrap token generation ... 32ceb27d77

Replace make_rng()/StdRng with UnwrapErr(SysRng) to eliminate the PRNG
intermediate layer and make OS entropy derivation explicit and unambiguous.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

CleverWild changed title from security(memory): zeroization of bootstrap token to security(memory): bootstrap token 2026-06-18 17:35:49 +00:00

CleverWild added 1 commit 2026-06-18 18:59:35 +00:00

fix(bootstrap): token persists on disk with weak file permissions #59 85f27d8f09

CleverWild changed title from security(memory): bootstrap token to security: batch of fixes 2026-06-18 19:00:35 +00:00

CleverWild added 1 commit 2026-06-18 19:16:44 +00:00

security: feat unseal and bootstrap handshake brute-force protection 670448292a

CleverWild removed review request for Skipper 2026-06-19 11:33:26 +00:00

Skipper requested changes 2026-06-19 14:03:45 +00:00

Skipper left a comment

Owner

Copy Link

Well, we have safe_cell abstraction, so I don't see a need to introduce new zeroize depependency, and potentially new-type wrapper

Additionally, safe_cell provides memory permission management (e.g. if it's not read or written atm, the memory page has zero access)

Well, we have `safe_cell` abstraction, so I don't see a need to introduce new `zeroize` depependency, and potentially new-type wrapper Additionally, `safe_cell` provides memory permission management (e.g. if it's not read or written atm, the memory page has zero access)

CleverWild commented 2026-06-19 20:17:22 +00:00

Author

Member

Copy Link

Well, the absence of zeroize was supposed to make me think over. Gonna be fixed.

Well, the absence of `zeroize` was supposed to make me think over. Gonna be fixed.

CleverWild added 1 commit 2026-06-19 20:21:53 +00:00

fix(UA): signing endpoint accepts arbitrary client_id c12c12d73e

CleverWild added 1 commit 2026-06-19 20:53:33 +00:00

security(bootstrap): use SafeCell for token storage instead of zeroize f0456157d5

CleverWild added 1 commit 2026-06-22 12:55:38 +00:00

fix(wallet): delete access entries by entry ID instead of wallet ID 77bf19f99e

CleverWild added 1 commit 2026-06-22 13:50:49 +00:00

fix(integrity): return AttestationStatus::Unavailable for key version mismatch 9c9dc1fbb5

CleverWild added 1 commit 2026-06-22 13:58:44 +00:00

fix(operator): bind sign-transaction to operator-approved client set b8e092b9d7

CleverWild added 1 commit 2026-06-22 14:08:03 +00:00

fix(client-auth): freeze client metadata after initial operator approval b7ab5c79b7

CleverWild added 1 commit 2026-06-22 15:53:39 +00:00

fix!: protect evm_wallet integrity and bind key ciphertext to wallet address ... 00ddf99d77

Three independent failures allowed an offline attacker with DB write access
to sign transactions using a different wallet's private key:
1. evm_wallet had no HMAC envelope — aead_encrypted_id could be swapped silently.
2. AEAD used a static tag as AAD — any valid ciphertext decrypted as any wallet key.
3. No post-decryption check that the derived address matched the requested wallet.

Fix: sign_entity covers (address, aead_encrypted_id) in a single transaction;
CreateNew/Decrypt take caller-provided AAD (wallet address bytes); after decryption
signer.address() is verified against the requested wallet address.

CleverWild requested review from Skipper 2026-06-22 15:54:47 +00:00

CleverWild added 1 commit 2026-06-25 18:09:23 +00:00

fix: lints 022003ac5e

Skipper commented 2026-06-26 10:09:02 +00:00

Owner

Copy Link

LGTM, fix merge conflict and tests

LGTM, fix merge conflict and tests

CleverWild added 1 commit 2026-06-27 11:25:33 +00:00

Merge branch 'main' into zeroized-bootstrap-token 8381b68a52

CleverWild commented 2026-06-27 11:36:48 +00:00

Author

Member

Copy Link

Done

Done

CleverWild removed review request for Skipper 2026-06-27 11:36:56 +00:00

CleverWild requested review from Skipper 2026-06-27 11:37:04 +00:00

Skipper commented 2026-06-27 11:37:27 +00:00

Owner

Copy Link

tests still fail tho

tests still fail tho

CleverWild added 1 commit 2026-06-28 11:24:26 +00:00

test(client-auth): update metadata test to reflect frozen-metadata behavior 23827c613e

CleverWild removed review request for Skipper 2026-06-28 11:25:00 +00:00

CleverWild requested review from Skipper 2026-06-28 11:25:01 +00:00

Skipper merged commit 357726bc5d into main 2026-06-29 18:00:14 +00:00

Skipper referenced this issue from a commit 2026-06-29 18:00:16 +00:00

Merge pull request 'security: batch of fixes' (#95) from zeroized-bootstrap-token into main

CleverWild referenced this pull request 2026-06-30 18:01:01 +00:00

Unseal and bootstrap handshake lack brute-force protection #60

CleverWild referenced this pull request 2026-06-30 18:06:07 +00:00

Bootstrap token persists on disk with weak file permissions #59

Sign in to join this conversation.

Reviewers

No Reviewers

Skipper

Labels

Clear labels

Compat

Breaking

Breaking change that won't be backward compatible

Difficulty

High

3

Hard difficulty. Experience needed to fix: A lot.

Difficulty

Low

1

Easy difficulty. Experience needed to fix: Not much. Good first issue.

Difficulty

Medium

2

Medium difficulty. Experience needed to fix: Intermediate.

Kind

Bug

This is a bug.

Kind

Enhancement

Improve existing functionality.

Kind

Feature

New functionality

Kind

RFC

Request for comments

Kind

Security

This is security issue

Kind

Testing

This is testing issue.

Kind

Tracking issue

An issue tracking the progress of sth. like the implementation of an RFC

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Pending

4

Requires review by dev

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

CleverWild Skipper Tangonell goodvin testuser

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#95