MarketTakers/arbiter
5
0
Fork 0
Code Issues 27 Pull Requests 4 Packages Projects Releases Wiki Activity

Wallet-access revocation deletes by wallet_id instead of entry id #71

New Issue
Open
opened 2026-04-05 16:23:11 +00:00 by Skipper · 0 comments
Skipper commented 2026-04-05 16:23:11 +00:00
Owner
Copy Link

Info

Severity: HIGH
Attack vector: network-only

Impact

Allows revocation requests to remove the wrong wallet-access entries, causing unintended loss of permissions for other principals.

Description

The SDK and user-agent API exposes wallet-access entries with distinct row IDs, and the revocation path forwards those integer IDs unchanged from gRPC. The handler then deletes rows where evm_wallet_access.wallet_id == entry instead of deleting by the access-entry primary key.

Example flow

  1. Submit a revocation request containing wallet-access entry IDs.
  2. Forward those IDs into the server-side revocation handler.
  3. Delete rows by matching wallet_id instead of access-entry id.
  4. Remove unrelated principals' wallet permissions when an entry ID matches a wallet ID.

Mitigation

Delete by access-entry ID, validate ownership before deletion, and add tests covering mismatched wallet IDs and access-entry IDs.

# Info **Severity**: **HIGH** Attack vector: network-only ## Impact Allows revocation requests to remove the wrong wallet-access entries, causing unintended loss of permissions for other principals. ## Description The SDK and user-agent API exposes wallet-access entries with distinct row IDs, and the revocation path forwards those integer IDs unchanged from gRPC. The handler then deletes rows where `evm_wallet_access.wallet_id == entry` instead of deleting by the access-entry primary key. ## Example flow 1. Submit a revocation request containing wallet-access entry IDs. 2. Forward those IDs into the server-side revocation handler. 3. Delete rows by matching `wallet_id` instead of access-entry `id`. 4. Remove unrelated principals' wallet permissions when an entry ID matches a wallet ID. ## Mitigation Delete by access-entry ID, validate ownership before deletion, and add tests covering mismatched wallet IDs and access-entry IDs.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat
Breaking
Breaking change that won't be backward compatible
Difficulty
High
3
Hard difficulty. Experience needed to fix: A lot.
Difficulty
Low
1
Easy difficulty. Experience needed to fix: Not much. Good first issue.
Difficulty
Medium
2
Medium difficulty. Experience needed to fix: Intermediate.
Kind
Bug
This is a bug.
Kind
Enhancement
Improve existing functionality.
Kind
Feature
New functionality
Kind
RFC
Request for comments
Kind
Security
This is security issue
Kind
Testing
This is testing issue.
Kind
Tracking issue
An issue tracking the progress of sth. like the implementation of an RFC
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Pending
4
Requires review by dev
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CleverWild Skipper goodvin testuser
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#71
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?