MarketTakers/arbiter
5
0
Fork 0
Code Issues 27 Pull Requests 4 Packages Projects Releases Wiki Activity

Encrypted key material not bound to wallet address — cross-wallet signing possible #54

New Issue
Open
opened 2026-04-05 16:07:17 +00:00 by Skipper · 0 comments
Skipper commented 2026-04-05 16:07:17 +00:00
Owner
Copy Link

Description

The evm_wallet table is not integrity-protected, and the encrypted key material is not cryptographically bound to the wallet address. During signing, the code does not verify that the decrypted private key actually corresponds to the requested address.

Details

  • Severity: CRITICAL
    • Attack Vector: Offline

Impact

Allows an attacker to make the server sign transactions with another wallet's private key and spend funds from that wallet.

Example Flow

  1. Obtain any valid wallet access for wallet A.
    1. Modify the SQLite database so wallet A's row points to wallet B's encrypted private key.
    1. Request signing for wallet A.
    1. The server decrypts wallet B's key, skips key-to-address verification, and signs a transaction valid for wallet B.

Mitigation

Add integrity protection to evm_wallet, bind ciphertexts to wallet addresses using AAD or equivalent, and verify after decryption that the derived address matches the expected wallet address.

## Description The `evm_wallet` table is not integrity-protected, and the encrypted key material is not cryptographically bound to the wallet address. During signing, the code does not verify that the decrypted private key actually corresponds to the requested address. ## Details - **Severity:** CRITICAL - - **Attack Vector:** Offline ## Impact Allows an attacker to make the server sign transactions with another wallet's private key and spend funds from that wallet. ## Example Flow 1. Obtain any valid wallet access for wallet A. 2. 2. Modify the SQLite database so wallet A's row points to wallet B's encrypted private key. 3. 3. Request signing for wallet A. 4. 4. The server decrypts wallet B's key, skips key-to-address verification, and signs a transaction valid for wallet B. ## Mitigation Add integrity protection to `evm_wallet`, bind ciphertexts to wallet addresses using AAD or equivalent, and verify after decryption that the derived address matches the expected wallet address.
Skipper added the
Priority
Critical
1
Kind
Security
 labels 2026-04-05 16:07:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat
Breaking
Breaking change that won't be backward compatible
Difficulty
High
3
Hard difficulty. Experience needed to fix: A lot.
Difficulty
Low
1
Easy difficulty. Experience needed to fix: Not much. Good first issue.
Difficulty
Medium
2
Medium difficulty. Experience needed to fix: Intermediate.
Kind
Bug
This is a bug.
Kind
Enhancement
Improve existing functionality.
Kind
Feature
New functionality
Kind
RFC
Request for comments
Kind
Security
This is security issue
Kind
Testing
This is testing issue.
Kind
Tracking issue
An issue tracking the progress of sth. like the implementation of an RFC
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Pending
4
Requires review by dev
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind
Security
Priority
Critical
1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CleverWild Skipper goodvin testuser
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#54
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?