MarketTakers/arbiter
6
0
Fork 0
Code Issues 27 Pull Requests 2 Packages Projects Releases Wiki Activity

security(server): bind grant revocation state (revoked_at) to integrity hash #83

Open
CleverWild wants to merge 8 commits from security-hash-revoke_at into main
pull from: security-hash-revoke_at
merge into: MarketTakers:main
Conversation 3 Commits 8 Files Changed 18 +326 -72
CleverWild commented 2026-04-08 10:10:23 +00:00
Member
Copy Link

closes #56

closes #56
CleverWild added 1 commit 2026-04-08 10:10:23 +00:00
security(server): bind grant revocation state (revoked_at) to integrity hash
Some checks failed
ci/woodpecker/pr/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-lint Pipeline was successful
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
5a34463228
CleverWild requested review from Skipper 2026-04-08 10:10:23 +00:00
Skipper commented 2026-04-11 08:07:10 +00:00
Owner
Copy Link

We discuseed this: don't mix concerns

We discuseed this: don't mix concerns
Skipper requested changes 2026-04-11 08:07:44 +00:00
Dismissed
server/crates/arbiter-server/src/evm/mod.rs Outdated
@@ -394,6 +394,7 @@ mod tests {
chain: CHAIN_ID,
valid_from: None,
valid_until: None,
revoked_at: None,
Skipper commented 2026-04-11 08:07:40 +00:00
Owner
Copy Link

mixing concerns: should create a new business-object for signing containing this field

mixing concerns: should create a new business-object for signing containing this field
👍 1
CleverWild added 2 commits 2026-06-09 17:10:59 +00:00
revert(server): bind grant revocation state (revoked_at) to integrity hash e287459b10
Merge branch 'security-hash-revoke_at' of ssh://git.markettakers.org:22222/MarketTakers/arbiter into security-hash-revoke_at
Some checks failed
ci/woodpecker/pr/server-audit Pipeline failed
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline was successful
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
58a72da46c
CleverWild added 2 commits 2026-06-09 17:16:28 +00:00
refactor(evm): implement revoke_grant method for grant revocation b0a3f37cea
feat(evm): add wallet_access_id to grant deletion requests and revocation logic
Some checks failed
ci/woodpecker/pr/server-audit Pipeline failed
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline was successful
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
4bb2c062dc
CleverWild requested review from Skipper 2026-06-09 17:32:28 +00:00
CleverWild added 1 commit 2026-06-09 17:36:48 +00:00
security(evm): remove client-controlled wallet_access_id from grant revocation
Some checks failed
ci/woodpecker/pr/server-audit Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline was successful
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
32f317384d
Skipper approved these changes 2026-06-09 18:19:13 +00:00
CleverWild added 1 commit 2026-06-09 18:58:33 +00:00
Merge branch 'main' into security-hash-revoke_at
Some checks failed
ci/woodpecker/pr/server-lint Pipeline failed
Details
ci/woodpecker/pr/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
303120c9ac
CleverWild requested review from Skipper 2026-06-09 18:59:07 +00:00
CleverWild removed review request for Skipper 2026-06-09 18:59:15 +00:00
CleverWild added 1 commit 2026-06-09 19:07:07 +00:00
fix: lints
Some checks failed
ci/woodpecker/pr/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline was successful
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
d99c87c473
CleverWild requested review from Skipper 2026-06-09 19:08:12 +00:00
Some checks failed
ci/woodpecker/pr/server-audit Pipeline was successful
Required
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline was successful
Required
Details
ci/woodpecker/pr/server-test Pipeline was successful
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin security-hash-revoke_at:security-hash-revoke_at
git checkout security-hash-revoke_at
Sign in to join this conversation.
Reviewers
No Reviewers
Skipper
Labels
Clear labels
Compat
Breaking
Breaking change that won't be backward compatible
Difficulty
High
3
Hard difficulty. Experience needed to fix: A lot.
Difficulty
Low
1
Easy difficulty. Experience needed to fix: Not much. Good first issue.
Difficulty
Medium
2
Medium difficulty. Experience needed to fix: Intermediate.
Kind
Bug
This is a bug.
Kind
Enhancement
Improve existing functionality.
Kind
Feature
New functionality
Kind
RFC
Request for comments
Kind
Security
This is security issue
Kind
Testing
This is testing issue.
Kind
Tracking issue
An issue tracking the progress of sth. like the implementation of an RFC
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Pending
4
Requires review by dev
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CleverWild Skipper Tangonell goodvin testuser
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#83
Delete Branch "security-hash-revoke_at"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?