MarketTakers/arbiter
5
0
Fork 0
Code Issues 27 Pull Requests 4 Packages Projects Releases Wiki Activity

refactor(server): removed miette out of server #47

Merged
Skipper merged 3 commits from push-zmyvyloztluy into main 2026-04-05 07:57:41 +00:00
Conversation 2 Commits 3 Files Changed 36 +157 -200
Skipper commented 2026-04-04 10:10:49 +00:00
Owner
Copy Link
No description provided.
Skipper added 1 commit 2026-04-04 10:10:49 +00:00
refactor(server): removed miette out of server
Some checks failed
ci/woodpecker/pr/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-lint Pipeline failed
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
083ff66af2
CleverWild requested changes 2026-04-04 13:58:35 +00:00
CleverWild left a comment
Member
Copy Link

Is it always so ass-burning to review PRs where 99 percent of diffs are just formatter output?

Is it always so ass-burning to review PRs where 99 percent of diffs are just formatter output?
server/crates/arbiter-server/src/context/tls.rs Outdated
@@ -116,9 +110,7 @@ impl TlsCa {
];
params
.subject_alt_names
.push(SanType::IpAddress(IpAddr::from([
CleverWild commented 2026-04-04 13:55:54 +00:00
Member
Copy Link

In IpAddress might be a const named LocalHost, whose usage sounds better.

In IpAddress might be a const named LocalHost, whose usage sounds better.
Skipper marked this conversation as resolved
Skipper commented 2026-04-04 14:12:55 +00:00
Author
Owner
Copy Link

Is it always so ass-burning to review PRs where 99 percent of diffs are just formatter output?

welcome to the reality of reviewer :3

> Is it always so ass-burning to review PRs where 99 percent of diffs are just formatter output? welcome to the reality of reviewer :3
😕 1
Skipper added 1 commit 2026-04-04 14:14:16 +00:00
fix(server): use LOCALHOST const instead of hard-coded ip value
Some checks failed
ci/woodpecker/pr/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-lint Pipeline failed
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
9ea474e1b2
Skipper added 1 commit 2026-04-05 07:57:34 +00:00
Merge branch 'main' into push-zmyvyloztluy
Some checks failed
ci/woodpecker/push/server-lint Pipeline failed
Details
ci/woodpecker/pr/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-lint Pipeline failed
Details
ci/woodpecker/push/server-vet Pipeline failed
Details
ci/woodpecker/push/server-audit Pipeline was successful
Details
ci/woodpecker/pr/server-vet Pipeline failed
Details
ci/woodpecker/pr/server-test Pipeline was successful
Details
ci/woodpecker/push/server-test Pipeline was successful
Details
0daad1dd37
Skipper merged commit 0daad1dd37 into main 2026-04-05 07:57:41 +00:00
Skipper deleted branch push-zmyvyloztluy 2026-04-05 07:57:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
CleverWild
Labels
Clear labels
Compat
Breaking
Breaking change that won't be backward compatible
Difficulty
High
3
Hard difficulty. Experience needed to fix: A lot.
Difficulty
Low
1
Easy difficulty. Experience needed to fix: Not much. Good first issue.
Difficulty
Medium
2
Medium difficulty. Experience needed to fix: Intermediate.
Kind
Bug
This is a bug.
Kind
Enhancement
Improve existing functionality.
Kind
Feature
New functionality
Kind
RFC
Request for comments
Kind
Security
This is security issue
Kind
Testing
This is testing issue.
Kind
Tracking issue
An issue tracking the progress of sth. like the implementation of an RFC
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Pending
4
Requires review by dev
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CleverWild Skipper goodvin testuser
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#47
Delete Branch "push-zmyvyloztluy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?