Compare commits
76 Commits
main
...
e911165137
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
e911165137 | ||
|
|
a773255935 | ||
|
|
3f801abdff | ||
|
|
2b44570ab4 | ||
|
|
1f9b253433 | ||
|
|
a1c3ffd2d1 | ||
|
|
fd25de32a1 | ||
|
|
9ab074170b | ||
| 18b8a3bbf5 | |||
|
|
38cf1b98b9 | ||
|
|
9cf87b2058 | ||
|
|
929d50b589 | ||
|
|
70acfc99b5 | ||
| 28f84d03ab | |||
|
|
4a8e51ef32 | ||
|
|
9ee86afc19 | ||
|
|
790026e93b | ||
|
|
0e09afda5d | ||
|
|
51e6571d80 | ||
|
|
3b828d5874 | ||
|
|
a6f94e3115 | ||
|
|
f49e995c2f | ||
|
|
e88df432fb | ||
|
|
87ee0fe87b | ||
|
|
41b3fc5d39 | ||
|
|
f6a0c32b9d | ||
|
|
205227a3df | ||
|
|
a4070e7df7 | ||
|
|
6b8da567dd | ||
|
|
1585f90cae | ||
| 62dff3f810 | |||
|
|
6e22f368c9 | ||
| f3cf6a9438 | |||
|
|
a9f9fc2a9d | ||
|
|
d22ab49e3d | ||
|
|
a845181ef6 | ||
|
|
0d424f3afc | ||
|
|
1497884ce6 | ||
|
|
b3464cf8a6 | ||
|
|
46d1318b6f | ||
| 9c80d51d45 | |||
|
|
33456a644d | ||
|
|
5bc0c42cc7 | ||
|
|
f6b62ab884 | ||
|
|
2dd5a3f32f | ||
|
|
1aca9d4007 | ||
| 5ee1b49c43 | |||
|
|
00745bb381 | ||
|
|
b122aa464c | ||
|
|
9fab945a00 | ||
|
|
aeed664e9a | ||
|
|
4057c1fc12 | ||
|
|
f5eb51978d | ||
|
|
d997e0f843 | ||
|
|
7aca281a81 | ||
|
|
01b12515bd | ||
|
|
4a50daa7ea | ||
|
|
352ee3ee63 | ||
|
|
dd51d756da | ||
|
|
0bb6e596ac | ||
|
|
881f16bb1a | ||
|
|
78895bca5b | ||
|
|
a02ef68a70 | ||
|
|
e5be55e141 | ||
|
|
8f0eb7130b | ||
|
|
94fe04a6a4 | ||
|
|
976c11902c | ||
|
|
c8d2662a36 | ||
|
|
ac5fedddd1 | ||
|
|
0c2d4986a2 | ||
|
|
a3203936d2 | ||
|
|
fb1c0ec130 | ||
|
|
2a21758369 | ||
|
|
1abb5fa006 | ||
|
|
e1b1c857fa | ||
|
|
4216007af3 |
109
AGENTS.md
109
AGENTS.md
@@ -1,16 +1,13 @@
|
|||||||
# AGENTS.md
|
# AGENTS.md
|
||||||
|
|
||||||
Guidance for coding agents (Claude Code, Codex, …) working in this repository.
|
This file provides guidance to Codex (Codex.ai/code) when working with code in this repository.
|
||||||
|
|
||||||
## Project Overview
|
## Project Overview
|
||||||
|
|
||||||
Arbiter is a **permissioned signing service** for cryptocurrency wallets:
|
Arbiter is a **permissioned signing service** for cryptocurrency wallets. It consists of:
|
||||||
|
|
||||||
- **`server/`** — Rust gRPC daemon that holds encrypted keys and enforces policies
|
- **`server/`** — Rust gRPC daemon that holds encrypted keys and enforces policies
|
||||||
- **`useragent/`** — Flutter app (desktop + mobile + web targets) with a Rust core via `flutter_rust_bridge`
|
- **`operator/`** — Flutter desktop app (macOS/Windows) with a Rust backend via Rinf
|
||||||
- **`protobufs/`** — Protocol Buffer definitions shared between server and clients
|
- **`protobufs/`** — Protocol Buffer definitions shared between server and client
|
||||||
- **`docs/`** — `ARCHITECTURE.md` (peer types, flows, threat model) and `IMPLEMENTATION.md`; treat them as the design source of truth and update them when behaviour changes
|
|
||||||
- **`scripts/`** — helper scripts, e.g. `gen_erc20_registry.py`
|
|
||||||
|
|
||||||
The vault never exposes key material; it only produces signatures when requests satisfy configured policies.
|
The vault never exposes key material; it only produces signatures when requests satisfy configured policies.
|
||||||
|
|
||||||
@@ -21,7 +18,7 @@ Tools are managed via [mise](https://mise.jdx.dev/). Install all required tools:
|
|||||||
mise install
|
mise install
|
||||||
```
|
```
|
||||||
|
|
||||||
Key versions live in `mise.toml` (currently Rust 1.95.0 with clippy, Flutter 3.41.7-stable, protoc 29.6, diesel_cli 2.3.7 with `sqlite-bundled`, Python 3.14). Also provided there: `cargo-nextest`, `cargo-audit`, `cargo-vet`, `cargo-shear`, `cargo-mutants`, `cargo-features-manager`, `cargo-edit`, `ast-grep`, `flutter_rust_bridge_codegen`.
|
Key versions: Rust 1.93.0 (with clippy), Flutter 3.38.9-stable, protoc 29.6, diesel_cli 2.3.6 (sqlite).
|
||||||
|
|
||||||
## Server (Rust workspace at `server/`)
|
## Server (Rust workspace at `server/`)
|
||||||
|
|
||||||
@@ -29,14 +26,10 @@ Key versions live in `mise.toml` (currently Rust 1.95.0 with clippy, Flutter 3.4
|
|||||||
|
|
||||||
| Crate | Purpose |
|
| Crate | Purpose |
|
||||||
|---|---|
|
|---|---|
|
||||||
| `arbiter-proto` | Generated gRPC stubs + protobuf types (`tonic-prost-build`); also `ArbiterUrl`, `home_path()`, `BOOTSTRAP_PATH` |
|
| `arbiter-proto` | Generated gRPC stubs + protobuf types; compiled from `protobufs/*.proto` via `tonic-prost-build` |
|
||||||
| `arbiter-crypto` | Shared crypto primitives: `authn` (ML-DSA), `safecell` (hardened memory), `hashing::Hashable`, re-exported `x-wing` |
|
| `arbiter-server` | Main daemon — actors, DB, EVM policy engine, gRPC service implementation |
|
||||||
| `arbiter-macros` | `#[derive(Hashable)]` — canonical hashing of structs for the DB integrity layer |
|
| `arbiter-operator` | Rust client library for the operator side of the gRPC protocol |
|
||||||
| `arbiter-server` | Main daemon — actors, peers, DB, EVM policy engine, gRPC service implementation |
|
| `arbiter-client` | Rust client library for SDK clients |
|
||||||
| `arbiter-client` | Rust client library for SDK clients (`ArbiterClient`, EVM wallet, key storage) |
|
|
||||||
| `arbiter-tokens-registry` | Generated ERC-20 token registry used by token-transfer policies |
|
|
||||||
|
|
||||||
Workspace lints (`server/Cargo.toml`) are strict: most of clippy `pedantic`/`nursery` plus a large restriction set. `as` casts, indexing/slicing, `dbg!`, float arithmetic and undocumented `unsafe` are denied or warned — expect to add an `#[expect(..., reason = "...")]` rather than to silence a lint globally.
|
|
||||||
|
|
||||||
### Common Commands
|
### Common Commands
|
||||||
|
|
||||||
@@ -49,78 +42,54 @@ cargo build
|
|||||||
# Run the server daemon
|
# Run the server daemon
|
||||||
cargo run -p arbiter-server
|
cargo run -p arbiter-server
|
||||||
|
|
||||||
# Run all tests (preferred over cargo test; CI uses --all-features)
|
# Run all tests (preferred over cargo test)
|
||||||
cargo nextest run
|
cargo nextest run
|
||||||
|
|
||||||
# Run a single test
|
# Run a single test
|
||||||
cargo nextest run <test_name>
|
cargo nextest run <test_name>
|
||||||
|
|
||||||
# Lint (CI runs it with -D warnings)
|
# Lint
|
||||||
cargo clippy --all -- -D warnings
|
cargo clippy
|
||||||
|
|
||||||
# Security audit
|
# Security audit
|
||||||
cargo audit
|
cargo audit
|
||||||
|
|
||||||
# Supply-chain review (config in server/supply-chain/)
|
|
||||||
cargo vet
|
|
||||||
|
|
||||||
# Check unused dependencies
|
# Check unused dependencies
|
||||||
cargo shear
|
cargo shear
|
||||||
|
|
||||||
# Mutation testing
|
# Run snapshot tests and update snapshots
|
||||||
cargo mutants
|
cargo insta review
|
||||||
```
|
```
|
||||||
|
|
||||||
### CI
|
|
||||||
|
|
||||||
Woodpecker pipelines in `.woodpecker/` run on `server/**` changes: `server-lint` (clippy), `server-test` (nextest, `--all-features`), `server-audit`, `server-vet`, plus `useragent-analyze` for the Flutter app.
|
|
||||||
|
|
||||||
### Architecture
|
### Architecture
|
||||||
|
|
||||||
The server is actor-based using the **kameo** crate. Long-lived state lives in `GlobalActors` (`src/actors/mod.rs`):
|
The server is actor-based using the **kameo** crate. All long-lived state lives in `GlobalActors`:
|
||||||
|
|
||||||
- **`Bootstrapper`** — one-time bootstrap token, written to `~/.arbiter/bootstrap_token` on first run
|
- **`Bootstrapper`** — Manages the one-time bootstrap token written to `~/.arbiter/bootstrap_token` on first run.
|
||||||
- **`Vault`** — encrypted root key and the Sealed/Unsealed state machine; on unseal decrypts the root key into a `memsafe`-backed `SafeCell`
|
- **`Vault`** — Holds the encrypted root key and manages the Sealed/Unsealed vault state machine. On unseal, decrypts the root key into a `memsafe` hardened memory cell.
|
||||||
- **`FlowCoordinator`** — cross-connection flow between operators and SDK clients
|
- **`FlowCoordinator`** — Coordinates cross-connection flow between operators and SDK clients.
|
||||||
- **`OperatorRegistry`** — tracks currently connected operators
|
- **`EvmActor`** — Handles EVM transaction policy enforcement and signing.
|
||||||
- **`EvmActor`** — EVM transaction policy enforcement and signing
|
|
||||||
- **`events`** — a `kameo_actors::MessageBus` (`DeliveryStrategy::Guaranteed`) for cross-actor notifications
|
|
||||||
|
|
||||||
Per-connection state lives under **`src/peers/`**, not `actors/`: `peers/client/` and `peers/operator/`, each with `auth` (challenge-response) and `session` (post-auth) sub-modules; the operator side additionally has `vault_gate/` for the unseal handshake.
|
Per-connection actors live under `actors/operator/` and `actors/client/`, each with `auth` (challenge-response authentication) and `session` (post-auth operations) sub-modules.
|
||||||
|
|
||||||
The gRPC surface lives in **`src/grpc/`**, split per peer (`client/`, `operator/`, `common/`) and per direction (`inbound.rs` — requests to the daemon, `outbound.rs` — server-initiated streams), with `request_tracker.rs` correlating the two.
|
**Database:** SQLite via `diesel-async` + `bb8` connection pool. Schema managed by embedded Diesel migrations in `crates/arbiter-server/migrations/`. DB file lives at `~/.arbiter/arbiter.sqlite`. Tests use a temp-file DB via `db::create_test_pool()`.
|
||||||
|
|
||||||
EVM logic is in `src/evm/`: `policies/ether_transfer/`, `policies/token_transfers/`, `abi.rs`, `safe_signer.rs`.
|
|
||||||
|
|
||||||
**Database:** SQLite via `diesel-async` + `bb8`. Schema in `src/db/schema.rs`, models in `src/db/models.rs`, embedded migrations in `crates/arbiter-server/migrations/`. DB file lives at `~/.arbiter/arbiter.sqlite`; tests use a temp-file DB via `db::create_test_pool()`.
|
|
||||||
|
|
||||||
Entity ids are newtypes generated by the `declare_id!` macro in `db::models` (`OperatorId`, `ChainId`, …), each a `#[repr(transparent)]` wrapper over `i32` with `to_raw`/`from_raw`. Pass these around instead of bare `i32`.
|
|
||||||
|
|
||||||
**Row integrity:** sensitive rows are covered by an HMAC-SHA256 envelope (`src/crypto/integrity/`, table `integrity_envelope`), keyed from the vault root key. A struct becomes coverable by deriving `arbiter_macros::Hashable` and implementing `Integrable` (`KIND` + `VERSION`). When adding or changing a covered entity, keep the derive and the payload version in sync — a mismatch surfaces as `PayloadVersionMismatch` or `MacMismatch` at runtime.
|
|
||||||
|
|
||||||
**Cryptography:**
|
**Cryptography:**
|
||||||
- Authentication: **ML-DSA-87** (post-quantum, `arbiter-crypto::authn::v1`), challenge-response with per-peer nonce tracking
|
- Authentication: ed25519 (challenge-response, nonce-tracked per peer)
|
||||||
- Encryption at rest: XChaCha20-Poly1305, versioned modules (`crypto/encryption/v1.rs`) with a `schema_version` column for transparent migration on unseal
|
- Encryption at rest: XChaCha20-Poly1305 (versioned via `scheme` field for transparent migration on unseal)
|
||||||
- Password KDF: Argon2
|
- Password KDF: Argon2
|
||||||
- Unseal transport: X25519 ephemeral key exchange (`peers/operator/vault_gate/`); `x-wing` (hybrid PQ KEM) is available via `arbiter-crypto`
|
- Unseal transport: X25519 ephemeral key exchange
|
||||||
- TLS: self-signed certificate (rustls + aws-lc-rs, `prefer-post-quantum`), fingerprint distributed via `ArbiterUrl`
|
- TLS: self-signed certificate (aws-lc-rs backend), fingerprint distributed via `ArbiterUrl`
|
||||||
|
|
||||||
Crypto modules are versioned by convention: `mod.rs` re-exports the current `vN`. Add a `v(N+1)` rather than editing an existing version in place.
|
**Protocol:** gRPC with Protocol Buffers. The `ArbiterUrl` type encodes host, port, CA cert, and bootstrap token into a single shareable string (printed to console on first run).
|
||||||
|
|
||||||
**Protocol:** gRPC with Protocol Buffers. `ArbiterUrl` encodes host, port, CA cert and bootstrap token into a single shareable string (printed to console on first run).
|
|
||||||
|
|
||||||
### Proto Regeneration
|
### Proto Regeneration
|
||||||
|
|
||||||
`arbiter-proto/build.rs` compiles `arbiter.proto`, `operator.proto`, `client.proto` and `evm.proto` (with their `shared/`, `operator/`, `client/` includes) on build:
|
When `.proto` files in `protobufs/` change, rebuild to regenerate:
|
||||||
```sh
|
```sh
|
||||||
cd server && cargo build -p arbiter-proto
|
cd server && cargo build -p arbiter-proto
|
||||||
```
|
```
|
||||||
|
|
||||||
Dart protobuf stubs are generated separately, from the repo root:
|
|
||||||
```sh
|
|
||||||
mise run codegen # protoc --dart_out=grpc:useragent/lib/proto
|
|
||||||
```
|
|
||||||
|
|
||||||
### Database Migrations
|
### Database Migrations
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
@@ -131,8 +100,6 @@ diesel migration generate <name> --migration-dir crates/arbiter-server/migration
|
|||||||
diesel migration run --migration-dir crates/arbiter-server/migrations
|
diesel migration run --migration-dir crates/arbiter-server/migrations
|
||||||
```
|
```
|
||||||
|
|
||||||
Pre-release policy: there is a single `init` migration and no deployed databases yet, so schema changes are made by editing that migration directly instead of stacking new ones. Regenerate `src/db/schema.rs` after changing it.
|
|
||||||
|
|
||||||
### Code Conventions
|
### Code Conventions
|
||||||
|
|
||||||
**`#[must_use]` Attribute:**
|
**`#[must_use]` Attribute:**
|
||||||
@@ -154,23 +121,29 @@ pub fn verify(&self, nonce: i32, context: &[u8], signature: &Signature) -> bool
|
|||||||
|
|
||||||
This forces callers to either use the return value or explicitly ignore it with `let _ = ...;`, preventing silent failures.
|
This forces callers to either use the return value or explicitly ignore it with `let _ = ...;`, preventing silent failures.
|
||||||
|
|
||||||
## User Agent (Flutter + flutter_rust_bridge at `useragent/`)
|
## Operator (Flutter + Rinf at `operator/`)
|
||||||
|
|
||||||
The Flutter app calls Rust through [flutter_rust_bridge](https://cjycode.com/flutter_rust_bridge/) 2.12.0. The Rust side is the `rust_lib_arbiter` crate at `useragent/rust/`; everything exposed to Dart is declared in `useragent/rust/src/api/` and lands in `useragent/lib/src/rust/` (see `useragent/flutter_rust_bridge.yaml`). Dart UI code is organised as `lib/features/`, `lib/screens/`, `lib/widgets/`, `lib/providers/`, `lib/theme/`, with routing in `lib/router.dart` (`router.gr.dart` is generated).
|
The Flutter app uses [Rinf](https://rinf.cunarist.org) to call Rust code. The Rust logic lives in `operator/native/hub/` as a separate crate that uses `arbiter-operator` for the gRPC client.
|
||||||
|
|
||||||
|
Communication between Dart and Rust uses typed **signals** defined in `operator/native/hub/src/signals/`. After modifying signal structs, regenerate Dart bindings:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && rinf gen
|
||||||
|
```
|
||||||
|
|
||||||
### Common Commands
|
### Common Commands
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
cd useragent
|
cd operator
|
||||||
|
|
||||||
# Run the app
|
# Run the app (macOS or Windows)
|
||||||
flutter run
|
flutter run
|
||||||
|
|
||||||
# Regenerate Rust↔Dart bindings after editing rust/src/api/
|
# Regenerate Rust↔Dart signal bindings
|
||||||
mise run codegen # flutter_rust_bridge_codegen generate
|
rinf gen
|
||||||
|
|
||||||
# Analyze Dart code (also run in CI)
|
# Analyze Dart code
|
||||||
flutter analyze
|
flutter analyze
|
||||||
```
|
```
|
||||||
|
|
||||||
Note: `app/` contains only stale generated Flutter artifacts and is not the application source.
|
The Rinf Rust entry point is `operator/native/hub/src/lib.rs`. It spawns actors defined in `operator/native/hub/src/actors/` which handle Dart↔server communication via signals.
|
||||||
|
|||||||
1308
docs/superpowers/plans/2026-03-28-grant-creation-refactor.md
Normal file
1308
docs/superpowers/plans/2026-03-28-grant-creation-refactor.md
Normal file
File diff suppressed because it is too large
Load Diff
821
docs/superpowers/plans/2026-03-28-grant-grid-view.md
Normal file
821
docs/superpowers/plans/2026-03-28-grant-grid-view.md
Normal file
@@ -0,0 +1,821 @@
|
|||||||
|
# Grant Grid View Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Add an "EVM Grants" dashboard tab that displays all grants as enriched cards (type, chain, wallet address, client name) with per-card revoke support.
|
||||||
|
|
||||||
|
**Architecture:** A new `walletAccessListProvider` fetches wallet accesses with their DB row IDs. The screen (`grants.dart`) watches only `evmGrantsProvider` for top-level state. Each `GrantCard` widget (its own file) watches enrichment providers (`walletAccessListProvider`, `evmProvider`, `sdkClientsProvider`) and the revoke mutation directly — keeping rebuilds scoped to the card. The screen is registered as a dashboard tab in `AdaptiveScaffold`.
|
||||||
|
|
||||||
|
**Tech Stack:** Flutter, Riverpod (`riverpod_annotation` + `build_runner` codegen), `sizer` (adaptive sizing), `auto_route`, Protocol Buffers (Dart), `Palette` design tokens.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Map
|
||||||
|
|
||||||
|
| File | Action | Responsibility |
|
||||||
|
|---|---|---|
|
||||||
|
| `operator/lib/theme/palette.dart` | Modify | Add `Palette.token` (indigo accent for token-transfer cards) |
|
||||||
|
| `operator/lib/features/connection/evm/wallet_access.dart` | Modify | Add `listAllWalletAccesses()` function |
|
||||||
|
| `operator/lib/providers/sdk_clients/wallet_access_list.dart` | Create | `WalletAccessListProvider` — fetches full wallet access list with IDs |
|
||||||
|
| `operator/lib/screens/dashboard/evm/grants/widgets/grant_card.dart` | Create | `GrantCard` widget — watches enrichment providers + revoke mutation; one card per grant |
|
||||||
|
| `operator/lib/screens/dashboard/evm/grants/grants.dart` | Create | `EvmGrantsScreen` — watches `evmGrantsProvider`; handles loading/error/empty/data states; renders `GrantCard` list |
|
||||||
|
| `operator/lib/router.dart` | Modify | Register `EvmGrantsRoute` in dashboard children |
|
||||||
|
| `operator/lib/screens/dashboard.dart` | Modify | Add Grants entry to `routes` list and `NavigationDestination` list |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Add `Palette.token`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `operator/lib/theme/palette.dart`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add the color**
|
||||||
|
|
||||||
|
Replace the contents of `operator/lib/theme/palette.dart` with:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
import 'package:flutter/material.dart';
|
||||||
|
|
||||||
|
class Palette {
|
||||||
|
static const ink = Color(0xFF15263C);
|
||||||
|
static const coral = Color(0xFFE26254);
|
||||||
|
static const cream = Color(0xFFFFFAF4);
|
||||||
|
static const line = Color(0x1A15263C);
|
||||||
|
static const token = Color(0xFF5C6BC0);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Verify**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && flutter analyze lib/theme/palette.dart
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: no issues.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
jj describe -m "feat(theme): add Palette.token for token-transfer grant cards"
|
||||||
|
jj new
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: Add `listAllWalletAccesses` feature function
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `operator/lib/features/connection/evm/wallet_access.dart`
|
||||||
|
|
||||||
|
`readClientWalletAccess` (existing) filters the list to one client's wallet IDs and returns `Set<int>`. This new function returns the complete unfiltered list with row IDs so the grant cards can resolve wallet_access_id → wallet + client.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Append function**
|
||||||
|
|
||||||
|
Add at the bottom of `operator/lib/features/connection/evm/wallet_access.dart`:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
Future<List<SdkClientWalletAccess>> listAllWalletAccesses(
|
||||||
|
Connection connection,
|
||||||
|
) async {
|
||||||
|
final response = await connection.ask(
|
||||||
|
OperatorRequest(listWalletAccess: Empty()),
|
||||||
|
);
|
||||||
|
if (!response.hasListWalletAccessResponse()) {
|
||||||
|
throw Exception(
|
||||||
|
'Expected list wallet access response, got ${response.whichPayload()}',
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return response.listWalletAccessResponse.accesses.toList(growable: false);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Each returned `SdkClientWalletAccess` has:
|
||||||
|
- `.id` — the `evm_wallet_access` row ID (same value as `wallet_access_id` in a `GrantEntry`)
|
||||||
|
- `.access.walletId` — the EVM wallet DB ID
|
||||||
|
- `.access.sdkClientId` — the SDK client DB ID
|
||||||
|
|
||||||
|
- [ ] **Step 2: Verify**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && flutter analyze lib/features/connection/evm/wallet_access.dart
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: no issues.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
jj describe -m "feat(evm): add listAllWalletAccesses feature function"
|
||||||
|
jj new
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: Create `WalletAccessListProvider`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `operator/lib/providers/sdk_clients/wallet_access_list.dart`
|
||||||
|
- Generated: `operator/lib/providers/sdk_clients/wallet_access_list.g.dart`
|
||||||
|
|
||||||
|
Mirrors the structure of `EvmGrants` in `providers/evm/evm_grants.dart` — class-based `@riverpod` with a `refresh()` method.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the provider**
|
||||||
|
|
||||||
|
Create `operator/lib/providers/sdk_clients/wallet_access_list.dart`:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
import 'package:arbiter/features/connection/evm/wallet_access.dart';
|
||||||
|
import 'package:arbiter/proto/operator.pb.dart';
|
||||||
|
import 'package:arbiter/providers/connection/connection_manager.dart';
|
||||||
|
import 'package:mtcore/markettakers.dart';
|
||||||
|
import 'package:riverpod_annotation/riverpod_annotation.dart';
|
||||||
|
|
||||||
|
part 'wallet_access_list.g.dart';
|
||||||
|
|
||||||
|
@riverpod
|
||||||
|
class WalletAccessList extends _$WalletAccessList {
|
||||||
|
@override
|
||||||
|
Future<List<SdkClientWalletAccess>?> build() async {
|
||||||
|
final connection = await ref.watch(connectionManagerProvider.future);
|
||||||
|
if (connection == null) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
try {
|
||||||
|
return await listAllWalletAccesses(connection);
|
||||||
|
} catch (e, st) {
|
||||||
|
talker.handle(e, st);
|
||||||
|
rethrow;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
Future<void> refresh() async {
|
||||||
|
final connection = await ref.read(connectionManagerProvider.future);
|
||||||
|
if (connection == null) {
|
||||||
|
state = const AsyncData(null);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
state = const AsyncLoading();
|
||||||
|
state = await AsyncValue.guard(() => listAllWalletAccesses(connection));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run code generation**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && dart run build_runner build --delete-conflicting-outputs
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: `operator/lib/providers/sdk_clients/wallet_access_list.g.dart` created. No errors.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Verify**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && flutter analyze lib/providers/sdk_clients/
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: no issues.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
jj describe -m "feat(providers): add WalletAccessListProvider"
|
||||||
|
jj new
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: Create `GrantCard` widget
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `operator/lib/screens/dashboard/evm/grants/widgets/grant_card.dart`
|
||||||
|
|
||||||
|
This widget owns all per-card logic: enrichment lookups, revoke action, and rebuild scope. The screen only passes it a `GrantEntry` — the card fetches everything else itself.
|
||||||
|
|
||||||
|
**Key types:**
|
||||||
|
- `GrantEntry` (from `proto/evm.pb.dart`): `.id`, `.shared.walletAccessId`, `.shared.chainId`, `.specific.whichGrant()`
|
||||||
|
- `SpecificGrant_Grant.etherTransfer` / `.tokenTransfer` — enum values for the oneof
|
||||||
|
- `SdkClientWalletAccess` (from `proto/operator.pb.dart`): `.id`, `.access.walletId`, `.access.sdkClientId`
|
||||||
|
- `WalletEntry` (from `proto/evm.pb.dart`): `.id`, `.address` (List<int>)
|
||||||
|
- `SdkClientEntry` (from `proto/operator.pb.dart`): `.id`, `.info.name`
|
||||||
|
- `revokeEvmGrantMutation` — `Mutation<void>` (global; all revoke buttons disable together while any revoke is in flight)
|
||||||
|
- `executeRevokeEvmGrant(ref, grantId: int)` — `Future<void>`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the widget**
|
||||||
|
|
||||||
|
Create `operator/lib/screens/dashboard/evm/grants/widgets/grant_card.dart`:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
import 'package:arbiter/proto/evm.pb.dart';
|
||||||
|
import 'package:arbiter/proto/operator.pb.dart';
|
||||||
|
import 'package:arbiter/providers/evm/evm.dart';
|
||||||
|
import 'package:arbiter/providers/evm/evm_grants.dart';
|
||||||
|
import 'package:arbiter/providers/sdk_clients/list.dart';
|
||||||
|
import 'package:arbiter/providers/sdk_clients/wallet_access_list.dart';
|
||||||
|
import 'package:arbiter/theme/palette.dart';
|
||||||
|
import 'package:flutter/material.dart';
|
||||||
|
import 'package:hooks_riverpod/experimental/mutation.dart';
|
||||||
|
import 'package:hooks_riverpod/hooks_riverpod.dart';
|
||||||
|
import 'package:sizer/sizer.dart';
|
||||||
|
|
||||||
|
String _shortAddress(List<int> bytes) {
|
||||||
|
final hex = bytes.map((b) => b.toRadixString(16).padLeft(2, '0')).join();
|
||||||
|
return '0x${hex.substring(0, 6)}...${hex.substring(hex.length - 4)}';
|
||||||
|
}
|
||||||
|
|
||||||
|
String _formatError(Object error) {
|
||||||
|
final message = error.toString();
|
||||||
|
if (message.startsWith('Exception: ')) {
|
||||||
|
return message.substring('Exception: '.length);
|
||||||
|
}
|
||||||
|
return message;
|
||||||
|
}
|
||||||
|
|
||||||
|
class GrantCard extends ConsumerWidget {
|
||||||
|
const GrantCard({super.key, required this.grant});
|
||||||
|
|
||||||
|
final GrantEntry grant;
|
||||||
|
|
||||||
|
@override
|
||||||
|
Widget build(BuildContext context, WidgetRef ref) {
|
||||||
|
// Enrichment lookups — each watch scopes rebuilds to this card only
|
||||||
|
final walletAccesses =
|
||||||
|
ref.watch(walletAccessListProvider).asData?.value ?? const [];
|
||||||
|
final wallets = ref.watch(evmProvider).asData?.value ?? const [];
|
||||||
|
final clients = ref.watch(sdkClientsProvider).asData?.value ?? const [];
|
||||||
|
final revoking = ref.watch(revokeEvmGrantMutation) is MutationPending;
|
||||||
|
|
||||||
|
final isEther =
|
||||||
|
grant.specific.whichGrant() == SpecificGrant_Grant.etherTransfer;
|
||||||
|
final accent = isEther ? Palette.coral : Palette.token;
|
||||||
|
final typeLabel = isEther ? 'Ether' : 'Token';
|
||||||
|
final theme = Theme.of(context);
|
||||||
|
final muted = Palette.ink.withValues(alpha: 0.62);
|
||||||
|
|
||||||
|
// Resolve wallet_access_id → wallet address + client name
|
||||||
|
final accessById = <int, SdkClientWalletAccess>{
|
||||||
|
for (final a in walletAccesses) a.id: a,
|
||||||
|
};
|
||||||
|
final walletById = <int, WalletEntry>{
|
||||||
|
for (final w in wallets) w.id: w,
|
||||||
|
};
|
||||||
|
final clientNameById = <int, String>{
|
||||||
|
for (final c in clients) c.id: c.info.name,
|
||||||
|
};
|
||||||
|
|
||||||
|
final accessId = grant.shared.walletAccessId;
|
||||||
|
final access = accessById[accessId];
|
||||||
|
final wallet = access != null ? walletById[access.access.walletId] : null;
|
||||||
|
|
||||||
|
final walletLabel = wallet != null
|
||||||
|
? _shortAddress(wallet.address)
|
||||||
|
: 'Access #$accessId';
|
||||||
|
|
||||||
|
final clientLabel = () {
|
||||||
|
if (access == null) return '';
|
||||||
|
final name = clientNameById[access.access.sdkClientId] ?? '';
|
||||||
|
return name.isEmpty ? 'Client #${access.access.sdkClientId}' : name;
|
||||||
|
}();
|
||||||
|
|
||||||
|
void showError(String message) {
|
||||||
|
if (!context.mounted) return;
|
||||||
|
ScaffoldMessenger.of(context).showSnackBar(
|
||||||
|
SnackBar(content: Text(message), behavior: SnackBarBehavior.floating),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
Future<void> revoke() async {
|
||||||
|
try {
|
||||||
|
await executeRevokeEvmGrant(ref, grantId: grant.id);
|
||||||
|
} catch (e) {
|
||||||
|
showError(_formatError(e));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return Container(
|
||||||
|
decoration: BoxDecoration(
|
||||||
|
borderRadius: BorderRadius.circular(24),
|
||||||
|
color: Palette.cream.withValues(alpha: 0.92),
|
||||||
|
border: Border.all(color: Palette.line),
|
||||||
|
),
|
||||||
|
child: IntrinsicHeight(
|
||||||
|
child: Row(
|
||||||
|
crossAxisAlignment: CrossAxisAlignment.stretch,
|
||||||
|
children: [
|
||||||
|
// Accent strip
|
||||||
|
Container(
|
||||||
|
width: 0.8.w,
|
||||||
|
decoration: BoxDecoration(
|
||||||
|
color: accent,
|
||||||
|
borderRadius: const BorderRadius.horizontal(
|
||||||
|
left: Radius.circular(24),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
// Card body
|
||||||
|
Expanded(
|
||||||
|
child: Padding(
|
||||||
|
padding: EdgeInsets.symmetric(
|
||||||
|
horizontal: 1.6.w,
|
||||||
|
vertical: 1.4.h,
|
||||||
|
),
|
||||||
|
child: Column(
|
||||||
|
crossAxisAlignment: CrossAxisAlignment.start,
|
||||||
|
children: [
|
||||||
|
// Row 1: type badge · chain · spacer · revoke button
|
||||||
|
Row(
|
||||||
|
children: [
|
||||||
|
Container(
|
||||||
|
padding: EdgeInsets.symmetric(
|
||||||
|
horizontal: 1.w,
|
||||||
|
vertical: 0.4.h,
|
||||||
|
),
|
||||||
|
decoration: BoxDecoration(
|
||||||
|
color: accent.withValues(alpha: 0.15),
|
||||||
|
borderRadius: BorderRadius.circular(8),
|
||||||
|
),
|
||||||
|
child: Text(
|
||||||
|
typeLabel,
|
||||||
|
style: theme.textTheme.labelSmall?.copyWith(
|
||||||
|
color: accent,
|
||||||
|
fontWeight: FontWeight.w800,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
SizedBox(width: 1.w),
|
||||||
|
Container(
|
||||||
|
padding: EdgeInsets.symmetric(
|
||||||
|
horizontal: 1.w,
|
||||||
|
vertical: 0.4.h,
|
||||||
|
),
|
||||||
|
decoration: BoxDecoration(
|
||||||
|
color: Palette.ink.withValues(alpha: 0.06),
|
||||||
|
borderRadius: BorderRadius.circular(8),
|
||||||
|
),
|
||||||
|
child: Text(
|
||||||
|
'Chain ${grant.shared.chainId}',
|
||||||
|
style: theme.textTheme.labelSmall?.copyWith(
|
||||||
|
color: muted,
|
||||||
|
fontWeight: FontWeight.w700,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
const Spacer(),
|
||||||
|
if (revoking)
|
||||||
|
SizedBox(
|
||||||
|
width: 1.8.h,
|
||||||
|
height: 1.8.h,
|
||||||
|
child: CircularProgressIndicator(
|
||||||
|
strokeWidth: 2,
|
||||||
|
color: Palette.coral,
|
||||||
|
),
|
||||||
|
)
|
||||||
|
else
|
||||||
|
OutlinedButton.icon(
|
||||||
|
onPressed: revoke,
|
||||||
|
style: OutlinedButton.styleFrom(
|
||||||
|
foregroundColor: Palette.coral,
|
||||||
|
side: BorderSide(
|
||||||
|
color: Palette.coral.withValues(alpha: 0.4),
|
||||||
|
),
|
||||||
|
padding: EdgeInsets.symmetric(
|
||||||
|
horizontal: 1.w,
|
||||||
|
vertical: 0.6.h,
|
||||||
|
),
|
||||||
|
shape: RoundedRectangleBorder(
|
||||||
|
borderRadius: BorderRadius.circular(10),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
icon: const Icon(Icons.block_rounded, size: 16),
|
||||||
|
label: const Text('Revoke'),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
SizedBox(height: 0.8.h),
|
||||||
|
// Row 2: wallet address · client name
|
||||||
|
Row(
|
||||||
|
children: [
|
||||||
|
Text(
|
||||||
|
walletLabel,
|
||||||
|
style: theme.textTheme.bodySmall?.copyWith(
|
||||||
|
color: Palette.ink,
|
||||||
|
fontFamily: 'monospace',
|
||||||
|
),
|
||||||
|
),
|
||||||
|
Padding(
|
||||||
|
padding: EdgeInsets.symmetric(horizontal: 0.8.w),
|
||||||
|
child: Text(
|
||||||
|
'·',
|
||||||
|
style: theme.textTheme.bodySmall
|
||||||
|
?.copyWith(color: muted),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
Expanded(
|
||||||
|
child: Text(
|
||||||
|
clientLabel,
|
||||||
|
maxLines: 1,
|
||||||
|
overflow: TextOverflow.ellipsis,
|
||||||
|
style: theme.textTheme.bodySmall
|
||||||
|
?.copyWith(color: muted),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Verify**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && flutter analyze lib/screens/dashboard/evm/grants/widgets/grant_card.dart
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: no issues.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
jj describe -m "feat(grants): add GrantCard widget with self-contained enrichment"
|
||||||
|
jj new
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: Create `EvmGrantsScreen`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `operator/lib/screens/dashboard/evm/grants/grants.dart`
|
||||||
|
|
||||||
|
The screen watches only `evmGrantsProvider` for top-level state (loading / error / no connection / empty / data). When there is data it renders a list of `GrantCard` widgets — each card manages its own enrichment subscriptions.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the screen**
|
||||||
|
|
||||||
|
Create `operator/lib/screens/dashboard/evm/grants/grants.dart`:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
import 'package:arbiter/proto/evm.pb.dart';
|
||||||
|
import 'package:arbiter/providers/evm/evm_grants.dart';
|
||||||
|
import 'package:arbiter/providers/sdk_clients/wallet_access_list.dart';
|
||||||
|
import 'package:arbiter/router.gr.dart';
|
||||||
|
import 'package:arbiter/screens/dashboard/evm/grants/widgets/grant_card.dart';
|
||||||
|
import 'package:arbiter/theme/palette.dart';
|
||||||
|
import 'package:arbiter/widgets/page_header.dart';
|
||||||
|
import 'package:auto_route/auto_route.dart';
|
||||||
|
import 'package:flutter/material.dart';
|
||||||
|
import 'package:hooks_riverpod/hooks_riverpod.dart';
|
||||||
|
import 'package:sizer/sizer.dart';
|
||||||
|
|
||||||
|
String _formatError(Object error) {
|
||||||
|
final message = error.toString();
|
||||||
|
if (message.startsWith('Exception: ')) {
|
||||||
|
return message.substring('Exception: '.length);
|
||||||
|
}
|
||||||
|
return message;
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── State panel ──────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
class _StatePanel extends StatelessWidget {
|
||||||
|
const _StatePanel({
|
||||||
|
required this.icon,
|
||||||
|
required this.title,
|
||||||
|
required this.body,
|
||||||
|
this.actionLabel,
|
||||||
|
this.onAction,
|
||||||
|
this.busy = false,
|
||||||
|
});
|
||||||
|
|
||||||
|
final IconData icon;
|
||||||
|
final String title;
|
||||||
|
final String body;
|
||||||
|
final String? actionLabel;
|
||||||
|
final Future<void> Function()? onAction;
|
||||||
|
final bool busy;
|
||||||
|
|
||||||
|
@override
|
||||||
|
Widget build(BuildContext context) {
|
||||||
|
final theme = Theme.of(context);
|
||||||
|
|
||||||
|
return Container(
|
||||||
|
decoration: BoxDecoration(
|
||||||
|
borderRadius: BorderRadius.circular(24),
|
||||||
|
color: Palette.cream.withValues(alpha: 0.92),
|
||||||
|
border: Border.all(color: Palette.line),
|
||||||
|
),
|
||||||
|
child: Padding(
|
||||||
|
padding: EdgeInsets.all(2.8.h),
|
||||||
|
child: Column(
|
||||||
|
crossAxisAlignment: CrossAxisAlignment.start,
|
||||||
|
children: [
|
||||||
|
if (busy)
|
||||||
|
SizedBox(
|
||||||
|
width: 2.8.h,
|
||||||
|
height: 2.8.h,
|
||||||
|
child: const CircularProgressIndicator(strokeWidth: 2.5),
|
||||||
|
)
|
||||||
|
else
|
||||||
|
Icon(icon, size: 34, color: Palette.coral),
|
||||||
|
SizedBox(height: 1.8.h),
|
||||||
|
Text(
|
||||||
|
title,
|
||||||
|
style: theme.textTheme.headlineSmall?.copyWith(
|
||||||
|
color: Palette.ink,
|
||||||
|
fontWeight: FontWeight.w800,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
SizedBox(height: 1.h),
|
||||||
|
Text(
|
||||||
|
body,
|
||||||
|
style: theme.textTheme.bodyLarge?.copyWith(
|
||||||
|
color: Palette.ink.withValues(alpha: 0.72),
|
||||||
|
height: 1.5,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
if (actionLabel != null && onAction != null) ...[
|
||||||
|
SizedBox(height: 2.h),
|
||||||
|
OutlinedButton.icon(
|
||||||
|
onPressed: () => onAction!(),
|
||||||
|
icon: const Icon(Icons.refresh),
|
||||||
|
label: Text(actionLabel!),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
],
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── Grant list ───────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
class _GrantList extends StatelessWidget {
|
||||||
|
const _GrantList({required this.grants});
|
||||||
|
|
||||||
|
final List<GrantEntry> grants;
|
||||||
|
|
||||||
|
@override
|
||||||
|
Widget build(BuildContext context) {
|
||||||
|
return Column(
|
||||||
|
children: [
|
||||||
|
for (var i = 0; i < grants.length; i++)
|
||||||
|
Padding(
|
||||||
|
padding: EdgeInsets.only(
|
||||||
|
bottom: i == grants.length - 1 ? 0 : 1.8.h,
|
||||||
|
),
|
||||||
|
child: GrantCard(grant: grants[i]),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// ─── Screen ───────────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
|
@RoutePage()
|
||||||
|
class EvmGrantsScreen extends ConsumerWidget {
|
||||||
|
const EvmGrantsScreen({super.key});
|
||||||
|
|
||||||
|
@override
|
||||||
|
Widget build(BuildContext context, WidgetRef ref) {
|
||||||
|
// Screen watches only the grant list for top-level state decisions
|
||||||
|
final grantsAsync = ref.watch(evmGrantsProvider);
|
||||||
|
|
||||||
|
Future<void> refresh() async {
|
||||||
|
await Future.wait([
|
||||||
|
ref.read(evmGrantsProvider.notifier).refresh(),
|
||||||
|
ref.read(walletAccessListProvider.notifier).refresh(),
|
||||||
|
]);
|
||||||
|
}
|
||||||
|
|
||||||
|
void showMessage(String message) {
|
||||||
|
if (!context.mounted) return;
|
||||||
|
ScaffoldMessenger.of(context).showSnackBar(
|
||||||
|
SnackBar(content: Text(message), behavior: SnackBarBehavior.floating),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
Future<void> safeRefresh() async {
|
||||||
|
try {
|
||||||
|
await refresh();
|
||||||
|
} catch (e) {
|
||||||
|
showMessage(_formatError(e));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
final grantsState = grantsAsync.asData?.value;
|
||||||
|
final grants = grantsState?.grants;
|
||||||
|
|
||||||
|
final content = switch (grantsAsync) {
|
||||||
|
AsyncLoading() when grantsState == null => const _StatePanel(
|
||||||
|
icon: Icons.hourglass_top,
|
||||||
|
title: 'Loading grants',
|
||||||
|
body: 'Pulling grant registry from Arbiter.',
|
||||||
|
busy: true,
|
||||||
|
),
|
||||||
|
AsyncError(:final error) => _StatePanel(
|
||||||
|
icon: Icons.sync_problem,
|
||||||
|
title: 'Grant registry unavailable',
|
||||||
|
body: _formatError(error),
|
||||||
|
actionLabel: 'Retry',
|
||||||
|
onAction: safeRefresh,
|
||||||
|
),
|
||||||
|
AsyncData(:final value) when value == null => _StatePanel(
|
||||||
|
icon: Icons.portable_wifi_off,
|
||||||
|
title: 'No active server connection',
|
||||||
|
body: 'Reconnect to Arbiter to list EVM grants.',
|
||||||
|
actionLabel: 'Refresh',
|
||||||
|
onAction: safeRefresh,
|
||||||
|
),
|
||||||
|
_ when grants != null && grants.isEmpty => _StatePanel(
|
||||||
|
icon: Icons.policy_outlined,
|
||||||
|
title: 'No grants yet',
|
||||||
|
body: 'Create a grant to allow SDK clients to sign transactions.',
|
||||||
|
actionLabel: 'Create grant',
|
||||||
|
onAction: () => context.router.push(const CreateEvmGrantRoute()),
|
||||||
|
),
|
||||||
|
_ => _GrantList(grants: grants ?? const []),
|
||||||
|
};
|
||||||
|
|
||||||
|
return Scaffold(
|
||||||
|
body: SafeArea(
|
||||||
|
child: RefreshIndicator.adaptive(
|
||||||
|
color: Palette.ink,
|
||||||
|
backgroundColor: Colors.white,
|
||||||
|
onRefresh: safeRefresh,
|
||||||
|
child: ListView(
|
||||||
|
physics: const BouncingScrollPhysics(
|
||||||
|
parent: AlwaysScrollableScrollPhysics(),
|
||||||
|
),
|
||||||
|
padding: EdgeInsets.fromLTRB(2.4.w, 2.4.h, 2.4.w, 3.2.h),
|
||||||
|
children: [
|
||||||
|
PageHeader(
|
||||||
|
title: 'EVM Grants',
|
||||||
|
isBusy: grantsAsync.isLoading,
|
||||||
|
actions: [
|
||||||
|
FilledButton.icon(
|
||||||
|
onPressed: () =>
|
||||||
|
context.router.push(const CreateEvmGrantRoute()),
|
||||||
|
icon: const Icon(Icons.add_rounded),
|
||||||
|
label: const Text('Create grant'),
|
||||||
|
),
|
||||||
|
SizedBox(width: 1.w),
|
||||||
|
OutlinedButton.icon(
|
||||||
|
onPressed: safeRefresh,
|
||||||
|
style: OutlinedButton.styleFrom(
|
||||||
|
foregroundColor: Palette.ink,
|
||||||
|
side: BorderSide(color: Palette.line),
|
||||||
|
padding: EdgeInsets.symmetric(
|
||||||
|
horizontal: 1.4.w,
|
||||||
|
vertical: 1.2.h,
|
||||||
|
),
|
||||||
|
shape: RoundedRectangleBorder(
|
||||||
|
borderRadius: BorderRadius.circular(14),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
icon: const Icon(Icons.refresh, size: 18),
|
||||||
|
label: const Text('Refresh'),
|
||||||
|
),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
SizedBox(height: 1.8.h),
|
||||||
|
content,
|
||||||
|
],
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Verify**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && flutter analyze lib/screens/dashboard/evm/grants/
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: no issues.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
jj describe -m "feat(grants): add EvmGrantsScreen"
|
||||||
|
jj new
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: Wire router and dashboard tab
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `operator/lib/router.dart`
|
||||||
|
- Modify: `operator/lib/screens/dashboard.dart`
|
||||||
|
- Regenerated: `operator/lib/router.gr.dart`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add route to `router.dart`**
|
||||||
|
|
||||||
|
Replace the contents of `operator/lib/router.dart` with:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
import 'package:auto_route/auto_route.dart';
|
||||||
|
|
||||||
|
import 'router.gr.dart';
|
||||||
|
|
||||||
|
@AutoRouterConfig(generateForDir: ['lib/screens'])
|
||||||
|
class Router extends RootStackRouter {
|
||||||
|
@override
|
||||||
|
List<AutoRoute> get routes => [
|
||||||
|
AutoRoute(page: Bootstrap.page, path: '/bootstrap', initial: true),
|
||||||
|
AutoRoute(page: ServerInfoSetupRoute.page, path: '/server-info'),
|
||||||
|
AutoRoute(page: ServerConnectionRoute.page, path: '/server-connection'),
|
||||||
|
AutoRoute(page: VaultSetupRoute.page, path: '/vault'),
|
||||||
|
AutoRoute(page: ClientDetailsRoute.page, path: '/clients/:clientId'),
|
||||||
|
AutoRoute(page: CreateEvmGrantRoute.page, path: '/evm-grants/create'),
|
||||||
|
|
||||||
|
AutoRoute(
|
||||||
|
page: DashboardRouter.page,
|
||||||
|
path: '/dashboard',
|
||||||
|
children: [
|
||||||
|
AutoRoute(page: EvmRoute.page, path: 'evm'),
|
||||||
|
AutoRoute(page: ClientsRoute.page, path: 'clients'),
|
||||||
|
AutoRoute(page: EvmGrantsRoute.page, path: 'grants'),
|
||||||
|
AutoRoute(page: AboutRoute.page, path: 'about'),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update `dashboard.dart`**
|
||||||
|
|
||||||
|
In `operator/lib/screens/dashboard.dart`, replace the `routes` constant:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
final routes = [
|
||||||
|
const EvmRoute(),
|
||||||
|
const ClientsRoute(),
|
||||||
|
const EvmGrantsRoute(),
|
||||||
|
const AboutRoute(),
|
||||||
|
];
|
||||||
|
```
|
||||||
|
|
||||||
|
And replace the `destinations` list inside `AdaptiveScaffold`:
|
||||||
|
|
||||||
|
```dart
|
||||||
|
destinations: const [
|
||||||
|
NavigationDestination(
|
||||||
|
icon: Icon(Icons.account_balance_wallet_outlined),
|
||||||
|
selectedIcon: Icon(Icons.account_balance_wallet),
|
||||||
|
label: 'Wallets',
|
||||||
|
),
|
||||||
|
NavigationDestination(
|
||||||
|
icon: Icon(Icons.devices_other_outlined),
|
||||||
|
selectedIcon: Icon(Icons.devices_other),
|
||||||
|
label: 'Clients',
|
||||||
|
),
|
||||||
|
NavigationDestination(
|
||||||
|
icon: Icon(Icons.policy_outlined),
|
||||||
|
selectedIcon: Icon(Icons.policy),
|
||||||
|
label: 'Grants',
|
||||||
|
),
|
||||||
|
NavigationDestination(
|
||||||
|
icon: Icon(Icons.info_outline),
|
||||||
|
selectedIcon: Icon(Icons.info),
|
||||||
|
label: 'About',
|
||||||
|
),
|
||||||
|
],
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Regenerate router**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && dart run build_runner build --delete-conflicting-outputs
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: `lib/router.gr.dart` updated, `EvmGrantsRoute` now available, no errors.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Full project verify**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd operator && flutter analyze
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: no issues.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```sh
|
||||||
|
jj describe -m "feat(nav): add Grants dashboard tab"
|
||||||
|
jj new
|
||||||
|
```
|
||||||
170
docs/superpowers/specs/2026-03-28-grant-grid-view-design.md
Normal file
170
docs/superpowers/specs/2026-03-28-grant-grid-view-design.md
Normal file
@@ -0,0 +1,170 @@
|
|||||||
|
# Grant Grid View — Design Spec
|
||||||
|
|
||||||
|
**Date:** 2026-03-28
|
||||||
|
|
||||||
|
## Overview
|
||||||
|
|
||||||
|
Add a "Grants" dashboard tab to the Flutter operator app that displays all EVM grants as a card-based grid. Each card shows a compact summary (type, chain, wallet address, client name) with a revoke action. The tab integrates into the existing `AdaptiveScaffold` navigation alongside Wallets, Clients, and About.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
- New `walletAccessListProvider` for fetching wallet access entries with their DB row IDs
|
||||||
|
- New `EvmGrantsScreen` as a dashboard tab
|
||||||
|
- Grant card widget with enriched display (type, chain, wallet, client)
|
||||||
|
- Revoke action wired to existing `executeRevokeEvmGrant` mutation
|
||||||
|
- Dashboard tab bar and router updated
|
||||||
|
- New token-transfer accent color added to `Palette`
|
||||||
|
|
||||||
|
**Out of scope:** Fixing grant creation (separate task).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Data Layer
|
||||||
|
|
||||||
|
### `walletAccessListProvider`
|
||||||
|
|
||||||
|
**File:** `operator/lib/providers/sdk_clients/wallet_access_list.dart`
|
||||||
|
|
||||||
|
- `@riverpod` class, watches `connectionManagerProvider.future`
|
||||||
|
- Returns `List<SdkClientWalletAccess>?` (null when not connected)
|
||||||
|
- Each entry: `.id` (wallet_access_id), `.access.walletId`, `.access.sdkClientId`
|
||||||
|
- Exposes a `refresh()` method following the same pattern as `EvmGrants.refresh()`
|
||||||
|
|
||||||
|
### Enrichment at render time (Approach A)
|
||||||
|
|
||||||
|
The `EvmGrantsScreen` watches four providers:
|
||||||
|
1. `evmGrantsProvider` — the grant list
|
||||||
|
2. `walletAccessListProvider` — to resolve wallet_access_id → (wallet_id, sdk_client_id)
|
||||||
|
3. `evmProvider` — to resolve wallet_id → wallet address
|
||||||
|
4. `sdkClientsProvider` — to resolve sdk_client_id → client name
|
||||||
|
|
||||||
|
All lookups are in-memory Maps built inside the build method; no extra model class needed.
|
||||||
|
|
||||||
|
Fallbacks:
|
||||||
|
- Wallet address not found → `"Access #N"` where N is the wallet_access_id
|
||||||
|
- Client name not found → `"Client #N"` where N is the sdk_client_id
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Route Structure
|
||||||
|
|
||||||
|
```
|
||||||
|
/dashboard
|
||||||
|
/evm ← existing (Wallets tab)
|
||||||
|
/clients ← existing (Clients tab)
|
||||||
|
/grants ← NEW (Grants tab)
|
||||||
|
/about ← existing
|
||||||
|
|
||||||
|
/evm-grants/create ← existing push route (unchanged)
|
||||||
|
```
|
||||||
|
|
||||||
|
### Changes to `router.dart`
|
||||||
|
|
||||||
|
Add inside dashboard children:
|
||||||
|
```dart
|
||||||
|
AutoRoute(page: EvmGrantsRoute.page, path: 'grants'),
|
||||||
|
```
|
||||||
|
|
||||||
|
### Changes to `dashboard.dart`
|
||||||
|
|
||||||
|
Add to `routes` list:
|
||||||
|
```dart
|
||||||
|
const EvmGrantsRoute()
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `NavigationDestination`:
|
||||||
|
```dart
|
||||||
|
NavigationDestination(
|
||||||
|
icon: Icon(Icons.policy_outlined),
|
||||||
|
selectedIcon: Icon(Icons.policy),
|
||||||
|
label: 'Grants',
|
||||||
|
),
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Screen: `EvmGrantsScreen`
|
||||||
|
|
||||||
|
**File:** `operator/lib/screens/dashboard/evm/grants/grants.dart`
|
||||||
|
|
||||||
|
```
|
||||||
|
Scaffold
|
||||||
|
└─ SafeArea
|
||||||
|
└─ RefreshIndicator.adaptive (refreshes evmGrantsProvider + walletAccessListProvider)
|
||||||
|
└─ ListView (BouncingScrollPhysics + AlwaysScrollableScrollPhysics)
|
||||||
|
├─ PageHeader
|
||||||
|
│ title: 'EVM Grants'
|
||||||
|
│ isBusy: evmGrantsProvider.isLoading
|
||||||
|
│ actions: [CreateGrantButton, RefreshButton]
|
||||||
|
├─ SizedBox(height: 1.8.h)
|
||||||
|
└─ <content>
|
||||||
|
```
|
||||||
|
|
||||||
|
### State handling
|
||||||
|
|
||||||
|
Matches the pattern from `EvmScreen` and `ClientsScreen`:
|
||||||
|
|
||||||
|
| State | Display |
|
||||||
|
|---|---|
|
||||||
|
| Loading (no data yet) | `_StatePanel` with spinner, "Loading grants" |
|
||||||
|
| Error | `_StatePanel` with coral icon, error message, Retry button |
|
||||||
|
| No connection | `_StatePanel`, "No active server connection" |
|
||||||
|
| Empty list | `_StatePanel`, "No grants yet", with Create Grant shortcut |
|
||||||
|
| Data | Column of `_GrantCard` widgets |
|
||||||
|
|
||||||
|
### Header actions
|
||||||
|
|
||||||
|
**CreateGrantButton:** `FilledButton.icon` with `Icons.add_rounded`, pushes `CreateEvmGrantRoute()` via `context.router.push(...)`.
|
||||||
|
|
||||||
|
**RefreshButton:** `OutlinedButton.icon` with `Icons.refresh`, calls `ref.read(evmGrantsProvider.notifier).refresh()`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Grant Card: `_GrantCard`
|
||||||
|
|
||||||
|
**Layout:**
|
||||||
|
|
||||||
|
```
|
||||||
|
Container (rounded 24, Palette.cream bg, Palette.line border)
|
||||||
|
└─ IntrinsicHeight > Row
|
||||||
|
├─ Accent strip (0.8.w wide, full height, rounded left)
|
||||||
|
└─ Padding > Column
|
||||||
|
├─ Row 1: TypeBadge + ChainChip + Spacer + RevokeButton
|
||||||
|
└─ Row 2: WalletText + "·" + ClientText
|
||||||
|
```
|
||||||
|
|
||||||
|
**Accent color by grant type:**
|
||||||
|
- Ether transfer → `Palette.coral`
|
||||||
|
- Token transfer → `Palette.token` (new entry in `Palette` — indigo, e.g. `Color(0xFF5C6BC0)`)
|
||||||
|
|
||||||
|
**TypeBadge:** Small pill container with accent color background at 15% opacity, accent-colored text. Label: `'Ether'` or `'Token'`.
|
||||||
|
|
||||||
|
**ChainChip:** Small container: `'Chain ${grant.shared.chainId}'`, muted ink color.
|
||||||
|
|
||||||
|
**WalletText:** Short hex address (`0xabc...def`) from wallet lookup, `bodySmall`, monospace font family.
|
||||||
|
|
||||||
|
**ClientText:** Client name from `sdkClientsProvider` lookup, or fallback string. `bodySmall`, muted ink.
|
||||||
|
|
||||||
|
**RevokeButton:**
|
||||||
|
- `OutlinedButton` with `Icons.block_rounded` icon, label `'Revoke'`
|
||||||
|
- `foregroundColor: Palette.coral`, `side: BorderSide(color: Palette.coral.withValues(alpha: 0.4))`
|
||||||
|
- Disabled (replaced with `CircularProgressIndicator`) while `revokeEvmGrantMutation` is pending — note: this is a single global mutation, so all revoke buttons disable while any revoke is in flight
|
||||||
|
- On press: calls `executeRevokeEvmGrant(ref, grantId: grant.id)`; shows `SnackBar` on error
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Adaptive Sizing
|
||||||
|
|
||||||
|
All sizing uses `sizer` units (`1.h`, `1.w`, etc.). No hardcoded pixel values.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Files to Create / Modify
|
||||||
|
|
||||||
|
| File | Action |
|
||||||
|
|---|---|
|
||||||
|
| `lib/theme/palette.dart` | Modify — add `Palette.token` color |
|
||||||
|
| `lib/providers/sdk_clients/wallet_access_list.dart` | Create |
|
||||||
|
| `lib/screens/dashboard/evm/grants/grants.dart` | Create |
|
||||||
|
| `lib/router.dart` | Modify — add grants route to dashboard children |
|
||||||
|
| `lib/screens/dashboard.dart` | Modify — add tab to routes list and NavigationDestinations |
|
||||||
9
server/Cargo.lock
generated
9
server/Cargo.lock
generated
@@ -771,7 +771,6 @@ dependencies = [
|
|||||||
"proptest",
|
"proptest",
|
||||||
"prost-types",
|
"prost-types",
|
||||||
"rand 0.10.1",
|
"rand 0.10.1",
|
||||||
"rand_core 0.10.1",
|
|
||||||
"rcgen",
|
"rcgen",
|
||||||
"restructed",
|
"restructed",
|
||||||
"rstest",
|
"rstest",
|
||||||
@@ -6262,18 +6261,18 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zeroize"
|
name = "zeroize"
|
||||||
version = "1.9.0"
|
version = "1.8.2"
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "e13c156562582aa81c60cb29407084cdb54c4164760106ab78e6c5b0858cf64e"
|
checksum = "b97154e67e32c85465826e8bcc1c59429aaaf107c1e4a9e53c8d8ccd5eff88d0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"zeroize_derive",
|
"zeroize_derive",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "zeroize_derive"
|
name = "zeroize_derive"
|
||||||
version = "1.5.0"
|
version = "1.4.3"
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "3c50655cbb0fe3fc43170059e702f1ce5e19b84cec58dc87b037a09935c2f328"
|
checksum = "85a5b4158499876c763cb03bc4e49185d3cccbabb15b33c627f7884f43db852e"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"proc-macro2",
|
"proc-macro2",
|
||||||
"quote",
|
"quote",
|
||||||
|
|||||||
@@ -21,7 +21,6 @@ mutants = "0.0.4"
|
|||||||
prost = "0.14.3"
|
prost = "0.14.3"
|
||||||
prost-types = { version = "0.14.3", features = ["chrono"] }
|
prost-types = { version = "0.14.3", features = ["chrono"] }
|
||||||
rand = "0.10.1"
|
rand = "0.10.1"
|
||||||
rand_core = "0.10.1"
|
|
||||||
rcgen = { version = "0.14.7", features = [ "aws_lc_rs", "pem", "x509-parser", "zeroize" ], default-features = false }
|
rcgen = { version = "0.14.7", features = [ "aws_lc_rs", "pem", "x509-parser", "zeroize" ], default-features = false }
|
||||||
rstest = "0.26.1"
|
rstest = "0.26.1"
|
||||||
rustls = { version = "0.23.40", features = ["aws-lc-rs", "logging", "prefer-post-quantum", "std"], default-features = false }
|
rustls = { version = "0.23.40", features = ["aws-lc-rs", "logging", "prefer-post-quantum", "std"], default-features = false }
|
||||||
@@ -77,7 +76,6 @@ needless_pass_by_ref_mut = "allow"
|
|||||||
pub_underscore_fields = "allow"
|
pub_underscore_fields = "allow"
|
||||||
redundant_pub_crate = "allow"
|
redundant_pub_crate = "allow"
|
||||||
uninhabited_references = "allow" # safe with unsafe_code = "forbid" and standard uninhabited pattern (match *self {})
|
uninhabited_references = "allow" # safe with unsafe_code = "forbid" and standard uninhabited pattern (match *self {})
|
||||||
too-many-lines = "allow" # this is a very common pattern in server code, and it's not always possible to break it down into smaller modules without hurting readability
|
|
||||||
|
|
||||||
# restriction lints
|
# restriction lints
|
||||||
alloc_instead_of_core = "warn"
|
alloc_instead_of_core = "warn"
|
||||||
|
|||||||
@@ -100,7 +100,7 @@ async fn send_auth_challenge_solution(
|
|||||||
key: &SigningKey,
|
key: &SigningKey,
|
||||||
challenge: AuthChallenge,
|
challenge: AuthChallenge,
|
||||||
) -> Result<(), AuthError> {
|
) -> Result<(), AuthError> {
|
||||||
let timestamp = DateTime::from_timestamp_nanos(challenge.timestamp_nanos.cast_signed());
|
let timestamp = DateTime::from_timestamp_nanos(challenge.timestamp_nanos as i64);
|
||||||
let challenge = authn::AuthChallenge {
|
let challenge = authn::AuthChallenge {
|
||||||
nonce: *challenge
|
nonce: *challenge
|
||||||
.random
|
.random
|
||||||
|
|||||||
@@ -31,7 +31,6 @@ diesel_migrations = { version = "2.3.2", features = ["sqlite"] }
|
|||||||
async-trait.workspace = true
|
async-trait.workspace = true
|
||||||
tokio-stream.workspace = true
|
tokio-stream.workspace = true
|
||||||
rand.workspace = true
|
rand.workspace = true
|
||||||
rand_core.workspace = true
|
|
||||||
rcgen.workspace = true
|
rcgen.workspace = true
|
||||||
chrono.workspace = true
|
chrono.workspace = true
|
||||||
kameo.workspace = true
|
kameo.workspace = true
|
||||||
|
|||||||
@@ -1,48 +1,29 @@
|
|||||||
use crate::db::{self, DatabasePool, schema};
|
use crate::db::{self, DatabasePool, schema};
|
||||||
use arbiter_crypto::safecell::{SafeCell, SafeCellHandle as _};
|
|
||||||
use arbiter_proto::{BOOTSTRAP_PATH, home_path};
|
use arbiter_proto::{BOOTSTRAP_PATH, home_path};
|
||||||
|
|
||||||
use diesel::QueryDsl;
|
use diesel::QueryDsl;
|
||||||
use diesel_async::RunQueryDsl;
|
use diesel_async::RunQueryDsl;
|
||||||
use kameo::{Actor, messages};
|
use kameo::{Actor, messages};
|
||||||
use rand::{RngExt, distr::Alphanumeric, rngs::SysRng};
|
use rand::{RngExt, distr::Alphanumeric, make_rng, rngs::StdRng};
|
||||||
use rand_core::UnwrapErr;
|
|
||||||
use std::path::{Path, PathBuf};
|
|
||||||
use subtle::ConstantTimeEq as _;
|
use subtle::ConstantTimeEq as _;
|
||||||
use thiserror::Error;
|
use thiserror::Error;
|
||||||
use tracing::warn;
|
|
||||||
|
|
||||||
const TOKEN_LENGTH: usize = 64;
|
const TOKEN_LENGTH: usize = 64;
|
||||||
|
|
||||||
async fn write_token_file(path: &Path, content: &str) -> Result<(), std::io::Error> {
|
pub async fn generate_token() -> Result<String, std::io::Error> {
|
||||||
tokio::fs::write(path, content.as_bytes()).await?;
|
let rng: StdRng = make_rng();
|
||||||
|
|
||||||
#[cfg(unix)]
|
let token = rng.sample_iter(Alphanumeric).take(TOKEN_LENGTH).fold(
|
||||||
{
|
String::default(),
|
||||||
use std::os::unix::fs::PermissionsExt as _;
|
|mut accum, char| {
|
||||||
tokio::fs::set_permissions(path, std::fs::Permissions::from_mode(0o600)).await?;
|
accum += char.to_string().as_str();
|
||||||
}
|
accum
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
Ok(())
|
tokio::fs::write(home_path()?.join(BOOTSTRAP_PATH), token.as_str()).await?;
|
||||||
}
|
|
||||||
|
|
||||||
async fn generate_token(path: &Path) -> Result<SafeCell<[u8; TOKEN_LENGTH]>, std::io::Error> {
|
Ok(token)
|
||||||
let mut cell = SafeCell::new([0u8; TOKEN_LENGTH]);
|
|
||||||
{
|
|
||||||
let mut buf = cell.write();
|
|
||||||
for (slot, b) in buf
|
|
||||||
.iter_mut()
|
|
||||||
.zip(UnwrapErr(SysRng).sample_iter(Alphanumeric))
|
|
||||||
{
|
|
||||||
*slot = b;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let token_str = cell.read_inline(|buf| String::from_utf8_lossy(buf.as_ref()).into_owned());
|
|
||||||
|
|
||||||
write_token_file(path, &token_str).await?;
|
|
||||||
|
|
||||||
Ok(cell)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Error, Debug)]
|
#[derive(Error, Debug)]
|
||||||
@@ -59,8 +40,7 @@ pub enum Error {
|
|||||||
|
|
||||||
#[derive(Actor)]
|
#[derive(Actor)]
|
||||||
pub struct Bootstrapper {
|
pub struct Bootstrapper {
|
||||||
token: Option<SafeCell<[u8; TOKEN_LENGTH]>>,
|
token: Option<String>,
|
||||||
token_path: Option<PathBuf>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Bootstrapper {
|
impl Bootstrapper {
|
||||||
@@ -74,37 +54,34 @@ impl Bootstrapper {
|
|||||||
.await?
|
.await?
|
||||||
};
|
};
|
||||||
|
|
||||||
let (token, token_path) = if row_count == 0 {
|
let token = if row_count == 0 {
|
||||||
let path = home_path()?.join(BOOTSTRAP_PATH);
|
let token = generate_token().await?;
|
||||||
let token = generate_token(&path).await?;
|
Some(token)
|
||||||
(Some(token), Some(path))
|
|
||||||
} else {
|
} else {
|
||||||
(None, None)
|
None
|
||||||
};
|
};
|
||||||
|
|
||||||
Ok(Self { token, token_path })
|
Ok(Self { token })
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
impl Bootstrapper {
|
|
||||||
fn is_correct_token(&mut self, token: &[u8]) -> bool {
|
|
||||||
self.token.as_mut().is_some_and(|expected| {
|
|
||||||
expected.read_inline(|exp| bool::from(exp.as_ref().ct_eq(token)))
|
|
||||||
})
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[messages]
|
#[messages]
|
||||||
impl Bootstrapper {
|
impl Bootstrapper {
|
||||||
#[message]
|
#[message]
|
||||||
pub async fn consume_token(&mut self, token: Vec<u8>) -> bool {
|
pub fn is_correct_token(&self, token: String) -> bool {
|
||||||
if self.is_correct_token(&token) {
|
self.token.as_ref().is_some_and(|expected| {
|
||||||
|
let expected_bytes = expected.as_bytes();
|
||||||
|
let token_bytes = token.as_bytes();
|
||||||
|
|
||||||
|
let choice = expected_bytes.ct_eq(token_bytes);
|
||||||
|
bool::from(choice)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
#[message]
|
||||||
|
pub fn consume_token(&mut self, token: String) -> bool {
|
||||||
|
if self.is_correct_token(token) {
|
||||||
self.token = None;
|
self.token = None;
|
||||||
if let Some(path) = self.token_path.take()
|
|
||||||
&& let Err(e) = tokio::fs::remove_file(&path).await
|
|
||||||
{
|
|
||||||
warn!(error = ?e, path = ?path, "Failed to delete bootstrap token file after consumption");
|
|
||||||
}
|
|
||||||
true
|
true
|
||||||
} else {
|
} else {
|
||||||
false
|
false
|
||||||
@@ -115,9 +92,7 @@ impl Bootstrapper {
|
|||||||
#[messages]
|
#[messages]
|
||||||
impl Bootstrapper {
|
impl Bootstrapper {
|
||||||
#[message]
|
#[message]
|
||||||
pub fn get_token(&mut self) -> Option<String> {
|
pub fn get_token(&self) -> Option<String> {
|
||||||
self.token
|
self.token.clone()
|
||||||
.as_mut()
|
|
||||||
.map(|cell| cell.read_inline(|buf| String::from_utf8_lossy(buf.as_ref()).into_owned()))
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
use crate::{
|
use crate::{
|
||||||
actors::vault::{CreateNew, Decrypt, Vault},
|
actors::vault::{CreateNew, Decrypt, Vault},
|
||||||
crypto::integrity::{self, Integrable},
|
crypto::integrity,
|
||||||
db::{
|
db::{
|
||||||
DatabaseError, DatabasePool,
|
DatabaseError, DatabasePool,
|
||||||
models::{self, EvmWalletId},
|
models::{self, EvmWalletId},
|
||||||
@@ -25,35 +25,14 @@ use diesel::{
|
|||||||
use diesel_async::RunQueryDsl;
|
use diesel_async::RunQueryDsl;
|
||||||
use kameo::{Actor, actor::ActorRef, messages};
|
use kameo::{Actor, actor::ActorRef, messages};
|
||||||
use rand::{SeedableRng, rng, rngs::StdRng};
|
use rand::{SeedableRng, rng, rngs::StdRng};
|
||||||
use tracing::error;
|
|
||||||
|
|
||||||
pub use crate::evm::safe_signer;
|
pub use crate::evm::safe_signer;
|
||||||
|
|
||||||
/// Integrity guard that binds a wallet's encrypted key ID to its Ethereum address.
|
|
||||||
/// Both fields are included in the HMAC — swapping `aead_encrypted_id` in the DB
|
|
||||||
/// invalidates the envelope MAC, and the AEAD ciphertext is also bound to `address`
|
|
||||||
/// as AAD, so decryption fails too.
|
|
||||||
#[derive(arbiter_macros::Hashable)]
|
|
||||||
struct EvmWalletIntegrity {
|
|
||||||
aead_encrypted_id: i32,
|
|
||||||
address: Address,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl Integrable for EvmWalletIntegrity {
|
|
||||||
const KIND: &'static str = "evm_wallet";
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, thiserror::Error)]
|
#[derive(Debug, thiserror::Error)]
|
||||||
pub enum SignTransactionError {
|
pub enum SignTransactionError {
|
||||||
#[error("Wallet not found")]
|
#[error("Wallet not found")]
|
||||||
WalletNotFound,
|
WalletNotFound,
|
||||||
|
|
||||||
#[error("Decrypted key does not match requested wallet address")]
|
|
||||||
KeyAddressMismatch,
|
|
||||||
|
|
||||||
#[error("Internal signing error")]
|
|
||||||
Internal,
|
|
||||||
|
|
||||||
#[error("Database error: {0}")]
|
#[error("Database error: {0}")]
|
||||||
Database(#[from] DatabaseError),
|
Database(#[from] DatabaseError),
|
||||||
|
|
||||||
@@ -85,12 +64,6 @@ pub enum Error {
|
|||||||
Integrity(#[from] integrity::Error),
|
Integrity(#[from] integrity::Error),
|
||||||
}
|
}
|
||||||
|
|
||||||
impl From<diesel::result::Error> for Error {
|
|
||||||
fn from(e: diesel::result::Error) -> Self {
|
|
||||||
Self::Database(DatabaseError::from(e))
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Actor)]
|
#[derive(Actor)]
|
||||||
pub struct EvmActor {
|
pub struct EvmActor {
|
||||||
pub vault: ActorRef<Vault>,
|
pub vault: ActorRef<Vault>,
|
||||||
@@ -124,39 +97,20 @@ impl EvmActor {
|
|||||||
|
|
||||||
let aead_id: i32 = self
|
let aead_id: i32 = self
|
||||||
.vault
|
.vault
|
||||||
.ask(CreateNew {
|
.ask(CreateNew { plaintext })
|
||||||
plaintext,
|
|
||||||
aad: address.as_slice().to_vec(),
|
|
||||||
})
|
|
||||||
.await
|
.await
|
||||||
.map_err(|_| Error::VaultSend)?;
|
.map_err(|_| Error::VaultSend)?;
|
||||||
|
|
||||||
let mut conn = self.db.get().await.map_err(DatabaseError::from)?;
|
let mut conn = self.db.get().await.map_err(DatabaseError::from)?;
|
||||||
let wallet_id = conn
|
let wallet_id = insert_into(schema::evm_wallet::table)
|
||||||
.exclusive_transaction(async |conn| {
|
.values(&models::NewEvmWallet {
|
||||||
let wallet_id: i32 = insert_into(schema::evm_wallet::table)
|
address: address.as_slice().to_vec(),
|
||||||
.values(&models::NewEvmWallet {
|
aead_encrypted_id: aead_id,
|
||||||
address: address.as_slice().to_vec(),
|
|
||||||
aead_encrypted_id: aead_id,
|
|
||||||
})
|
|
||||||
.returning(schema::evm_wallet::id)
|
|
||||||
.get_result(conn)
|
|
||||||
.await
|
|
||||||
.map_err(DatabaseError::from)
|
|
||||||
.map_err(Error::Database)?;
|
|
||||||
|
|
||||||
integrity::sign_entity(
|
|
||||||
conn,
|
|
||||||
&self.vault,
|
|
||||||
&EvmWalletIntegrity { address, aead_encrypted_id: aead_id },
|
|
||||||
wallet_id,
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
.map_err(Error::Integrity)?;
|
|
||||||
|
|
||||||
Ok::<i32, Error>(wallet_id)
|
|
||||||
})
|
})
|
||||||
.await?;
|
.returning(schema::evm_wallet::id)
|
||||||
|
.get_result(&mut conn)
|
||||||
|
.await
|
||||||
|
.map_err(DatabaseError::from)?;
|
||||||
|
|
||||||
Ok((wallet_id, address))
|
Ok((wallet_id, address))
|
||||||
}
|
}
|
||||||
@@ -206,14 +160,29 @@ impl EvmActor {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[message]
|
#[message]
|
||||||
pub async fn useragent_delete_grant(
|
#[expect(clippy::unused_async, reason = "reserved for impl")]
|
||||||
&mut self,
|
pub async fn operator_delete_grant(&mut self, _grant_id: i32) -> Result<(), Error> {
|
||||||
grant_id: i32,
|
// let mut conn = self.db.get().await.map_err(DatabaseError::from)?;
|
||||||
) -> Result<(), Error> {
|
// let vault = self.vault.clone();
|
||||||
self.engine
|
|
||||||
.revoke_grant(grant_id)
|
// diesel_async::AsyncConnection::transaction(&mut conn, |conn| {
|
||||||
.await
|
// Box::pin(async move {
|
||||||
.map_err(Error::from)
|
// diesel::update(schema::evm_basic_grant::table)
|
||||||
|
// .filter(schema::evm_basic_grant::id.eq(grant_id))
|
||||||
|
// .set(schema::evm_basic_grant::revoked_at.eq(SqliteTimestamp::now()))
|
||||||
|
// .execute(conn)
|
||||||
|
// .await?;
|
||||||
|
|
||||||
|
// let signed = integrity::evm::load_signed_grant_by_basic_id(conn, grant_id).await?;
|
||||||
|
|
||||||
|
// diesel::result::QueryResult::Ok(())
|
||||||
|
// })
|
||||||
|
// })
|
||||||
|
// .await
|
||||||
|
// .map_err(DatabaseError::from)?;
|
||||||
|
|
||||||
|
// Ok(())
|
||||||
|
todo!()
|
||||||
}
|
}
|
||||||
|
|
||||||
#[message]
|
#[message]
|
||||||
@@ -287,51 +256,16 @@ impl EvmActor {
|
|||||||
.ok_or(SignTransactionError::WalletNotFound)?;
|
.ok_or(SignTransactionError::WalletNotFound)?;
|
||||||
drop(conn);
|
drop(conn);
|
||||||
|
|
||||||
let mut conn = self.db.get().await.map_err(DatabaseError::from)?;
|
|
||||||
let attestation = integrity::verify_entity(
|
|
||||||
&mut conn,
|
|
||||||
&self.vault,
|
|
||||||
&EvmWalletIntegrity {
|
|
||||||
address: wallet_address,
|
|
||||||
aead_encrypted_id: wallet.aead_encrypted_id,
|
|
||||||
},
|
|
||||||
wallet.id.to_raw(),
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
.map_err(|e| {
|
|
||||||
error!(?e, ?wallet.id, "EVM wallet integrity check failed");
|
|
||||||
SignTransactionError::Internal
|
|
||||||
})?;
|
|
||||||
drop(conn);
|
|
||||||
|
|
||||||
if attestation != integrity::AttestationStatus::Attested {
|
|
||||||
error!(
|
|
||||||
?wallet.id,
|
|
||||||
"EVM wallet integrity unavailable; refusing to sign"
|
|
||||||
);
|
|
||||||
return Err(SignTransactionError::Internal);
|
|
||||||
}
|
|
||||||
|
|
||||||
let raw_key: SafeCell<Vec<u8>> = self
|
let raw_key: SafeCell<Vec<u8>> = self
|
||||||
.vault
|
.vault
|
||||||
.ask(Decrypt {
|
.ask(Decrypt {
|
||||||
aead_id: wallet.aead_encrypted_id,
|
aead_id: wallet.aead_encrypted_id,
|
||||||
aad: wallet.address.clone(),
|
|
||||||
})
|
})
|
||||||
.await
|
.await
|
||||||
.map_err(|_| SignTransactionError::VaultSend)?;
|
.map_err(|_| SignTransactionError::VaultSend)?;
|
||||||
|
|
||||||
let signer = safe_signer::SafeSigner::from_cell(raw_key)?;
|
let signer = safe_signer::SafeSigner::from_cell(raw_key)?;
|
||||||
|
|
||||||
if signer.address() != wallet_address {
|
|
||||||
error!(
|
|
||||||
expected = %wallet_address,
|
|
||||||
actual = %signer.address(),
|
|
||||||
"Decrypted private key address does not match requested wallet"
|
|
||||||
);
|
|
||||||
return Err(SignTransactionError::KeyAddressMismatch);
|
|
||||||
}
|
|
||||||
|
|
||||||
self.engine
|
self.engine
|
||||||
.evaluate_transaction(wallet_access, transaction.clone(), RunKind::Execution)
|
.evaluate_transaction(wallet_access, transaction.clone(), RunKind::Execution)
|
||||||
.await?;
|
.await?;
|
||||||
|
|||||||
@@ -11,9 +11,7 @@ use kameo::{
|
|||||||
prelude::{ActorId, ActorRef, ActorStopReason, Context, WeakActorRef},
|
prelude::{ActorId, ActorRef, ActorStopReason, Context, WeakActorRef},
|
||||||
reply::ReplySender,
|
reply::ReplySender,
|
||||||
};
|
};
|
||||||
use std::{ops::ControlFlow, time::Duration};
|
use std::ops::ControlFlow;
|
||||||
|
|
||||||
const APPROVAL_TIMEOUT: Duration = Duration::from_secs(30);
|
|
||||||
|
|
||||||
pub struct Args {
|
pub struct Args {
|
||||||
pub client: ClientProfile,
|
pub client: ClientProfile,
|
||||||
@@ -66,14 +64,6 @@ impl Actor for ClientApprovalController {
|
|||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
|
|
||||||
let weak = actor_ref.downgrade();
|
|
||||||
tokio::spawn(async move {
|
|
||||||
tokio::time::sleep(APPROVAL_TIMEOUT).await;
|
|
||||||
if let Some(r) = weak.upgrade() {
|
|
||||||
let _ = r.tell(OnApprovalTimeout {}).await;
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
Ok(this)
|
Ok(this)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -114,14 +104,4 @@ impl ClientApprovalController {
|
|||||||
ctx.stop();
|
ctx.stop();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Fired after `APPROVAL_TIMEOUT` elapses. Any operator that hasn't responded
|
|
||||||
/// by then is treated as a denial to prevent zombie sessions from blocking the flow.
|
|
||||||
#[message(ctx)]
|
|
||||||
pub fn on_approval_timeout(&mut self, ctx: &mut Context<Self, ()>) {
|
|
||||||
if self.pending > 0 {
|
|
||||||
self.send_reply(Ok(false));
|
|
||||||
ctx.stop();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -20,8 +20,6 @@ pub mod client_connect_approval;
|
|||||||
|
|
||||||
pub struct FlowCoordinator {
|
pub struct FlowCoordinator {
|
||||||
pub clients: HashMap<ActorId, ActorRef<ClientSession>>,
|
pub clients: HashMap<ActorId, ActorRef<ClientSession>>,
|
||||||
/// Maps DB `client_id` → `ActorId` for fast connected-client lookup.
|
|
||||||
client_ids: HashMap<i32, ActorId>,
|
|
||||||
operator_registry: ActorRef<OperatorRegistry>,
|
operator_registry: ActorRef<OperatorRegistry>,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -29,7 +27,6 @@ impl FlowCoordinator {
|
|||||||
pub fn new(operator_registry: ActorRef<OperatorRegistry>) -> Self {
|
pub fn new(operator_registry: ActorRef<OperatorRegistry>) -> Self {
|
||||||
Self {
|
Self {
|
||||||
clients: HashMap::default(),
|
clients: HashMap::default(),
|
||||||
client_ids: HashMap::default(),
|
|
||||||
operator_registry,
|
operator_registry,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -51,7 +48,6 @@ impl Actor for FlowCoordinator {
|
|||||||
_: ActorStopReason,
|
_: ActorStopReason,
|
||||||
) -> Result<ControlFlow<ActorStopReason>, Self::Error> {
|
) -> Result<ControlFlow<ActorStopReason>, Self::Error> {
|
||||||
if self.clients.remove(&id).is_some() {
|
if self.clients.remove(&id).is_some() {
|
||||||
self.client_ids.retain(|_, actor_id| *actor_id != id);
|
|
||||||
info!(
|
info!(
|
||||||
?id,
|
?id,
|
||||||
actor = "FlowCoordinator",
|
actor = "FlowCoordinator",
|
||||||
@@ -79,28 +75,14 @@ impl FlowCoordinator {
|
|||||||
#[message(ctx)]
|
#[message(ctx)]
|
||||||
pub async fn register_client(
|
pub async fn register_client(
|
||||||
&mut self,
|
&mut self,
|
||||||
client_id: i32,
|
|
||||||
actor: ActorRef<ClientSession>,
|
actor: ActorRef<ClientSession>,
|
||||||
ctx: &mut Context<Self, ()>,
|
ctx: &mut Context<Self, ()>,
|
||||||
) {
|
) {
|
||||||
info!(id = %actor.id(), client_id, actor = "FlowCoordinator", event = "client.connected");
|
info!(id = %actor.id(), actor = "FlowCoordinator", event = "client.connected");
|
||||||
ctx.actor_ref().link(&actor).await;
|
ctx.actor_ref().link(&actor).await;
|
||||||
self.client_ids.insert(client_id, actor.id());
|
|
||||||
self.clients.insert(actor.id(), actor);
|
self.clients.insert(actor.id(), actor);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[message]
|
|
||||||
pub fn is_client_connected(&self, client_id: i32) -> bool {
|
|
||||||
self.client_ids.contains_key(&client_id)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Returns the DB `client_ids` of all currently connected SDK clients.
|
|
||||||
/// Used by operator sessions on startup to seed their approved-client set.
|
|
||||||
#[message]
|
|
||||||
pub fn get_connected_client_ids(&self) -> Vec<i32> {
|
|
||||||
self.client_ids.keys().copied().collect()
|
|
||||||
}
|
|
||||||
|
|
||||||
#[message(ctx)]
|
#[message(ctx)]
|
||||||
pub async fn request_client_approval(
|
pub async fn request_client_approval(
|
||||||
&mut self,
|
&mut self,
|
||||||
|
|||||||
@@ -22,7 +22,7 @@ use hmac::{KeyInit as _, Mac as _};
|
|||||||
use kameo::{Actor, Reply, actor::ActorRef, messages};
|
use kameo::{Actor, Reply, actor::ActorRef, messages};
|
||||||
use kameo_actors::message_bus::{MessageBus, Publish};
|
use kameo_actors::message_bus::{MessageBus, Publish};
|
||||||
use strum::{EnumDiscriminants, IntoDiscriminant};
|
use strum::{EnumDiscriminants, IntoDiscriminant};
|
||||||
use tracing::{error, info, warn};
|
use tracing::{error, info};
|
||||||
|
|
||||||
pub mod events {
|
pub mod events {
|
||||||
#[derive(Clone, Copy)]
|
#[derive(Clone, Copy)]
|
||||||
@@ -45,8 +45,6 @@ pub enum Error {
|
|||||||
Sealed,
|
Sealed,
|
||||||
#[error("Invalid key provided")]
|
#[error("Invalid key provided")]
|
||||||
InvalidKey,
|
InvalidKey,
|
||||||
#[error("Vault locked: too many failed unseal attempts")]
|
|
||||||
LockedOut,
|
|
||||||
|
|
||||||
#[error("Requested aead entry not found")]
|
#[error("Requested aead entry not found")]
|
||||||
NotFound,
|
NotFound,
|
||||||
@@ -62,9 +60,6 @@ pub enum Error {
|
|||||||
|
|
||||||
#[error("Broken database")]
|
#[error("Broken database")]
|
||||||
BrokenDatabase,
|
BrokenDatabase,
|
||||||
|
|
||||||
#[error("Integrity key version mismatch: envelope uses key {envelope:?}, current key is {current:?}")]
|
|
||||||
KeyVersionMismatch { envelope: RootKeyHistoryId, current: RootKeyHistoryId },
|
|
||||||
}
|
}
|
||||||
|
|
||||||
struct Unsealed {
|
struct Unsealed {
|
||||||
@@ -84,8 +79,6 @@ enum State {
|
|||||||
Unsealed(Unsealed),
|
Unsealed(Unsealed),
|
||||||
}
|
}
|
||||||
|
|
||||||
const MAX_UNSEAL_ATTEMPTS: u32 = 5;
|
|
||||||
|
|
||||||
/// Manages vault root key and tracks current state of the vault (bootstrapped/unbootstrapped, sealed/unsealed).
|
/// Manages vault root key and tracks current state of the vault (bootstrapped/unbootstrapped, sealed/unsealed).
|
||||||
///
|
///
|
||||||
/// Provides API for encrypting and decrypting data using the vault root key.
|
/// Provides API for encrypting and decrypting data using the vault root key.
|
||||||
@@ -95,7 +88,6 @@ pub struct Vault {
|
|||||||
db: db::DatabasePool,
|
db: db::DatabasePool,
|
||||||
state: State,
|
state: State,
|
||||||
events: ActorRef<MessageBus>,
|
events: ActorRef<MessageBus>,
|
||||||
unseal_failures: u32,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[messages]
|
#[messages]
|
||||||
@@ -118,7 +110,7 @@ impl Vault {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
Ok(Self { db, state, events, unseal_failures: 0 })
|
Ok(Self { db, state, events })
|
||||||
}
|
}
|
||||||
|
|
||||||
// Exclusive transaction to avoid race condtions if multiple vaults write
|
// Exclusive transaction to avoid race condtions if multiple vaults write
|
||||||
@@ -232,10 +224,6 @@ impl Vault {
|
|||||||
|
|
||||||
#[message]
|
#[message]
|
||||||
pub async fn try_unseal(&mut self, seal_key_raw: SafeCell<Vec<u8>>) -> Result<(), Error> {
|
pub async fn try_unseal(&mut self, seal_key_raw: SafeCell<Vec<u8>>) -> Result<(), Error> {
|
||||||
if self.unseal_failures >= MAX_UNSEAL_ATTEMPTS {
|
|
||||||
return Err(Error::LockedOut);
|
|
||||||
}
|
|
||||||
|
|
||||||
let State::Sealed {
|
let State::Sealed {
|
||||||
root_key_history_id,
|
root_key_history_id,
|
||||||
} = &self.state
|
} = &self.state
|
||||||
@@ -268,27 +256,13 @@ impl Vault {
|
|||||||
Error::BrokenDatabase
|
Error::BrokenDatabase
|
||||||
})?;
|
})?;
|
||||||
|
|
||||||
if seal_key
|
seal_key
|
||||||
.decrypt_in_place(&nonce, v1::ROOT_KEY_TAG, &mut root_key)
|
.decrypt_in_place(&nonce, v1::ROOT_KEY_TAG, &mut root_key)
|
||||||
.is_err()
|
.map_err(|err| {
|
||||||
{
|
error!(?err, "Failed to unseal root key: invalid seal key");
|
||||||
self.unseal_failures += 1;
|
Error::InvalidKey
|
||||||
if self.unseal_failures >= MAX_UNSEAL_ATTEMPTS {
|
})?;
|
||||||
error!(
|
|
||||||
attempts = self.unseal_failures,
|
|
||||||
"Vault locked: maximum failed unseal attempts reached"
|
|
||||||
);
|
|
||||||
} else {
|
|
||||||
warn!(
|
|
||||||
attempts = self.unseal_failures,
|
|
||||||
remaining = MAX_UNSEAL_ATTEMPTS - self.unseal_failures,
|
|
||||||
"Failed unseal attempt"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
return Err(Error::InvalidKey);
|
|
||||||
}
|
|
||||||
|
|
||||||
self.unseal_failures = 0;
|
|
||||||
self.state = State::Unsealed(Unsealed {
|
self.state = State::Unsealed(Unsealed {
|
||||||
root_key_history_id: current_key.id,
|
root_key_history_id: current_key.id,
|
||||||
root_key: KeyCell::try_from(root_key).map_err(|err| {
|
root_key: KeyCell::try_from(root_key).map_err(|err| {
|
||||||
@@ -303,10 +277,8 @@ impl Vault {
|
|||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Decrypts an AEAD entry. The `aad` must match the value used at encryption time;
|
|
||||||
/// a mismatch causes authentication failure, preventing cross-wallet key swaps.
|
|
||||||
#[message]
|
#[message]
|
||||||
pub async fn decrypt(&mut self, aead_id: i32, aad: Vec<u8>) -> Result<SafeCell<Vec<u8>>, Error> {
|
pub async fn decrypt(&mut self, aead_id: i32) -> Result<SafeCell<Vec<u8>>, Error> {
|
||||||
let Unsealed { root_key, .. } = Self::expect_unsealed(&mut self.state)?;
|
let Unsealed { root_key, .. } = Self::expect_unsealed(&mut self.state)?;
|
||||||
|
|
||||||
let row: models::AeadEncrypted = {
|
let row: models::AeadEncrypted = {
|
||||||
@@ -328,15 +300,13 @@ impl Vault {
|
|||||||
Error::BrokenDatabase
|
Error::BrokenDatabase
|
||||||
})?;
|
})?;
|
||||||
let mut output = SafeCell::new(row.ciphertext);
|
let mut output = SafeCell::new(row.ciphertext);
|
||||||
root_key.decrypt_in_place(&nonce, &aad, &mut output)?;
|
root_key.decrypt_in_place(&nonce, v1::TAG, &mut output)?;
|
||||||
Ok(output)
|
Ok(output)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Creates a new `aead_encrypted` entry and returns its ID.
|
|
||||||
/// The `aad` is bound into the ciphertext and must be reproduced exactly at decryption time.
|
|
||||||
// Creates new `aead_encrypted` entry in the database and returns it's ID
|
// Creates new `aead_encrypted` entry in the database and returns it's ID
|
||||||
#[message]
|
#[message]
|
||||||
pub async fn create_new(&mut self, mut plaintext: SafeCell<Vec<u8>>, aad: Vec<u8>) -> Result<i32, Error> {
|
pub async fn create_new(&mut self, mut plaintext: SafeCell<Vec<u8>>) -> Result<i32, Error> {
|
||||||
let Unsealed {
|
let Unsealed {
|
||||||
root_key,
|
root_key,
|
||||||
root_key_history_id,
|
root_key_history_id,
|
||||||
@@ -348,7 +318,7 @@ impl Vault {
|
|||||||
|
|
||||||
let mut ciphertext_buffer = plaintext.write();
|
let mut ciphertext_buffer = plaintext.write();
|
||||||
let ciphertext_buffer: &mut Vec<u8> = ciphertext_buffer.as_mut();
|
let ciphertext_buffer: &mut Vec<u8> = ciphertext_buffer.as_mut();
|
||||||
root_key.encrypt_in_place(&nonce, &aad, &mut *ciphertext_buffer)?;
|
root_key.encrypt_in_place(&nonce, v1::TAG, &mut *ciphertext_buffer)?;
|
||||||
|
|
||||||
let ciphertext = std::mem::take(ciphertext_buffer);
|
let ciphertext = std::mem::take(ciphertext_buffer);
|
||||||
|
|
||||||
@@ -384,10 +354,12 @@ impl Vault {
|
|||||||
root_key_history_id,
|
root_key_history_id,
|
||||||
} = Self::expect_unsealed(&mut self.state)?;
|
} = Self::expect_unsealed(&mut self.state)?;
|
||||||
|
|
||||||
let mut hmac = root_key.0.read_inline(|k| {
|
let mut hmac = root_key
|
||||||
HmacSha256::new_from_slice(k)
|
.0
|
||||||
.unwrap_or_else(|_| unreachable!("HMAC accepts keys of any size"))
|
.read_inline(|k| match HmacSha256::new_from_slice(k) {
|
||||||
});
|
Ok(v) => v,
|
||||||
|
Err(_) => unreachable!("HMAC accepts keys of any size"),
|
||||||
|
});
|
||||||
hmac.update(&root_key_history_id.to_raw().to_be_bytes());
|
hmac.update(&root_key_history_id.to_raw().to_be_bytes());
|
||||||
hmac.update(&mac_input);
|
hmac.update(&mac_input);
|
||||||
|
|
||||||
@@ -408,16 +380,15 @@ impl Vault {
|
|||||||
} = Self::expect_unsealed(&mut self.state)?;
|
} = Self::expect_unsealed(&mut self.state)?;
|
||||||
|
|
||||||
if *root_key_history_id != key_version {
|
if *root_key_history_id != key_version {
|
||||||
return Err(Error::KeyVersionMismatch {
|
return Ok(false);
|
||||||
envelope: key_version,
|
|
||||||
current: *root_key_history_id,
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
let mut hmac = root_key.0.read_inline(|k| {
|
let mut hmac = root_key
|
||||||
HmacSha256::new_from_slice(k)
|
.0
|
||||||
.unwrap_or_else(|_| unreachable!("HMAC accepts keys of any size"))
|
.read_inline(|k| match HmacSha256::new_from_slice(k) {
|
||||||
});
|
Ok(v) => v,
|
||||||
|
Err(_) => unreachable!("HMAC accepts keys of any size"),
|
||||||
|
});
|
||||||
hmac.update(&key_version.to_raw().to_be_bytes());
|
hmac.update(&key_version.to_raw().to_be_bytes());
|
||||||
hmac.update(&mac_input);
|
hmac.update(&mac_input);
|
||||||
|
|
||||||
@@ -461,13 +432,12 @@ mod tests {
|
|||||||
async fn nonce_monotonic_even_when_nonce_allocation_interleaves() {
|
async fn nonce_monotonic_even_when_nonce_allocation_interleaves() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = bootstrapped_actor(&db).await;
|
let mut actor = bootstrapped_actor(&db).await;
|
||||||
|
let root_key_history_id = match actor.state {
|
||||||
let State::Unsealed(Unsealed {
|
State::Unsealed(Unsealed {
|
||||||
root_key_history_id,
|
root_key_history_id,
|
||||||
..
|
..
|
||||||
}) = actor.state
|
}) => root_key_history_id,
|
||||||
else {
|
_ => panic!("expected unsealed state"),
|
||||||
panic!("expected unsealed state")
|
|
||||||
};
|
};
|
||||||
|
|
||||||
let n1 = Vault::get_new_nonce(&db, root_key_history_id)
|
let n1 = Vault::get_new_nonce(&db, root_key_history_id)
|
||||||
@@ -487,7 +457,7 @@ mod tests {
|
|||||||
assert_eq!(root_row.data_encryption_nonce, n2.to_vec());
|
assert_eq!(root_row.data_encryption_nonce, n2.to_vec());
|
||||||
|
|
||||||
let id = actor
|
let id = actor
|
||||||
.create_new(SafeCell::new(b"post-interleave".to_vec()), b"test-aad".to_vec())
|
.create_new(SafeCell::new(b"post-interleave".to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
let row: models::AeadEncrypted = schema::aead_encrypted::table
|
let row: models::AeadEncrypted = schema::aead_encrypted::table
|
||||||
|
|||||||
@@ -192,9 +192,7 @@ pub async fn verify_entity<E: Integrable>(
|
|||||||
Ok(false) => Err(Error::MacMismatch {
|
Ok(false) => Err(Error::MacMismatch {
|
||||||
entity_kind: E::KIND,
|
entity_kind: E::KIND,
|
||||||
}),
|
}),
|
||||||
Err(SendError::HandlerError(
|
Err(SendError::HandlerError(vault::Error::Sealed)) => Ok(AttestationStatus::Unavailable),
|
||||||
vault::Error::Sealed | vault::Error::KeyVersionMismatch { .. },
|
|
||||||
)) => Ok(AttestationStatus::Unavailable),
|
|
||||||
Err(_) => Err(Error::VaultSend),
|
Err(_) => Err(Error::VaultSend),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -333,47 +331,4 @@ mod tests {
|
|||||||
.unwrap_err();
|
.unwrap_err();
|
||||||
assert!(matches!(err, Error::MacMismatch { .. }));
|
assert!(matches!(err, Error::MacMismatch { .. }));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn key_version_mismatch_returns_unavailable_not_mac_mismatch() {
|
|
||||||
use crate::db::schema::integrity_envelope;
|
|
||||||
use super::AttestationStatus;
|
|
||||||
|
|
||||||
const ENTITY_ID: &[u8] = b"entity-id-rotation-test";
|
|
||||||
|
|
||||||
let db = db::create_test_pool().await;
|
|
||||||
let vault = bootstrapped_vault(&db).await;
|
|
||||||
let mut conn = db.get().await.unwrap();
|
|
||||||
|
|
||||||
let entity = DummyEntity {
|
|
||||||
payload_version: 1,
|
|
||||||
payload: b"payload-v1".to_vec(),
|
|
||||||
};
|
|
||||||
|
|
||||||
sign_entity(&mut conn, &vault, &entity, ENTITY_ID)
|
|
||||||
.await
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
// Simulate key rotation: update the stored key_version to a stale value.
|
|
||||||
// After real rotation the vault's root_key_history_id would advance, but
|
|
||||||
// here we achieve the same mismatch by back-dating the envelope's key_version.
|
|
||||||
diesel::update(integrity_envelope::table)
|
|
||||||
.filter(integrity_envelope::entity_kind.eq("dummy_entity"))
|
|
||||||
.filter(integrity_envelope::entity_id.eq(ENTITY_ID))
|
|
||||||
.set(integrity_envelope::key_version.eq(0))
|
|
||||||
.execute(&mut conn)
|
|
||||||
.await
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
// Must NOT error — version mismatch is Unavailable, not tampered.
|
|
||||||
let status = verify_entity(&mut conn, &vault, &entity, ENTITY_ID)
|
|
||||||
.await
|
|
||||||
.expect("key version mismatch must not be treated as an error");
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
status,
|
|
||||||
AttestationStatus::Unavailable,
|
|
||||||
"stale key_version must yield Unavailable, not MacMismatch"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,34 +1,28 @@
|
|||||||
use diesel_async::{AsyncConnection, RunQueryDsl};
|
|
||||||
use kameo::actor::ActorRef;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
actors::vault::Vault,
|
actors::vault::Vault,
|
||||||
crypto::integrity,
|
crypto::integrity,
|
||||||
db::{
|
db::{
|
||||||
self, DatabaseError,
|
self, DatabaseError,
|
||||||
models::{
|
models::{
|
||||||
EvmBasicGrant, EvmEtherTransferGrant, EvmEtherTransferGrantTarget,
|
EvmBasicGrant, EvmWalletAccess, NewEvmBasicGrant, NewEvmTransactionLog, SqliteTimestamp,
|
||||||
EvmEtherTransferLimit, EvmTokenTransferGrant, EvmTokenTransferVolumeLimit,
|
|
||||||
EvmWalletAccess, NewEvmBasicGrant, NewEvmTransactionLog, SqliteTimestamp,
|
|
||||||
},
|
},
|
||||||
schema::{self, evm_transaction_log},
|
schema::{self, evm_transaction_log},
|
||||||
},
|
},
|
||||||
evm::policies::{
|
evm::policies::{
|
||||||
CombinedSettings, DatabaseID, EvalContext, EvalViolation, Grant, Policy,
|
CombinedSettings, DatabaseID, EvalContext, EvalViolation, Grant, Policy,
|
||||||
SharedGrantSettings, SpecificGrant, SpecificMeaning, VolumeRateLimit,
|
SharedGrantSettings, SpecificGrant, SpecificMeaning, ether_transfer::EtherTransfer,
|
||||||
ether_transfer::EtherTransfer, token_transfers::TokenTransfer,
|
token_transfers::TokenTransfer,
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
use alloy::{
|
use alloy::{
|
||||||
consensus::TxEip1559,
|
consensus::TxEip1559,
|
||||||
primitives::{Address, TxKind, U256},
|
primitives::{TxKind, U256},
|
||||||
};
|
};
|
||||||
use chrono::Utc;
|
use chrono::Utc;
|
||||||
use diesel::{
|
use diesel::{ExpressionMethods as _, QueryDsl as _, QueryResult, insert_into, sqlite::Sqlite};
|
||||||
ExpressionMethods as _, OptionalExtension, QueryDsl as _, QueryResult, SelectableHelper,
|
use diesel_async::{AsyncConnection, RunQueryDsl};
|
||||||
insert_into, sqlite::Sqlite, update,
|
use kameo::actor::ActorRef;
|
||||||
};
|
|
||||||
|
|
||||||
pub mod abi;
|
pub mod abi;
|
||||||
pub mod safe_signer;
|
pub mod safe_signer;
|
||||||
@@ -278,151 +272,6 @@ impl Engine {
|
|||||||
Ok(id)
|
Ok(id)
|
||||||
}
|
}
|
||||||
|
|
||||||
pub async fn revoke_grant(
|
|
||||||
&self,
|
|
||||||
basic_grant_id: i32,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
let mut conn = self.db.get().await.map_err(DatabaseError::from)?;
|
|
||||||
let vault = self.vault.clone();
|
|
||||||
|
|
||||||
conn.transaction(async move |conn| {
|
|
||||||
use crate::db::schema::{
|
|
||||||
evm_basic_grant, evm_ether_transfer_grant, evm_ether_transfer_grant_target,
|
|
||||||
evm_ether_transfer_limit, evm_token_transfer_grant,
|
|
||||||
evm_token_transfer_volume_limit,
|
|
||||||
};
|
|
||||||
|
|
||||||
update(evm_basic_grant::table)
|
|
||||||
.filter(evm_basic_grant::id.eq(basic_grant_id))
|
|
||||||
.set(evm_basic_grant::revoked_at.eq(SqliteTimestamp(Utc::now())))
|
|
||||||
.execute(&mut *conn)
|
|
||||||
.await?;
|
|
||||||
|
|
||||||
let basic_grant: EvmBasicGrant = evm_basic_grant::table
|
|
||||||
.filter(evm_basic_grant::id.eq(basic_grant_id))
|
|
||||||
.select(EvmBasicGrant::as_select())
|
|
||||||
.first(&mut *conn)
|
|
||||||
.await?;
|
|
||||||
|
|
||||||
let shared = SharedGrantSettings::try_from_model(basic_grant)?;
|
|
||||||
|
|
||||||
if let Some(ether_grant) = evm_ether_transfer_grant::table
|
|
||||||
.filter(evm_ether_transfer_grant::basic_grant_id.eq(basic_grant_id))
|
|
||||||
.select(EvmEtherTransferGrant::as_select())
|
|
||||||
.first(&mut *conn)
|
|
||||||
.await
|
|
||||||
.optional()?
|
|
||||||
{
|
|
||||||
let target_rows: Vec<EvmEtherTransferGrantTarget> =
|
|
||||||
evm_ether_transfer_grant_target::table
|
|
||||||
.filter(evm_ether_transfer_grant_target::grant_id.eq(ether_grant.id))
|
|
||||||
.select(EvmEtherTransferGrantTarget::as_select())
|
|
||||||
.load(&mut *conn)
|
|
||||||
.await?;
|
|
||||||
let targets: Vec<Address> = target_rows
|
|
||||||
.into_iter()
|
|
||||||
.filter_map(|target| {
|
|
||||||
let arr: [u8; 20] = target.address.try_into().ok()?;
|
|
||||||
Some(Address::from(arr))
|
|
||||||
})
|
|
||||||
.collect();
|
|
||||||
|
|
||||||
let limit: EvmEtherTransferLimit = evm_ether_transfer_limit::table
|
|
||||||
.filter(evm_ether_transfer_limit::id.eq(ether_grant.limit_id))
|
|
||||||
.select(EvmEtherTransferLimit::as_select())
|
|
||||||
.first(&mut *conn)
|
|
||||||
.await?;
|
|
||||||
|
|
||||||
let settings = CombinedSettings {
|
|
||||||
shared: shared.clone(),
|
|
||||||
specific: policies::ether_transfer::Settings {
|
|
||||||
target: targets,
|
|
||||||
limit: VolumeRateLimit {
|
|
||||||
max_volume: utils::try_bytes_to_u256(&limit.max_volume).map_err(
|
|
||||||
|err| {
|
|
||||||
diesel::result::Error::DeserializationError(Box::new(err))
|
|
||||||
},
|
|
||||||
)?,
|
|
||||||
window: chrono::Duration::seconds(limit.window_secs.into()),
|
|
||||||
},
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
integrity::sign_entity(&mut *conn, &vault, &settings, basic_grant_id)
|
|
||||||
.await
|
|
||||||
.map_err(|_| diesel::result::Error::RollbackTransaction)?;
|
|
||||||
|
|
||||||
return QueryResult::Ok(());
|
|
||||||
}
|
|
||||||
|
|
||||||
if let Some(token_grant) = evm_token_transfer_grant::table
|
|
||||||
.filter(evm_token_transfer_grant::basic_grant_id.eq(basic_grant_id))
|
|
||||||
.select(EvmTokenTransferGrant::as_select())
|
|
||||||
.first(&mut *conn)
|
|
||||||
.await
|
|
||||||
.optional()?
|
|
||||||
{
|
|
||||||
let volume_limit_rows: Vec<EvmTokenTransferVolumeLimit> =
|
|
||||||
evm_token_transfer_volume_limit::table
|
|
||||||
.filter(evm_token_transfer_volume_limit::grant_id.eq(token_grant.id))
|
|
||||||
.select(EvmTokenTransferVolumeLimit::as_select())
|
|
||||||
.load(&mut *conn)
|
|
||||||
.await?;
|
|
||||||
let volume_limits: Vec<VolumeRateLimit> = volume_limit_rows
|
|
||||||
.into_iter()
|
|
||||||
.map(|row| {
|
|
||||||
Ok(VolumeRateLimit {
|
|
||||||
max_volume: utils::try_bytes_to_u256(&row.max_volume).map_err(
|
|
||||||
|err| {
|
|
||||||
diesel::result::Error::DeserializationError(Box::new(err))
|
|
||||||
},
|
|
||||||
)?,
|
|
||||||
window: chrono::Duration::seconds(row.window_secs.into()),
|
|
||||||
})
|
|
||||||
})
|
|
||||||
.collect::<QueryResult<Vec<_>>>()?;
|
|
||||||
|
|
||||||
let target: Option<Address> = match token_grant.receiver {
|
|
||||||
None => None,
|
|
||||||
Some(bytes) => {
|
|
||||||
let arr: [u8; 20] = bytes.try_into().map_err(|_| {
|
|
||||||
diesel::result::Error::DeserializationError(
|
|
||||||
"Invalid receiver address length".into(),
|
|
||||||
)
|
|
||||||
})?;
|
|
||||||
Some(Address::from(arr))
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
let token_contract: [u8; 20] =
|
|
||||||
token_grant.token_contract.clone().try_into().map_err(|_| {
|
|
||||||
diesel::result::Error::DeserializationError(
|
|
||||||
"Invalid token contract address length".into(),
|
|
||||||
)
|
|
||||||
})?;
|
|
||||||
|
|
||||||
let settings = CombinedSettings {
|
|
||||||
shared,
|
|
||||||
specific: policies::token_transfers::Settings {
|
|
||||||
token_contract: Address::from(token_contract),
|
|
||||||
target,
|
|
||||||
volume_limits,
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
integrity::sign_entity(&mut *conn, &vault, &settings, basic_grant_id)
|
|
||||||
.await
|
|
||||||
.map_err(|_| diesel::result::Error::RollbackTransaction)?;
|
|
||||||
|
|
||||||
return QueryResult::Ok(());
|
|
||||||
}
|
|
||||||
|
|
||||||
Err(diesel::result::Error::NotFound)
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.map_err(DatabaseError::from)
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn list_one_kind<Kind: Policy, Y>(
|
async fn list_one_kind<Kind: Policy, Y>(
|
||||||
&self,
|
&self,
|
||||||
conn: &mut impl AsyncConnection<Backend = Sqlite>,
|
conn: &mut impl AsyncConnection<Backend = Sqlite>,
|
||||||
@@ -502,15 +351,11 @@ impl Engine {
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use alloy::primitives::{Address, Bytes, U256, address};
|
use alloy::primitives::{Address, Bytes, U256, address};
|
||||||
use arbiter_crypto::safecell::{SafeCell, SafeCellHandle as _};
|
|
||||||
use chrono::{Duration, Utc};
|
use chrono::{Duration, Utc};
|
||||||
use diesel::{SelectableHelper, insert_into};
|
use diesel::{SelectableHelper, insert_into};
|
||||||
use diesel_async::RunQueryDsl;
|
use diesel_async::RunQueryDsl;
|
||||||
use kameo::{actor::ActorRef, prelude::Spawn};
|
|
||||||
use rstest::rstest;
|
use rstest::rstest;
|
||||||
|
|
||||||
use crate::actors::{GlobalActors, vault::{Bootstrap, Vault}};
|
|
||||||
use crate::crypto::integrity;
|
|
||||||
use crate::db::{
|
use crate::db::{
|
||||||
self, DatabaseConnection,
|
self, DatabaseConnection,
|
||||||
models::{
|
models::{
|
||||||
@@ -519,10 +364,8 @@ mod tests {
|
|||||||
},
|
},
|
||||||
schema::{evm_basic_grant, evm_transaction_log},
|
schema::{evm_basic_grant, evm_transaction_log},
|
||||||
};
|
};
|
||||||
use crate::evm::policies::ether_transfer::EtherTransfer;
|
|
||||||
use crate::evm::policies::{
|
use crate::evm::policies::{
|
||||||
CombinedSettings, EvalContext, EvalViolation, Policy, SharedGrantSettings,
|
EvalContext, EvalViolation, SharedGrantSettings, TransactionRateLimit,
|
||||||
TransactionRateLimit, VolumeRateLimit,
|
|
||||||
};
|
};
|
||||||
|
|
||||||
use super::check_shared_constraints;
|
use super::check_shared_constraints;
|
||||||
@@ -554,7 +397,6 @@ mod tests {
|
|||||||
chain: CHAIN_ID,
|
chain: CHAIN_ID,
|
||||||
valid_from: None,
|
valid_from: None,
|
||||||
valid_until: None,
|
valid_until: None,
|
||||||
revoked_at: None,
|
|
||||||
max_gas_fee_per_gas: None,
|
max_gas_fee_per_gas: None,
|
||||||
max_priority_fee_per_gas: None,
|
max_priority_fee_per_gas: None,
|
||||||
rate_limit: None,
|
rate_limit: None,
|
||||||
@@ -763,115 +605,4 @@ mod tests {
|
|||||||
assert!(violations.is_empty());
|
assert!(violations.is_empty());
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn bootstrapped_vault(db: &db::DatabasePool) -> ActorRef<Vault> {
|
|
||||||
let actor = Vault::spawn(
|
|
||||||
Vault::new(db.clone(), GlobalActors::spawn_message_bus())
|
|
||||||
.await
|
|
||||||
.unwrap(),
|
|
||||||
);
|
|
||||||
actor
|
|
||||||
.ask(Bootstrap {
|
|
||||||
seal_key_raw: SafeCell::new(b"integrity-test-seal-key".to_vec()),
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.unwrap();
|
|
||||||
actor
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn revoke_grant_preserves_revoked_integrity() {
|
|
||||||
use crate::db::schema::evm_basic_grant;
|
|
||||||
use diesel::ExpressionMethods as _;
|
|
||||||
|
|
||||||
let db = db::create_test_pool().await;
|
|
||||||
let vault = bootstrapped_vault(&db).await;
|
|
||||||
let engine = super::Engine::new(db.clone(), vault.clone());
|
|
||||||
|
|
||||||
let full_grant = CombinedSettings {
|
|
||||||
shared: SharedGrantSettings {
|
|
||||||
wallet_access_id: WALLET_ACCESS_ID,
|
|
||||||
chain: CHAIN_ID,
|
|
||||||
valid_from: None,
|
|
||||||
valid_until: None,
|
|
||||||
revoked_at: None,
|
|
||||||
max_gas_fee_per_gas: None,
|
|
||||||
max_priority_fee_per_gas: None,
|
|
||||||
rate_limit: None,
|
|
||||||
},
|
|
||||||
specific: super::policies::ether_transfer::Settings {
|
|
||||||
target: vec![RECIPIENT],
|
|
||||||
limit: VolumeRateLimit {
|
|
||||||
max_volume: U256::from(100u64),
|
|
||||||
window: Duration::hours(1),
|
|
||||||
},
|
|
||||||
},
|
|
||||||
};
|
|
||||||
|
|
||||||
let grant_id = engine
|
|
||||||
.create_grant::<EtherTransfer>(full_grant)
|
|
||||||
.await
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
engine.revoke_grant(grant_id).await.unwrap();
|
|
||||||
|
|
||||||
let mut conn = db.get().await.unwrap();
|
|
||||||
diesel::update(evm_basic_grant::table)
|
|
||||||
.filter(evm_basic_grant::id.eq(grant_id))
|
|
||||||
.set(evm_basic_grant::revoked_at.eq::<Option<SqliteTimestamp>>(None))
|
|
||||||
.execute(&mut conn)
|
|
||||||
.await
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
let wallet_access = EvmWalletAccess {
|
|
||||||
id: WALLET_ACCESS_ID,
|
|
||||||
wallet_id: EvmWalletId::from_raw(10),
|
|
||||||
client_id: 20,
|
|
||||||
created_at: SqliteTimestamp(Utc::now()),
|
|
||||||
};
|
|
||||||
let context = EvalContext {
|
|
||||||
target: wallet_access,
|
|
||||||
chain: CHAIN_ID,
|
|
||||||
to: RECIPIENT,
|
|
||||||
value: U256::ONE,
|
|
||||||
calldata: Bytes::new(),
|
|
||||||
max_fee_per_gas: 1,
|
|
||||||
max_priority_fee_per_gas: 1,
|
|
||||||
};
|
|
||||||
|
|
||||||
let grant = EtherTransfer::try_find_grant(
|
|
||||||
&context, &mut conn,
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
.unwrap()
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
let result =
|
|
||||||
integrity::verify_entity(&mut conn, &vault, &grant.settings, grant.id).await;
|
|
||||||
|
|
||||||
assert!(matches!(
|
|
||||||
result,
|
|
||||||
Err(integrity::Error::MacMismatch { .. })
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn shared_settings_hash_changes_when_revoked_at_changes() {
|
|
||||||
use arbiter_crypto::hashing::Hashable;
|
|
||||||
use sha2::Digest;
|
|
||||||
|
|
||||||
let active = shared_settings();
|
|
||||||
let revoked = SharedGrantSettings {
|
|
||||||
revoked_at: Some(Utc::now()),
|
|
||||||
..shared_settings()
|
|
||||||
};
|
|
||||||
|
|
||||||
let mut active_hash = sha2::Sha256::new();
|
|
||||||
active.hash(&mut active_hash);
|
|
||||||
|
|
||||||
let mut revoked_hash = sha2::Sha256::new();
|
|
||||||
revoked.hash(&mut revoked_hash);
|
|
||||||
|
|
||||||
assert_ne!(active_hash.finalize(), revoked_hash.finalize());
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -144,7 +144,6 @@ pub struct SharedGrantSettings {
|
|||||||
|
|
||||||
pub valid_from: Option<DateTime<Utc>>,
|
pub valid_from: Option<DateTime<Utc>>,
|
||||||
pub valid_until: Option<DateTime<Utc>>,
|
pub valid_until: Option<DateTime<Utc>>,
|
||||||
pub revoked_at: Option<DateTime<Utc>>,
|
|
||||||
|
|
||||||
pub max_gas_fee_per_gas: Option<U256>,
|
pub max_gas_fee_per_gas: Option<U256>,
|
||||||
pub max_priority_fee_per_gas: Option<U256>,
|
pub max_priority_fee_per_gas: Option<U256>,
|
||||||
@@ -159,7 +158,6 @@ impl SharedGrantSettings {
|
|||||||
chain: model.chain_id.into(),
|
chain: model.chain_id.into(),
|
||||||
valid_from: model.valid_from.map(Into::into),
|
valid_from: model.valid_from.map(Into::into),
|
||||||
valid_until: model.valid_until.map(Into::into),
|
valid_until: model.valid_until.map(Into::into),
|
||||||
revoked_at: model.revoked_at.map(Into::into),
|
|
||||||
max_gas_fee_per_gas: model
|
max_gas_fee_per_gas: model
|
||||||
.max_gas_fee_per_gas
|
.max_gas_fee_per_gas
|
||||||
.map(|b| utils::try_bytes_to_u256(&b))
|
.map(|b| utils::try_bytes_to_u256(&b))
|
||||||
|
|||||||
@@ -80,7 +80,6 @@ fn shared() -> SharedGrantSettings {
|
|||||||
chain: CHAIN_ID,
|
chain: CHAIN_ID,
|
||||||
valid_from: None,
|
valid_from: None,
|
||||||
valid_until: None,
|
valid_until: None,
|
||||||
revoked_at: None,
|
|
||||||
max_gas_fee_per_gas: None,
|
max_gas_fee_per_gas: None,
|
||||||
max_priority_fee_per_gas: None,
|
max_priority_fee_per_gas: None,
|
||||||
rate_limit: None,
|
rate_limit: None,
|
||||||
|
|||||||
@@ -98,7 +98,6 @@ fn shared() -> SharedGrantSettings {
|
|||||||
chain: CHAIN_ID,
|
chain: CHAIN_ID,
|
||||||
valid_from: None,
|
valid_from: None,
|
||||||
valid_until: None,
|
valid_until: None,
|
||||||
revoked_at: None,
|
|
||||||
max_gas_fee_per_gas: None,
|
max_gas_fee_per_gas: None,
|
||||||
max_priority_fee_per_gas: None,
|
max_priority_fee_per_gas: None,
|
||||||
rate_limit: None,
|
rate_limit: None,
|
||||||
|
|||||||
@@ -200,7 +200,7 @@ impl Convert for auth::Outbound {
|
|||||||
.timestamp
|
.timestamp
|
||||||
.timestamp_nanos_opt()
|
.timestamp_nanos_opt()
|
||||||
.expect("timestamp within range")
|
.expect("timestamp within range")
|
||||||
.cast_unsigned(),
|
as u64,
|
||||||
random: challenge.nonce.to_vec(),
|
random: challenge.nonce.to_vec(),
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -80,7 +80,7 @@ impl Sender<Result<auth::Outbound, auth::Error>> for AuthTransportAdapter<'_> {
|
|||||||
.timestamp
|
.timestamp
|
||||||
.timestamp_nanos_opt()
|
.timestamp_nanos_opt()
|
||||||
.expect("timestamp within range")
|
.expect("timestamp within range")
|
||||||
.cast_unsigned(),
|
as u64,
|
||||||
random: challenge.nonce.to_vec(),
|
random: challenge.nonce.to_vec(),
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -171,7 +171,7 @@ impl Receiver<auth::Inbound> for AuthTransportAdapter<'_> {
|
|||||||
|
|
||||||
Some(auth::Inbound::AuthChallengeRequest {
|
Some(auth::Inbound::AuthChallengeRequest {
|
||||||
pubkey,
|
pubkey,
|
||||||
bootstrap_token: bootstrap_token.map(String::into_bytes),
|
bootstrap_token,
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
AuthRequestPayload::ChallengeSolution(ProtoAuthChallengeSolution { signature }) => {
|
AuthRequestPayload::ChallengeSolution(ProtoAuthChallengeSolution { signature }) => {
|
||||||
|
|||||||
@@ -217,11 +217,6 @@ async fn handle_sign_transaction(
|
|||||||
result: Some(vet_error.convert()),
|
result: Some(vet_error.convert()),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
Err(kameo::error::SendError::HandlerError(
|
|
||||||
SessionSignTransactionError::ClientNotConnected,
|
|
||||||
)) => {
|
|
||||||
return Err(Status::permission_denied("client not connected"));
|
|
||||||
}
|
|
||||||
Err(kameo::error::SendError::HandlerError(SessionSignTransactionError::Internal)) => {
|
Err(kameo::error::SendError::HandlerError(SessionSignTransactionError::Internal)) => {
|
||||||
EvmSignTransactionResponse {
|
EvmSignTransactionResponse {
|
||||||
result: Some(EvmSignTransactionResult::Error(
|
result: Some(EvmSignTransactionResult::Error(
|
||||||
|
|||||||
@@ -86,7 +86,6 @@ impl TryConvert for ProtoSharedSettings {
|
|||||||
.valid_until
|
.valid_until
|
||||||
.map(ProtoTimestamp::try_convert)
|
.map(ProtoTimestamp::try_convert)
|
||||||
.transpose()?,
|
.transpose()?,
|
||||||
revoked_at: None,
|
|
||||||
max_gas_fee_per_gas: self
|
max_gas_fee_per_gas: self
|
||||||
.max_gas_fee_per_gas
|
.max_gas_fee_per_gas
|
||||||
.as_deref()
|
.as_deref()
|
||||||
|
|||||||
@@ -87,7 +87,6 @@ impl TryConvert for vault_gate::Outbound {
|
|||||||
let proto_result = match result {
|
let proto_result = match result {
|
||||||
Ok(()) => ProtoUnsealResult::Success,
|
Ok(()) => ProtoUnsealResult::Success,
|
||||||
Err(vault_gate::Error::InvalidKey) => ProtoUnsealResult::InvalidKey,
|
Err(vault_gate::Error::InvalidKey) => ProtoUnsealResult::InvalidKey,
|
||||||
Err(vault_gate::Error::LockedOut) => ProtoUnsealResult::LockedOut,
|
|
||||||
Err(err) => {
|
Err(err) => {
|
||||||
warn!(?err, "unseal failed");
|
warn!(?err, "unseal failed");
|
||||||
return Err(Status::internal("Failed to unseal vault"));
|
return Err(Status::internal("Failed to unseal vault"));
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ use crate::{
|
|||||||
crypto::integrity::{self, AttestationStatus},
|
crypto::integrity::{self, AttestationStatus},
|
||||||
db::{
|
db::{
|
||||||
self,
|
self,
|
||||||
models::ProgramClientMetadata,
|
models::{ProgramClientMetadata, SqliteTimestamp},
|
||||||
schema::program_client,
|
schema::program_client,
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
@@ -18,13 +18,14 @@ use arbiter_proto::{
|
|||||||
transport::{Bi, expect_message},
|
transport::{Bi, expect_message},
|
||||||
};
|
};
|
||||||
|
|
||||||
|
use chrono::Utc;
|
||||||
use diesel::{
|
use diesel::{
|
||||||
ExpressionMethods as _, OptionalExtension as _, QueryDsl as _, SelectableHelper as _,
|
ExpressionMethods as _, OptionalExtension as _, QueryDsl as _, SelectableHelper as _,
|
||||||
dsl::insert_into,
|
dsl::insert_into, update,
|
||||||
};
|
};
|
||||||
use diesel_async::RunQueryDsl as _;
|
use diesel_async::RunQueryDsl as _;
|
||||||
use kameo::{actor::ActorRef, error::SendError};
|
use kameo::{actor::ActorRef, error::SendError};
|
||||||
use tracing::{error, warn};
|
use tracing::error;
|
||||||
|
|
||||||
#[derive(thiserror::Error, Debug, Clone, PartialEq, Eq)]
|
#[derive(thiserror::Error, Debug, Clone, PartialEq, Eq)]
|
||||||
pub enum Error {
|
pub enum Error {
|
||||||
@@ -210,47 +211,71 @@ async fn insert_client(
|
|||||||
.await
|
.await
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Compares stored metadata against what a reconnecting client presents.
|
async fn sync_client_metadata(
|
||||||
/// Metadata is frozen after initial operator approval and must not be silently
|
|
||||||
/// overwritten. Doing so would let an approved client forge its displayed
|
|
||||||
/// identity in later approval prompts. Drift is logged and ignored.
|
|
||||||
async fn check_metadata_drift(
|
|
||||||
db: &db::DatabasePool,
|
db: &db::DatabasePool,
|
||||||
client_id: i32,
|
client_id: i32,
|
||||||
presented: &ClientMetadata,
|
metadata: &ClientMetadata,
|
||||||
) -> Result<(), Error> {
|
) -> Result<(), Error> {
|
||||||
use crate::db::schema::client_metadata;
|
use crate::db::schema::{client_metadata, client_metadata_history};
|
||||||
|
|
||||||
|
let now = SqliteTimestamp(Utc::now());
|
||||||
|
|
||||||
let mut conn = db.get().await.map_err(|e| {
|
let mut conn = db.get().await.map_err(|e| {
|
||||||
error!(error = ?e, "Database pool error");
|
error!(error = ?e, "Database pool error");
|
||||||
Error::DatabasePoolUnavailable
|
Error::DatabasePoolUnavailable
|
||||||
})?;
|
})?;
|
||||||
|
|
||||||
let current: ProgramClientMetadata = program_client::table
|
conn.exclusive_transaction(async |conn| {
|
||||||
.find(client_id)
|
let (current_metadata_id, current): (i32, ProgramClientMetadata) = program_client::table
|
||||||
.inner_join(client_metadata::table)
|
.find(client_id)
|
||||||
.select(ProgramClientMetadata::as_select())
|
.inner_join(client_metadata::table)
|
||||||
.first(&mut conn)
|
.select((
|
||||||
.await
|
program_client::metadata_id,
|
||||||
.map_err(|e| {
|
ProgramClientMetadata::as_select(),
|
||||||
error!(error = ?e, "Database error");
|
))
|
||||||
Error::DatabaseOperationFailed
|
.first(&mut *conn)
|
||||||
})?;
|
.await?;
|
||||||
|
|
||||||
let changed = current.name != presented.name
|
let unchanged = current.name == metadata.name
|
||||||
|| current.description != presented.description
|
&& current.description == metadata.description
|
||||||
|| current.version != presented.version;
|
&& current.version == metadata.version;
|
||||||
|
if unchanged {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
if changed {
|
insert_into(client_metadata_history::table)
|
||||||
warn!(
|
.values((
|
||||||
client_id,
|
client_metadata_history::metadata_id.eq(current_metadata_id),
|
||||||
stored_name = %current.name,
|
client_metadata_history::client_id.eq(client_id),
|
||||||
presented_name = %presented.name,
|
))
|
||||||
"reconnecting client presented different metadata; ignoring - metadata is frozen after operator approval"
|
.execute(&mut *conn)
|
||||||
);
|
.await?;
|
||||||
}
|
|
||||||
|
|
||||||
Ok(())
|
let metadata_id = insert_into(client_metadata::table)
|
||||||
|
.values((
|
||||||
|
client_metadata::name.eq(&metadata.name),
|
||||||
|
client_metadata::description.eq(&metadata.description),
|
||||||
|
client_metadata::version.eq(&metadata.version),
|
||||||
|
))
|
||||||
|
.returning(client_metadata::id)
|
||||||
|
.get_result::<i32>(&mut *conn)
|
||||||
|
.await?;
|
||||||
|
|
||||||
|
update(program_client::table.find(client_id))
|
||||||
|
.set((
|
||||||
|
program_client::metadata_id.eq(metadata_id),
|
||||||
|
program_client::updated_at.eq(now),
|
||||||
|
))
|
||||||
|
.execute(&mut *conn)
|
||||||
|
.await?;
|
||||||
|
|
||||||
|
Ok::<(), diesel::result::Error>(())
|
||||||
|
})
|
||||||
|
.await
|
||||||
|
.map_err(|e| {
|
||||||
|
error!(error = ?e, "Database error");
|
||||||
|
Error::DatabaseOperationFailed
|
||||||
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn challenge_client<T>(
|
async fn challenge_client<T>(
|
||||||
@@ -273,7 +298,7 @@ where
|
|||||||
|
|
||||||
let signature = expect_message(transport, |req: Inbound| match req {
|
let signature = expect_message(transport, |req: Inbound| match req {
|
||||||
Inbound::AuthChallengeSolution { signature } => Some(signature),
|
Inbound::AuthChallengeSolution { signature } => Some(signature),
|
||||||
Inbound::AuthChallengeRequest { .. } => None,
|
_ => None,
|
||||||
})
|
})
|
||||||
.await
|
.await
|
||||||
.map_err(|e| {
|
.map_err(|e| {
|
||||||
@@ -299,7 +324,6 @@ where
|
|||||||
|
|
||||||
let client_id = if let Some(id) = get_client_id(&props.db, &pubkey).await? {
|
let client_id = if let Some(id) = get_client_id(&props.db, &pubkey).await? {
|
||||||
verify_integrity(&props.db, &props.actors.vault, &pubkey).await?;
|
verify_integrity(&props.db, &props.actors.vault, &pubkey).await?;
|
||||||
check_metadata_drift(&props.db, id, &metadata).await?;
|
|
||||||
id
|
id
|
||||||
} else {
|
} else {
|
||||||
approve_new_client(
|
approve_new_client(
|
||||||
@@ -313,6 +337,8 @@ where
|
|||||||
insert_client(&props.db, &props.actors.vault, &pubkey, &metadata).await?
|
insert_client(&props.db, &props.actors.vault, &pubkey, &metadata).await?
|
||||||
};
|
};
|
||||||
|
|
||||||
|
sync_client_metadata(&props.db, client_id, &metadata).await?;
|
||||||
|
|
||||||
let challenge = AuthChallenge::generate(&mut rand::rng());
|
let challenge = AuthChallenge::generate(&mut rand::rng());
|
||||||
challenge_client(transport, pubkey, challenge).await?;
|
challenge_client(transport, pubkey, challenge).await?;
|
||||||
|
|
||||||
|
|||||||
@@ -83,7 +83,7 @@ impl Actor for ClientSession {
|
|||||||
args.props
|
args.props
|
||||||
.actors
|
.actors
|
||||||
.flow_coordinator
|
.flow_coordinator
|
||||||
.ask(RegisterClient { client_id: args.client_id, actor: this })
|
.ask(RegisterClient { actor: this })
|
||||||
.await
|
.await
|
||||||
.map_err(|_| Error::ConnectionRegistrationFailed)?;
|
.map_err(|_| Error::ConnectionRegistrationFailed)?;
|
||||||
Ok(args)
|
Ok(args)
|
||||||
|
|||||||
@@ -14,7 +14,7 @@ mod state;
|
|||||||
pub enum Inbound {
|
pub enum Inbound {
|
||||||
AuthChallengeRequest {
|
AuthChallengeRequest {
|
||||||
pubkey: authn::PublicKey,
|
pubkey: authn::PublicKey,
|
||||||
bootstrap_token: Option<Vec<u8>>,
|
bootstrap_token: Option<String>,
|
||||||
},
|
},
|
||||||
AuthChallengeSolution {
|
AuthChallengeSolution {
|
||||||
signature: Vec<u8>,
|
signature: Vec<u8>,
|
||||||
|
|||||||
@@ -16,12 +16,13 @@ use tracing::error;
|
|||||||
|
|
||||||
pub(super) struct ChallengeRequest {
|
pub(super) struct ChallengeRequest {
|
||||||
pub(super) pubkey: authn::PublicKey,
|
pub(super) pubkey: authn::PublicKey,
|
||||||
pub(super) bootstrap_token: Option<Vec<u8>>,
|
pub(super) bootstrap_token: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
pub struct ChallengeContext {
|
pub(super) struct ChallengeContext {
|
||||||
pub(super) challenge: AuthChallenge,
|
pub(super) challenge: AuthChallenge,
|
||||||
pub(super) pubkey: authn::PublicKey,
|
pub(super) pubkey: authn::PublicKey,
|
||||||
|
pub(super) bootstrap_token: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
pub(super) struct ChallengeSolution {
|
pub(super) struct ChallengeSolution {
|
||||||
@@ -78,16 +79,11 @@ async fn register_key(db: &DatabasePool, pubkey: &authn::PublicKey) -> Result<i3
|
|||||||
pub(super) struct AuthContext<'a, T: ?Sized> {
|
pub(super) struct AuthContext<'a, T: ?Sized> {
|
||||||
pub(super) conn: &'a mut OperatorConnection,
|
pub(super) conn: &'a mut OperatorConnection,
|
||||||
pub(super) transport: &'a mut T,
|
pub(super) transport: &'a mut T,
|
||||||
bootstrap_token: Option<Vec<u8>>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<'a, T: ?Sized> AuthContext<'a, T> {
|
impl<'a, T: ?Sized> AuthContext<'a, T> {
|
||||||
pub(super) const fn new(conn: &'a mut OperatorConnection, transport: &'a mut T) -> Self {
|
pub(super) const fn new(conn: &'a mut OperatorConnection, transport: &'a mut T) -> Self {
|
||||||
Self {
|
Self { conn, transport }
|
||||||
conn,
|
|
||||||
transport,
|
|
||||||
bootstrap_token: None,
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -112,8 +108,6 @@ where
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
self.bootstrap_token = bootstrap_token;
|
|
||||||
|
|
||||||
let challenge = AuthChallenge::generate(&mut rand::rng());
|
let challenge = AuthChallenge::generate(&mut rand::rng());
|
||||||
|
|
||||||
self.transport
|
self.transport
|
||||||
@@ -126,12 +120,22 @@ where
|
|||||||
Error::Transport
|
Error::Transport
|
||||||
})?;
|
})?;
|
||||||
|
|
||||||
Ok(ChallengeContext { challenge, pubkey })
|
Ok(ChallengeContext {
|
||||||
|
challenge,
|
||||||
|
pubkey,
|
||||||
|
bootstrap_token,
|
||||||
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[allow(missing_docs)]
|
||||||
|
#[allow(clippy::unused_unit)]
|
||||||
async fn verify_solution(
|
async fn verify_solution(
|
||||||
&mut self,
|
&mut self,
|
||||||
ChallengeContext { challenge, pubkey }: &ChallengeContext,
|
ChallengeContext {
|
||||||
|
challenge,
|
||||||
|
pubkey,
|
||||||
|
bootstrap_token,
|
||||||
|
}: &ChallengeContext,
|
||||||
ChallengeSolution { solution }: ChallengeSolution,
|
ChallengeSolution { solution }: ChallengeSolution,
|
||||||
) -> Result<Credentials, Self::Error> {
|
) -> Result<Credentials, Self::Error> {
|
||||||
let signature = authn::Signature::try_from(solution.as_slice()).map_err(|()| {
|
let signature = authn::Signature::try_from(solution.as_slice()).map_err(|()| {
|
||||||
@@ -150,13 +154,15 @@ where
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Resolve client id: bootstrap (consume token + register) or lookup
|
// Resolve client id: bootstrap (consume token + register) or lookup
|
||||||
let id = match self.bootstrap_token.take() {
|
let id = match bootstrap_token {
|
||||||
Some(token) => {
|
Some(token) => {
|
||||||
let token_ok: bool = self
|
let token_ok: bool = self
|
||||||
.conn
|
.conn
|
||||||
.actors
|
.actors
|
||||||
.bootstrapper
|
.bootstrapper
|
||||||
.ask(ConsumeToken { token })
|
.ask(ConsumeToken {
|
||||||
|
token: token.clone(),
|
||||||
|
})
|
||||||
.await
|
.await
|
||||||
.map_err(|e| {
|
.map_err(|e| {
|
||||||
error!(?e, "Failed to consume bootstrap token");
|
error!(?e, "Failed to consume bootstrap token");
|
||||||
|
|||||||
@@ -5,14 +5,11 @@ use crate::{
|
|||||||
ClientSignTransaction, Generate, ListWallets, OperatorCreateGrant, OperatorListGrants,
|
ClientSignTransaction, Generate, ListWallets, OperatorCreateGrant, OperatorListGrants,
|
||||||
SignTransactionError as EvmSignError,
|
SignTransactionError as EvmSignError,
|
||||||
},
|
},
|
||||||
flow_coordinator::{IsClientConnected, client_connect_approval::ClientApprovalAnswer},
|
flow_coordinator::client_connect_approval::ClientApprovalAnswer,
|
||||||
vault::VaultState,
|
vault::VaultState,
|
||||||
},
|
},
|
||||||
db::{
|
db::models::{
|
||||||
models::{
|
EvmWalletAccess, EvmWalletId, NewEvmWalletAccess, ProgramClient, ProgramClientMetadata,
|
||||||
EvmWalletAccess, EvmWalletId, NewEvmWalletAccess, ProgramClient, ProgramClientMetadata,
|
|
||||||
},
|
|
||||||
schema::program_client,
|
|
||||||
},
|
},
|
||||||
evm::policies::{Grant, SpecificGrant},
|
evm::policies::{Grant, SpecificGrant},
|
||||||
};
|
};
|
||||||
@@ -22,16 +19,13 @@ use alloy::{consensus::TxEip1559, primitives::Address, signers::Signature};
|
|||||||
use diesel::{ExpressionMethods as _, QueryDsl as _, SelectableHelper};
|
use diesel::{ExpressionMethods as _, QueryDsl as _, SelectableHelper};
|
||||||
use diesel_async::{AsyncConnection, RunQueryDsl};
|
use diesel_async::{AsyncConnection, RunQueryDsl};
|
||||||
use kameo::{error::SendError, messages, prelude::Context};
|
use kameo::{error::SendError, messages, prelude::Context};
|
||||||
use tracing::{error, info, warn};
|
use tracing::error;
|
||||||
|
|
||||||
#[derive(Debug, Error)]
|
#[derive(Debug, Error)]
|
||||||
pub enum SignTransactionError {
|
pub enum SignTransactionError {
|
||||||
#[error("Policy evaluation failed")]
|
#[error("Policy evaluation failed")]
|
||||||
Vet(#[from] crate::evm::VetError),
|
Vet(#[from] crate::evm::VetError),
|
||||||
|
|
||||||
#[error("Client not connected")]
|
|
||||||
ClientNotConnected,
|
|
||||||
|
|
||||||
#[error("Internal signing error")]
|
#[error("Internal signing error")]
|
||||||
Internal,
|
Internal,
|
||||||
}
|
}
|
||||||
@@ -153,30 +147,6 @@ impl OperatorSession {
|
|||||||
wallet_address: Address,
|
wallet_address: Address,
|
||||||
transaction: TxEip1559,
|
transaction: TxEip1559,
|
||||||
) -> Result<Signature, SignTransactionError> {
|
) -> Result<Signature, SignTransactionError> {
|
||||||
if !self.approved_client_ids.contains(&client_id) {
|
|
||||||
warn!(
|
|
||||||
client_id,
|
|
||||||
"operator attempted to sign for client not in its approved set"
|
|
||||||
);
|
|
||||||
return Err(SignTransactionError::ClientNotConnected);
|
|
||||||
}
|
|
||||||
|
|
||||||
let connected = self
|
|
||||||
.props
|
|
||||||
.actors
|
|
||||||
.flow_coordinator
|
|
||||||
.ask(IsClientConnected { client_id })
|
|
||||||
.await
|
|
||||||
.unwrap_or(false);
|
|
||||||
|
|
||||||
if !connected {
|
|
||||||
self.approved_client_ids.remove(&client_id);
|
|
||||||
warn!(client_id, "operator attempted to sign for disconnected client");
|
|
||||||
return Err(SignTransactionError::ClientNotConnected);
|
|
||||||
}
|
|
||||||
|
|
||||||
info!(client_id, event = "sign_transaction", "operator.sign_transaction");
|
|
||||||
|
|
||||||
match self
|
match self
|
||||||
.props
|
.props
|
||||||
.actors
|
.actors
|
||||||
@@ -232,7 +202,7 @@ impl OperatorSession {
|
|||||||
use crate::db::schema::evm_wallet_access;
|
use crate::db::schema::evm_wallet_access;
|
||||||
for entry in entries {
|
for entry in entries {
|
||||||
diesel::delete(evm_wallet_access::table)
|
diesel::delete(evm_wallet_access::table)
|
||||||
.filter(evm_wallet_access::id.eq(entry))
|
.filter(evm_wallet_access::wallet_id.eq(entry))
|
||||||
.execute(&mut *conn)
|
.execute(&mut *conn)
|
||||||
.await?;
|
.await?;
|
||||||
}
|
}
|
||||||
@@ -248,7 +218,8 @@ impl OperatorSession {
|
|||||||
&mut self,
|
&mut self,
|
||||||
) -> Result<Vec<EvmWalletAccess>, Error> {
|
) -> Result<Vec<EvmWalletAccess>, Error> {
|
||||||
let mut conn = self.props.db.get().await?;
|
let mut conn = self.props.db.get().await?;
|
||||||
let access_entries = crate::db::schema::evm_wallet_access::table
|
use crate::db::schema::evm_wallet_access;
|
||||||
|
let access_entries = evm_wallet_access::table
|
||||||
.select(EvmWalletAccess::as_select())
|
.select(EvmWalletAccess::as_select())
|
||||||
.load::<_>(&mut conn)
|
.load::<_>(&mut conn)
|
||||||
.await?;
|
.await?;
|
||||||
@@ -285,30 +256,6 @@ impl OperatorSession {
|
|||||||
|
|
||||||
ctx.actor_ref().unlink(&pending_approval.controller).await;
|
ctx.actor_ref().unlink(&pending_approval.controller).await;
|
||||||
|
|
||||||
if approved {
|
|
||||||
let pubkey_bytes = pending_approval.pubkey.to_bytes();
|
|
||||||
match self.props.db.get().await {
|
|
||||||
Ok(mut conn) => {
|
|
||||||
match program_client::table
|
|
||||||
.filter(program_client::public_key.eq(pubkey_bytes.as_slice()))
|
|
||||||
.select(program_client::id)
|
|
||||||
.first::<i32>(&mut conn)
|
|
||||||
.await
|
|
||||||
{
|
|
||||||
Ok(client_id) => {
|
|
||||||
self.approved_client_ids.insert(client_id);
|
|
||||||
}
|
|
||||||
Err(err) => {
|
|
||||||
error!(?err, "Failed to look up client_id for approved pubkey");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Err(err) => {
|
|
||||||
error!(?err, "DB pool error after client approval");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -331,142 +278,3 @@ impl OperatorSession {
|
|||||||
Ok(clients)
|
Ok(clients)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
|
||||||
mod tests {
|
|
||||||
use crate::db::{self, models::{EvmWalletId, NewEvmWalletAccess}, schema::evm_wallet_access};
|
|
||||||
use diesel::{ExpressionMethods as _, QueryDsl as _, SelectableHelper};
|
|
||||||
use diesel_async::{AsyncConnection, RunQueryDsl};
|
|
||||||
|
|
||||||
/// Regression test: revocation must delete by access-entry `id`, not by `wallet_id`.
|
|
||||||
///
|
|
||||||
/// Before the fix, revoking `entry_id=1` would delete all rows where `wallet_id=1`,
|
|
||||||
/// wiping out every client's access to wallet #1.
|
|
||||||
#[tokio::test]
|
|
||||||
async fn revoke_deletes_by_entry_id_not_wallet_id() {
|
|
||||||
use crate::db::models::EvmWalletAccess;
|
|
||||||
|
|
||||||
let pool = db::create_test_pool().await;
|
|
||||||
let mut conn = pool.get().await.expect("pool connection");
|
|
||||||
|
|
||||||
// Insert two access entries for the same wallet but different clients.
|
|
||||||
// entry A: id will be 1, wallet_id=1, client_id=10
|
|
||||||
// entry B: id will be 2, wallet_id=1, client_id=20
|
|
||||||
let entry_a = diesel::insert_into(evm_wallet_access::table)
|
|
||||||
.values(NewEvmWalletAccess {
|
|
||||||
wallet_id: EvmWalletId::from_raw(1),
|
|
||||||
client_id: 10,
|
|
||||||
})
|
|
||||||
.returning(EvmWalletAccess::as_select())
|
|
||||||
.get_result(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("insert entry A");
|
|
||||||
|
|
||||||
let entry_b = diesel::insert_into(evm_wallet_access::table)
|
|
||||||
.values(NewEvmWalletAccess {
|
|
||||||
wallet_id: EvmWalletId::from_raw(1),
|
|
||||||
client_id: 20,
|
|
||||||
})
|
|
||||||
.returning(EvmWalletAccess::as_select())
|
|
||||||
.get_result(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("insert entry B");
|
|
||||||
|
|
||||||
// Revoke only entry A by its primary key id.
|
|
||||||
conn.transaction(async |conn| {
|
|
||||||
diesel::delete(evm_wallet_access::table)
|
|
||||||
.filter(evm_wallet_access::id.eq(entry_a.id))
|
|
||||||
.execute(&mut *conn)
|
|
||||||
.await
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.expect("revoke entry A");
|
|
||||||
|
|
||||||
// Entry A must be gone.
|
|
||||||
let gone = evm_wallet_access::table
|
|
||||||
.filter(evm_wallet_access::id.eq(entry_a.id))
|
|
||||||
.count()
|
|
||||||
.get_result::<i64>(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("count entry A");
|
|
||||||
assert_eq!(gone, 0, "revoked entry must be deleted");
|
|
||||||
|
|
||||||
// Entry B (same wallet, different client) must still exist.
|
|
||||||
let still_there = evm_wallet_access::table
|
|
||||||
.filter(evm_wallet_access::id.eq(entry_b.id))
|
|
||||||
.count()
|
|
||||||
.get_result::<i64>(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("count entry B");
|
|
||||||
assert_eq!(still_there, 1, "unrelated entry must not be deleted");
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Regression test: when `entry_id` and `wallet_id` differ, only the correct row is removed.
|
|
||||||
///
|
|
||||||
/// This specifically catches the case where `entry.id=5` and `wallet_id=1` are different values;
|
|
||||||
/// the old bug would delete by `wallet_id`, potentially matching a completely different entry.
|
|
||||||
#[tokio::test]
|
|
||||||
async fn revoke_with_mismatched_wallet_and_entry_ids() {
|
|
||||||
use crate::db::models::EvmWalletAccess;
|
|
||||||
|
|
||||||
let pool = db::create_test_pool().await;
|
|
||||||
let mut conn = pool.get().await.expect("pool connection");
|
|
||||||
|
|
||||||
// Insert entries to force auto-increment IDs to diverge from wallet_ids.
|
|
||||||
// We'll insert 5 placeholder entries first so that the real entry gets id=6.
|
|
||||||
for i in 1_i32..=5 {
|
|
||||||
diesel::insert_into(evm_wallet_access::table)
|
|
||||||
.values(NewEvmWalletAccess {
|
|
||||||
wallet_id: EvmWalletId::from_raw(99),
|
|
||||||
client_id: i,
|
|
||||||
})
|
|
||||||
.execute(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("insert placeholder");
|
|
||||||
}
|
|
||||||
|
|
||||||
// Real target: wallet_id=1, will get id=6.
|
|
||||||
let target = diesel::insert_into(evm_wallet_access::table)
|
|
||||||
.values(NewEvmWalletAccess {
|
|
||||||
wallet_id: EvmWalletId::from_raw(1),
|
|
||||||
client_id: 1,
|
|
||||||
})
|
|
||||||
.returning(EvmWalletAccess::as_select())
|
|
||||||
.get_result(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("insert target");
|
|
||||||
|
|
||||||
// Sanity: target.id != target.wallet_id
|
|
||||||
assert_ne!(
|
|
||||||
target.id, target.wallet_id.to_raw(),
|
|
||||||
"test prerequisite: id and wallet_id must differ"
|
|
||||||
);
|
|
||||||
|
|
||||||
// Revoke by entry id.
|
|
||||||
conn.transaction(async |conn| {
|
|
||||||
diesel::delete(evm_wallet_access::table)
|
|
||||||
.filter(evm_wallet_access::id.eq(target.id))
|
|
||||||
.execute(&mut *conn)
|
|
||||||
.await
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.expect("revoke target");
|
|
||||||
|
|
||||||
let remaining = evm_wallet_access::table
|
|
||||||
.filter(evm_wallet_access::id.eq(target.id))
|
|
||||||
.count()
|
|
||||||
.get_result::<i64>(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("count target");
|
|
||||||
assert_eq!(remaining, 0, "target must be deleted by its entry id");
|
|
||||||
|
|
||||||
// Placeholders for wallet_id=99 must be untouched.
|
|
||||||
let placeholders = evm_wallet_access::table
|
|
||||||
.filter(evm_wallet_access::wallet_id.eq(99))
|
|
||||||
.count()
|
|
||||||
.get_result::<i64>(&mut *conn)
|
|
||||||
.await
|
|
||||||
.expect("count placeholders");
|
|
||||||
assert_eq!(placeholders, 5, "unrelated entries must survive");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -1,14 +1,16 @@
|
|||||||
use super::{OutOfBand, OperatorConnection};
|
use super::{OutOfBand, OperatorConnection};
|
||||||
use crate::{
|
use crate::{
|
||||||
actors::{
|
actors::{
|
||||||
flow_coordinator::{GetConnectedClientIds, client_connect_approval::{ClientApprovalAnswer, ClientApprovalController}}, operator_registry::ConnectOperator,
|
flow_coordinator::client_connect_approval::ClientApprovalController,
|
||||||
}, peers::client::ClientProfile,
|
operator_registry::ConnectOperator,
|
||||||
|
},
|
||||||
|
peers::client::ClientProfile,
|
||||||
};
|
};
|
||||||
use arbiter_crypto::authn;
|
use arbiter_crypto::authn;
|
||||||
use arbiter_proto::transport::Sender;
|
use arbiter_proto::transport::Sender;
|
||||||
|
|
||||||
use kameo::{Actor, actor::ActorRef, messages};
|
use kameo::{Actor, actor::ActorRef, messages};
|
||||||
use std::{borrow::Cow, collections::{HashMap, HashSet}};
|
use std::{borrow::Cow, collections::HashMap};
|
||||||
use thiserror::Error;
|
use thiserror::Error;
|
||||||
use tracing::error;
|
use tracing::error;
|
||||||
|
|
||||||
@@ -52,10 +54,6 @@ pub struct OperatorSession {
|
|||||||
sender: Box<dyn Sender<OutOfBand>>,
|
sender: Box<dyn Sender<OutOfBand>>,
|
||||||
|
|
||||||
pending_client_approvals: HashMap<Vec<u8>, PendingClientApproval>,
|
pending_client_approvals: HashMap<Vec<u8>, PendingClientApproval>,
|
||||||
/// DB `client_ids` this operator session is allowed to sign for.
|
|
||||||
/// Seeded from currently-connected clients on start, then updated as
|
|
||||||
/// approvals are granted or denied during the session lifetime.
|
|
||||||
approved_client_ids: HashSet<i32>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub mod handlers;
|
pub mod handlers;
|
||||||
@@ -65,8 +63,7 @@ impl OperatorSession {
|
|||||||
Self {
|
Self {
|
||||||
props,
|
props,
|
||||||
sender,
|
sender,
|
||||||
pending_client_approvals: HashMap::default(),
|
pending_client_approvals: Default::default(),
|
||||||
approved_client_ids: HashSet::default(),
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -91,7 +88,6 @@ impl OperatorSession {
|
|||||||
actor = "operator",
|
actor = "operator",
|
||||||
event = "failed to announce new client connection"
|
event = "failed to announce new client connection"
|
||||||
);
|
);
|
||||||
let _ = controller.tell(ClientApprovalAnswer { approved: false }).await;
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -110,7 +106,7 @@ impl Actor for OperatorSession {
|
|||||||
|
|
||||||
type Error = Error;
|
type Error = Error;
|
||||||
|
|
||||||
async fn on_start(mut args: Self::Args, this: ActorRef<Self>) -> Result<Self, Self::Error> {
|
async fn on_start(args: Self::Args, this: ActorRef<Self>) -> Result<Self, Self::Error> {
|
||||||
args.props
|
args.props
|
||||||
.actors
|
.actors
|
||||||
.operator_registry
|
.operator_registry
|
||||||
@@ -125,16 +121,6 @@ impl Actor for OperatorSession {
|
|||||||
);
|
);
|
||||||
Error::internal("Failed to register operator connection with operator registry")
|
Error::internal("Failed to register operator connection with operator registry")
|
||||||
})?;
|
})?;
|
||||||
|
|
||||||
// Seed approved set with clients already connected when this session starts.
|
|
||||||
// New clients will be added via handle_new_client_approve as they are approved.
|
|
||||||
match args.props.actors.flow_coordinator.ask(GetConnectedClientIds {}).await {
|
|
||||||
Ok(ids) => args.approved_client_ids.extend(ids),
|
|
||||||
Err(err) => {
|
|
||||||
error!(?err, "Failed to fetch connected client IDs on operator session start");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(args)
|
Ok(args)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -25,8 +25,6 @@ pub enum Error {
|
|||||||
AlreadyBootstrapped,
|
AlreadyBootstrapped,
|
||||||
#[error("Invalid key provided")]
|
#[error("Invalid key provided")]
|
||||||
InvalidKey,
|
InvalidKey,
|
||||||
#[error("Vault locked: too many failed unseal attempts")]
|
|
||||||
LockedOut,
|
|
||||||
|
|
||||||
#[error("State transition failed")]
|
#[error("State transition failed")]
|
||||||
State,
|
State,
|
||||||
@@ -172,7 +170,6 @@ impl VaultGate {
|
|||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
Err(SendError::HandlerError(vault::Error::InvalidKey)) => Err(Error::InvalidKey),
|
Err(SendError::HandlerError(vault::Error::InvalidKey)) => Err(Error::InvalidKey),
|
||||||
Err(SendError::HandlerError(vault::Error::LockedOut)) => Err(Error::LockedOut),
|
|
||||||
Err(SendError::HandlerError(err)) => {
|
Err(SendError::HandlerError(err)) => {
|
||||||
error!(?err, "Vault failed to unseal key");
|
error!(?err, "Vault failed to unseal key");
|
||||||
Err(Error::InvalidKey)
|
Err(Error::InvalidKey)
|
||||||
|
|||||||
@@ -266,7 +266,7 @@ pub async fn metadata_unchanged_does_not_append_history() {
|
|||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
pub async fn metadata_frozen_after_approval_ignores_reconnect_changes() {
|
pub async fn metadata_change_appends_history_and_repoints_binding() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let actors = spawn_test_actors(&db).await;
|
let actors = spawn_test_actors(&db).await;
|
||||||
let new_key = MlDsa87::key_gen(&mut rand::rng());
|
let new_key = MlDsa87::key_gen(&mut rand::rng());
|
||||||
@@ -287,7 +287,6 @@ pub async fn metadata_frozen_after_approval_ignores_reconnect_changes() {
|
|||||||
connect_client(props, &mut server_transport).await;
|
connect_client(props, &mut server_transport).await;
|
||||||
});
|
});
|
||||||
|
|
||||||
// Reconnect presenting different metadata — must be silently ignored.
|
|
||||||
test_transport
|
test_transport
|
||||||
.send(auth::Inbound::AuthChallengeRequest {
|
.send(auth::Inbound::AuthChallengeRequest {
|
||||||
pubkey: verifying_key(&new_key).into(),
|
pubkey: verifying_key(&new_key).into(),
|
||||||
@@ -314,7 +313,6 @@ pub async fn metadata_frozen_after_approval_ignores_reconnect_changes() {
|
|||||||
client_metadata, client_metadata_history, program_client,
|
client_metadata, client_metadata_history, program_client,
|
||||||
};
|
};
|
||||||
let mut conn = db.get().await.unwrap();
|
let mut conn = db.get().await.unwrap();
|
||||||
// Metadata is frozen: no new row, no history entry.
|
|
||||||
let metadata_count: i64 = client_metadata::table
|
let metadata_count: i64 = client_metadata::table
|
||||||
.count()
|
.count()
|
||||||
.get_result(&mut conn)
|
.get_result(&mut conn)
|
||||||
@@ -340,16 +338,15 @@ pub async fn metadata_frozen_after_approval_ignores_reconnect_changes() {
|
|||||||
.first::<(String, Option<String>, Option<String>)>(&mut conn)
|
.first::<(String, Option<String>, Option<String>)>(&mut conn)
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
assert_eq!(metadata_count, 1, "frozen: no new metadata row on reconnect");
|
assert_eq!(metadata_count, 2);
|
||||||
assert_eq!(history_count, 0, "frozen: no history entry on reconnect");
|
assert_eq!(history_count, 1);
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
current,
|
current,
|
||||||
(
|
(
|
||||||
"client".to_owned(),
|
"client".to_owned(),
|
||||||
Some("old".to_owned()),
|
Some("new".to_owned()),
|
||||||
Some("1.0.0".to_owned())
|
Some("2.0.0".to_owned())
|
||||||
),
|
)
|
||||||
"frozen: original metadata must be preserved"
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -174,7 +174,7 @@ pub async fn bootstrap_token_auth() {
|
|||||||
test_transport
|
test_transport
|
||||||
.send(auth::Inbound::AuthChallengeRequest {
|
.send(auth::Inbound::AuthChallengeRequest {
|
||||||
pubkey: verifying_key(&new_key).into(),
|
pubkey: verifying_key(&new_key).into(),
|
||||||
bootstrap_token: Some(token.into_bytes()),
|
bootstrap_token: Some(token),
|
||||||
})
|
})
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
@@ -231,7 +231,7 @@ pub async fn bootstrap_invalid_token_auth() {
|
|||||||
test_transport
|
test_transport
|
||||||
.send(auth::Inbound::AuthChallengeRequest {
|
.send(auth::Inbound::AuthChallengeRequest {
|
||||||
pubkey: verifying_key(&new_key).into(),
|
pubkey: verifying_key(&new_key).into(),
|
||||||
bootstrap_token: Some(b"invalid_token".to_vec()),
|
bootstrap_token: Some("invalid_token".to_owned()),
|
||||||
})
|
})
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
@@ -400,7 +400,7 @@ pub async fn challenge_auth_rejects_integrity_tag_mismatch_when_unsealed() {
|
|||||||
let challenge = match response {
|
let challenge = match response {
|
||||||
Ok(resp) => match resp {
|
Ok(resp) => match resp {
|
||||||
auth::Outbound::AuthChallenge { challenge } => challenge,
|
auth::Outbound::AuthChallenge { challenge } => challenge,
|
||||||
other @ auth::Outbound::AuthSuccess => panic!("Expected AuthChallenge, got {other:?}"),
|
other => panic!("Expected AuthChallenge, got {other:?}"),
|
||||||
},
|
},
|
||||||
Err(err) => panic!("Expected Ok response, got Err({err:?})"),
|
Err(err) => panic!("Expected Ok response, got Err({err:?})"),
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -14,8 +14,6 @@ use kameo::actor::{ActorRef, Spawn as _};
|
|||||||
use std::collections::{HashMap, HashSet};
|
use std::collections::{HashMap, HashSet};
|
||||||
use tokio::task::JoinSet;
|
use tokio::task::JoinSet;
|
||||||
|
|
||||||
const TEST_AAD: &[u8] = b"test-aad";
|
|
||||||
|
|
||||||
async fn write_concurrently(
|
async fn write_concurrently(
|
||||||
actor: ActorRef<Vault>,
|
actor: ActorRef<Vault>,
|
||||||
prefix: &'static str,
|
prefix: &'static str,
|
||||||
@@ -29,7 +27,6 @@ async fn write_concurrently(
|
|||||||
let id = actor
|
let id = actor
|
||||||
.ask(CreateNew {
|
.ask(CreateNew {
|
||||||
plaintext: SafeCell::new(plaintext.clone()),
|
plaintext: SafeCell::new(plaintext.clone()),
|
||||||
aad: TEST_AAD.to_vec(),
|
|
||||||
})
|
})
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
@@ -123,7 +120,7 @@ async fn insert_failure_does_not_create_partial_row() {
|
|||||||
drop(conn);
|
drop(conn);
|
||||||
|
|
||||||
let err = actor
|
let err = actor
|
||||||
.create_new(SafeCell::new(b"should fail".to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(b"should fail".to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap_err();
|
.unwrap_err();
|
||||||
assert!(matches!(err, Error::DatabaseTransaction(_)));
|
assert!(matches!(err, Error::DatabaseTransaction(_)));
|
||||||
@@ -174,7 +171,7 @@ async fn decrypt_roundtrip_after_high_concurrency() {
|
|||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
for (id, plaintext) in expected {
|
for (id, plaintext) in expected {
|
||||||
let mut decrypted = decryptor.decrypt(id, TEST_AAD.to_vec()).await.unwrap();
|
let mut decrypted = decryptor.decrypt(id).await.unwrap();
|
||||||
assert_eq!(*decrypted.read(), plaintext);
|
assert_eq!(*decrypted.read(), plaintext);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -12,11 +12,9 @@ use arbiter_server::{
|
|||||||
use diesel::{QueryDsl, SelectableHelper};
|
use diesel::{QueryDsl, SelectableHelper};
|
||||||
use diesel_async::RunQueryDsl;
|
use diesel_async::RunQueryDsl;
|
||||||
|
|
||||||
const TEST_AAD: &[u8] = b"test-aad";
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn bootstrap() {
|
async fn test_bootstrap() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = Vault::new(db.clone(), GlobalActors::spawn_message_bus())
|
let mut actor = Vault::new(db.clone(), GlobalActors::spawn_message_bus())
|
||||||
.await
|
.await
|
||||||
@@ -41,7 +39,7 @@ async fn bootstrap() {
|
|||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn bootstrap_rejects_double() {
|
async fn test_bootstrap_rejects_double() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
|
|
||||||
@@ -52,14 +50,14 @@ async fn bootstrap_rejects_double() {
|
|||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn create_new_before_bootstrap_fails() {
|
async fn test_create_new_before_bootstrap_fails() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = Vault::new(db, GlobalActors::spawn_message_bus())
|
let mut actor = Vault::new(db, GlobalActors::spawn_message_bus())
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
let err = actor
|
let err = actor
|
||||||
.create_new(SafeCell::new(b"data".to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(b"data".to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap_err();
|
.unwrap_err();
|
||||||
assert!(matches!(err, Error::NotBootstrapped));
|
assert!(matches!(err, Error::NotBootstrapped));
|
||||||
@@ -67,19 +65,19 @@ async fn create_new_before_bootstrap_fails() {
|
|||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn decrypt_before_bootstrap_fails() {
|
async fn test_decrypt_before_bootstrap_fails() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = Vault::new(db, GlobalActors::spawn_message_bus())
|
let mut actor = Vault::new(db, GlobalActors::spawn_message_bus())
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
let err = actor.decrypt(1, TEST_AAD.to_vec()).await.unwrap_err();
|
let err = actor.decrypt(1).await.unwrap_err();
|
||||||
assert!(matches!(err, Error::NotBootstrapped));
|
assert!(matches!(err, Error::NotBootstrapped));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn new_restores_sealed_state() {
|
async fn test_new_restores_sealed_state() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let actor = common::bootstrapped_vault(&db).await;
|
let actor = common::bootstrapped_vault(&db).await;
|
||||||
drop(actor);
|
drop(actor);
|
||||||
@@ -87,19 +85,19 @@ async fn new_restores_sealed_state() {
|
|||||||
let mut actor2 = Vault::new(db, GlobalActors::spawn_message_bus())
|
let mut actor2 = Vault::new(db, GlobalActors::spawn_message_bus())
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
let err = actor2.decrypt(1, TEST_AAD.to_vec()).await.unwrap_err();
|
let err = actor2.decrypt(1).await.unwrap_err();
|
||||||
assert!(matches!(err, Error::Sealed));
|
assert!(matches!(err, Error::Sealed));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn unseal_correct_password() {
|
async fn test_unseal_correct_password() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
|
|
||||||
let plaintext = b"survive a restart";
|
let plaintext = b"survive a restart";
|
||||||
let aead_id = actor
|
let aead_id = actor
|
||||||
.create_new(SafeCell::new(plaintext.to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(plaintext.to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
drop(actor);
|
drop(actor);
|
||||||
@@ -110,19 +108,19 @@ async fn unseal_correct_password() {
|
|||||||
let seal_key = SafeCell::new(b"test-seal-key".to_vec());
|
let seal_key = SafeCell::new(b"test-seal-key".to_vec());
|
||||||
actor.try_unseal(seal_key).await.unwrap();
|
actor.try_unseal(seal_key).await.unwrap();
|
||||||
|
|
||||||
let mut decrypted = actor.decrypt(aead_id, TEST_AAD.to_vec()).await.unwrap();
|
let mut decrypted = actor.decrypt(aead_id).await.unwrap();
|
||||||
assert_eq!(*decrypted.read(), plaintext);
|
assert_eq!(*decrypted.read(), plaintext);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn unseal_wrong_then_correct_password() {
|
async fn test_unseal_wrong_then_correct_password() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
|
|
||||||
let plaintext = b"important data";
|
let plaintext = b"important data";
|
||||||
let aead_id = actor
|
let aead_id = actor
|
||||||
.create_new(SafeCell::new(plaintext.to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(plaintext.to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
drop(actor);
|
drop(actor);
|
||||||
@@ -138,6 +136,6 @@ async fn unseal_wrong_then_correct_password() {
|
|||||||
let good_key = SafeCell::new(b"test-seal-key".to_vec());
|
let good_key = SafeCell::new(b"test-seal-key".to_vec());
|
||||||
actor.try_unseal(good_key).await.unwrap();
|
actor.try_unseal(good_key).await.unwrap();
|
||||||
|
|
||||||
let mut decrypted = actor.decrypt(aead_id, TEST_AAD.to_vec()).await.unwrap();
|
let mut decrypted = actor.decrypt(aead_id).await.unwrap();
|
||||||
assert_eq!(*decrypted.read(), plaintext);
|
assert_eq!(*decrypted.read(), plaintext);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -10,47 +10,45 @@ use diesel::{ExpressionMethods as _, QueryDsl, SelectableHelper, dsl::update};
|
|||||||
use diesel_async::RunQueryDsl;
|
use diesel_async::RunQueryDsl;
|
||||||
use std::collections::HashSet;
|
use std::collections::HashSet;
|
||||||
|
|
||||||
const TEST_AAD: &[u8] = b"test-aad";
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn create_decrypt_roundtrip() {
|
async fn test_create_decrypt_roundtrip() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
|
|
||||||
let plaintext = b"hello arbiter";
|
let plaintext = b"hello arbiter";
|
||||||
let aead_id = actor
|
let aead_id = actor
|
||||||
.create_new(SafeCell::new(plaintext.to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(plaintext.to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
let mut decrypted = actor.decrypt(aead_id, TEST_AAD.to_vec()).await.unwrap();
|
let mut decrypted = actor.decrypt(aead_id).await.unwrap();
|
||||||
assert_eq!(*decrypted.read(), plaintext);
|
assert_eq!(*decrypted.read(), plaintext);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn decrypt_nonexistent_returns_not_found() {
|
async fn test_decrypt_nonexistent_returns_not_found() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
|
|
||||||
let err = actor.decrypt(9999, TEST_AAD.to_vec()).await.unwrap_err();
|
let err = actor.decrypt(9999).await.unwrap_err();
|
||||||
assert!(matches!(err, Error::NotFound));
|
assert!(matches!(err, Error::NotFound));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn ciphertext_differs_across_entries() {
|
async fn test_ciphertext_differs_across_entries() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
|
|
||||||
let plaintext = b"same content";
|
let plaintext = b"same content";
|
||||||
let id1 = actor
|
let id1 = actor
|
||||||
.create_new(SafeCell::new(plaintext.to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(plaintext.to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
let id2 = actor
|
let id2 = actor
|
||||||
.create_new(SafeCell::new(plaintext.to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(plaintext.to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
@@ -70,22 +68,22 @@ async fn ciphertext_differs_across_entries() {
|
|||||||
|
|
||||||
assert_ne!(row1.ciphertext, row2.ciphertext);
|
assert_ne!(row1.ciphertext, row2.ciphertext);
|
||||||
|
|
||||||
let mut d1 = actor.decrypt(id1, TEST_AAD.to_vec()).await.unwrap();
|
let mut d1 = actor.decrypt(id1).await.unwrap();
|
||||||
let mut d2 = actor.decrypt(id2, TEST_AAD.to_vec()).await.unwrap();
|
let mut d2 = actor.decrypt(id2).await.unwrap();
|
||||||
assert_eq!(*d1.read(), plaintext);
|
assert_eq!(*d1.read(), plaintext);
|
||||||
assert_eq!(*d2.read(), plaintext);
|
assert_eq!(*d2.read(), plaintext);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
#[test_log::test]
|
#[test_log::test]
|
||||||
async fn nonce_never_reused() {
|
async fn test_nonce_never_reused() {
|
||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
|
|
||||||
let n = 5;
|
let n = 5;
|
||||||
for i in 0..n {
|
for i in 0..n {
|
||||||
actor
|
actor
|
||||||
.create_new(SafeCell::new(format!("secret {i}").into_bytes()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(format!("secret {i}").into_bytes()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
}
|
}
|
||||||
@@ -139,7 +137,7 @@ async fn broken_db_nonce_format_fails_closed() {
|
|||||||
drop(conn);
|
drop(conn);
|
||||||
|
|
||||||
let err = actor
|
let err = actor
|
||||||
.create_new(SafeCell::new(b"must fail".to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(b"must fail".to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap_err();
|
.unwrap_err();
|
||||||
assert!(matches!(err, Error::BrokenDatabase));
|
assert!(matches!(err, Error::BrokenDatabase));
|
||||||
@@ -147,7 +145,7 @@ async fn broken_db_nonce_format_fails_closed() {
|
|||||||
let db = db::create_test_pool().await;
|
let db = db::create_test_pool().await;
|
||||||
let mut actor = common::bootstrapped_vault(&db).await;
|
let mut actor = common::bootstrapped_vault(&db).await;
|
||||||
let id = actor
|
let id = actor
|
||||||
.create_new(SafeCell::new(b"decrypt target".to_vec()), TEST_AAD.to_vec())
|
.create_new(SafeCell::new(b"decrypt target".to_vec()))
|
||||||
.await
|
.await
|
||||||
.unwrap();
|
.unwrap();
|
||||||
let mut conn = db.get().await.unwrap();
|
let mut conn = db.get().await.unwrap();
|
||||||
@@ -158,6 +156,6 @@ async fn broken_db_nonce_format_fails_closed() {
|
|||||||
.unwrap();
|
.unwrap();
|
||||||
drop(conn);
|
drop(conn);
|
||||||
|
|
||||||
let err = actor.decrypt(id, TEST_AAD.to_vec()).await.unwrap_err();
|
let err = actor.decrypt(id).await.unwrap_err();
|
||||||
assert!(matches!(err, Error::BrokenDatabase));
|
assert!(matches!(err, Error::BrokenDatabase));
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user