feat(controller): start, stop, restart, destroy and wipe commands #1
2 Participants
Due Date
Notifications
Total Time Spent: 40 minutes
CleverWild
40 minutes
No due date set.
Dependencies
No dependencies set.
Reference: MarketTakers/pgd#1
Reference in New Issue
Block a user
Delete Branch "impl-commands"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@@ -105,2 +105,4 @@}pub async fn start(&self) -> Result<()> {let instance = self.ctx.require_instance()?;check
Reconciler@@ -107,0 +263,4 @@.await?;if !is_running {println!("{}", "Starting container to wipe data...".cyan());use reconciler
@@ -107,0 +154,4 @@let reconciler = Reconciler { ctx: &self.ctx };println!("{}", "Restarting container...".cyan());reconciler.reconcile(project).await?;Contrary to the intuition, you should stop container here before calling reconciler. Because if container is already running, it wouldn't do anything
Nice job overall. Great orientation with unknown code
LGTM