feat(controller): start, stop, restart, destroy and wipe commands #1

Merged
Skipper merged 3 commits from impl-commands into main 2025-12-12 12:34:30 +00:00
Member
No description provided.
CleverWild added 1 commit 2025-12-10 18:20:57 +00:00
Skipper requested changes 2025-12-10 18:28:22 +00:00
Dismissed
@@ -105,2 +105,4 @@
}
pub async fn start(&self) -> Result<()> {
let instance = self.ctx.require_instance()?;
Owner

check Reconciler

check `Reconciler`
CleverWild marked this conversation as resolved
@@ -107,0 +263,4 @@
.await?;
if !is_running {
println!("{}", "Starting container to wipe data...".cyan());
Owner

use reconciler

use reconciler
CleverWild marked this conversation as resolved
CleverWild added 1 commit 2025-12-10 19:04:54 +00:00
CleverWild requested review from Skipper 2025-12-10 19:05:09 +00:00
CleverWild added spent time 40 minutes 2025-12-10 19:05:28 +00:00
Skipper requested changes 2025-12-10 23:49:48 +00:00
Dismissed
@@ -107,0 +154,4 @@
let reconciler = Reconciler { ctx: &self.ctx };
println!("{}", "Restarting container...".cyan());
reconciler.reconcile(project).await?;
Owner

Contrary to the intuition, you should stop container here before calling reconciler. Because if container is already running, it wouldn't do anything

Contrary to the intuition, you should stop container here before calling reconciler. Because if container is already running, it wouldn't do anything
CleverWild marked this conversation as resolved
Owner

Nice job overall. Great orientation with unknown code

Nice job overall. Great orientation with unknown code
CleverWild added 1 commit 2025-12-11 16:28:35 +00:00
CleverWild requested review from Skipper 2025-12-11 16:30:40 +00:00
Skipper approved these changes 2025-12-12 12:33:21 +00:00
Skipper left a comment
Owner

LGTM

LGTM
Skipper merged commit f89832d736 into main 2025-12-12 12:34:30 +00:00
Skipper deleted branch impl-commands 2025-12-12 12:34:38 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Total Time Spent: 40 minutes
CleverWild
40 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/pgd#1