MarketTakers/arbiter
5
0
Fork 0
Code Issues 27 Pull Requests 4 Packages Projects Releases Wiki Activity

Client key is not integrity-protected #58

New Issue
Closed
opened 2026-04-05 16:15:41 +00:00 by Skipper · 0 comments
Skipper commented 2026-04-05 16:15:41 +00:00
Owner
Copy Link

Info

Severity: CRITICAL
Attack vector: offline

Impact

Allows an attacker with database write access to insert or replace SDK client keys and bypass the intended approval flow.

Description

Unlike user-agent records and grants, program_client rows are created without an integrity envelope and are not verified before challenge issuance. This makes SDK client identities directly tamperable at the database level.

Example flow

  1. Insert a new program_client row or replace an existing public key in the database.
  2. Authenticate using the attacker-controlled key.
  3. Reuse the victim client's grants and wallet access.
  4. Request signatures as that SDK client.

Mitigation

Sign program_client rows on insertion and verify them before authentication, mirroring the user-agent integrity pattern.

# Info **Severity**: **CRITICAL** Attack vector: offline ## Impact Allows an attacker with database write access to insert or replace SDK client keys and bypass the intended approval flow. ## Description Unlike user-agent records and grants, `program_client` rows are created without an integrity envelope and are not verified before challenge issuance. This makes SDK client identities directly tamperable at the database level. ## Example flow 1. Insert a new `program_client` row or replace an existing public key in the database. 2. Authenticate using the attacker-controlled key. 3. Reuse the victim client's grants and wallet access. 4. Request signatures as that SDK client. ## Mitigation Sign `program_client` rows on insertion and verify them before authentication, mirroring the user-agent integrity pattern.
Skipper added the
Difficulty
High
3
Kind
Security
Priority
Critical
1
 labels 2026-04-05 16:15:51 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat
Breaking
Breaking change that won't be backward compatible
Difficulty
High
3
Hard difficulty. Experience needed to fix: A lot.
Difficulty
Low
1
Easy difficulty. Experience needed to fix: Not much. Good first issue.
Difficulty
Medium
2
Medium difficulty. Experience needed to fix: Intermediate.
Kind
Bug
This is a bug.
Kind
Enhancement
Improve existing functionality.
Kind
Feature
New functionality
Kind
RFC
Request for comments
Kind
Security
This is security issue
Kind
Testing
This is testing issue.
Kind
Tracking issue
An issue tracking the progress of sth. like the implementation of an RFC
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Pending
4
Requires review by dev
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Difficulty
High
3
Kind
Security
Priority
Critical
1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CleverWild Skipper goodvin testuser
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#58
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?