refactor(custody): replace the store abstraction with direct database functions #109

Merged
Skipper merged 2 commits from cleverwild/rrvrwqun into feat-shamir-custody 2026-09-13 14:33:33 +00:00
Member
No description provided.
CleverWild added 1 commit 2026-09-12 15:22:14 +00:00
Skipper requested changes 2026-09-13 10:56:23 +00:00
@@ -6,3 +4,1 @@
//! caller's connection instead of taking one from the pool, which lets the
//! vault write custody material inside the same transaction that stores the
//! root key.
//! Every query lives here so that the actors above hold no Diesel code of their
Owner

vibe-slop comment detected. engage racial slurs

vibe-slop comment detected. engage racial slurs
CleverWild marked this conversation as resolved
@@ -162,0 +91,4 @@
}
/// One row of the share query: operator id, ciphertext, nonce, salt.
type ShareRow = (Option<OperatorId>, Vec<u8>, Vec<u8>, Vec<u8>);
Owner

why this is not a model?

why this is not a model?
CleverWild marked this conversation as resolved
CleverWild force-pushed cleverwild/rrvrwqun from 3db7ece6c0 to 8455bac201 2026-09-13 12:50:49 +00:00 Compare
CleverWild requested review from Skipper 2026-09-13 12:51:08 +00:00
Skipper requested changes 2026-09-13 13:14:54 +00:00
@@ -54,3 +54,3 @@
create table if not exists operator (
id integer primary key references operator_identity(id) on delete restrict, -- same id as operator_identity
id integer not null primary key references operator_identity(id) on delete restrict, -- same id as operator_identity
Owner

primary key can't be null by definition

primary key can't be null by definition
Author
Member

it's just a code convention. not a fix.

it's just a code convention. not a fix.
CleverWild marked this conversation as resolved
CleverWild requested review from Skipper 2026-09-13 14:16:48 +00:00
Skipper merged commit 25f5f85537 into feat-shamir-custody 2026-09-13 14:33:33 +00:00
Skipper deleted branch cleverwild/rrvrwqun 2026-09-13 14:33:33 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarketTakers/arbiter#109