clippy: fix

server/crates/arbiter-server/src/actors/client/auth.rs

@@ -17,7 +17,10 @@ use kameo::error::SendError;
 use tracing::error;
 
 use crate::{
-    actors::{client::ClientConnection, router::{self, RequestClientApproval}},
+    actors::{
+        client::ClientConnection,
+        router::{self, RequestClientApproval},
+    },
     db::{self, schema::program_client},
 };
 
@@ -100,7 +103,9 @@ async fn approve_new_client(
 ) -> Result<(), Error> {
     let result = actors
         .router
-        .ask(RequestClientApproval { client_pubkey: pubkey })
+        .ask(RequestClientApproval {
+            client_pubkey: pubkey,
+        })
         .await;
 
     match result {
@@ -166,18 +171,18 @@ async fn challenge_client(
             Error::Transport
         })?;
 
-    let AuthChallengeSolution { signature } = expect_message(
-        &mut *props.transport,
-        |req: ClientRequest| match req.payload? {
-            ClientRequestPayload::AuthChallengeSolution(s) => Some(s),
-            _ => None,
-        },
-    )
-    .await
-    .map_err(|e| {
-        error!(error = ?e, "Failed to receive challenge solution");
-        Error::Transport
-    })?;
+    let AuthChallengeSolution { signature } =
+        expect_message(&mut *props.transport, |req: ClientRequest| {
+            match req.payload? {
+                ClientRequestPayload::AuthChallengeSolution(s) => Some(s),
+                _ => None,
+            }
+        })
+        .await
+        .map_err(|e| {
+            error!(error = ?e, "Failed to receive challenge solution");
+            Error::Transport
+        })?;
 
     let formatted = format_challenge(nonce, &challenge.pubkey);
     let sig = signature.as_slice().try_into().map_err(|_| {
@@ -196,9 +201,9 @@ async fn challenge_client(
 fn connect_error_code(err: &Error) -> ConnectErrorCode {
     match err {
         Error::ApproveError(ApproveError::Denied) => ConnectErrorCode::ApprovalDenied,
-        Error::ApproveError(ApproveError::Upstream(router::ApprovalError::NoUserAgentsConnected)) => {
-            ConnectErrorCode::NoUserAgentsOnline
-        }
+        Error::ApproveError(ApproveError::Upstream(
+            router::ApprovalError::NoUserAgentsConnected,
+        )) => ConnectErrorCode::NoUserAgentsOnline,
         _ => ConnectErrorCode::Unknown,
     }
 }
@@ -234,7 +239,7 @@ async fn authenticate(props: &mut ClientConnection) -> Result<VerifyingKey, Erro
 
 pub async fn authenticate_and_create(mut props: ClientConnection) -> Result<ClientSession, Error> {
     match authenticate(&mut props).await {
-        Ok(pubkey) => Ok(ClientSession::new(props, pubkey)),
+        Ok(_pubkey) => Ok(ClientSession::new(props)),
         Err(err) => {
             let code = connect_error_code(&err);
             let _ = props

server/crates/arbiter-server/src/actors/client/session.rs

@@ -1,5 +1,4 @@
 use arbiter_proto::proto::client::{ClientRequest, ClientResponse};
-use ed25519_dalek::VerifyingKey;
 use kameo::Actor;
 use tokio::select;
 use tracing::{error, info};
@@ -10,12 +9,11 @@ use crate::{actors::{
 
 pub struct ClientSession {
     props: ClientConnection,
-    key: VerifyingKey,
 }
 
 impl ClientSession {
-    pub(crate) fn new(props: ClientConnection, key: VerifyingKey) -> Self {
-        Self { props, key }
+    pub(crate) fn new(props: ClientConnection) -> Self {
+        Self { props }
     }
 
     pub async fn process_transport_inbound(&mut self, req: ClientRequest) -> Output {
@@ -24,9 +22,8 @@ impl ClientSession {
             ClientError::MissingRequestPayload
         })?;
 
-        match msg {
-            _ => Err(ClientError::UnexpectedRequestPayload),
-        }
+        let _ = msg;
+        Err(ClientError::UnexpectedRequestPayload)
     }
 }
 
@@ -92,7 +89,6 @@ impl ClientSession {
         use arbiter_proto::transport::DummyTransport;
         let transport: super::Transport = Box::new(DummyTransport::new());
         let props = ClientConnection::new(db, transport, actors);
-        let key = VerifyingKey::from_bytes(&[0u8; 32]).unwrap();
-        Self { props, key }
+        Self { props }
     }
 }

server/crates/arbiter-server/src/actors/evm/mod.rs

@@ -1,4 +1,4 @@
-use alloy::{consensus::TxEip1559, network::TxSigner, primitives::Address, signers::Signature};
+use alloy::{consensus::TxEip1559, primitives::Address, signers::Signature};
 use diesel::{ExpressionMethods, OptionalExtension as _, QueryDsl, SelectableHelper as _, dsl::insert_into};
 use diesel_async::RunQueryDsl;
 use kameo::{Actor, actor::ActorRef, messages};

server/crates/arbiter-server/src/actors/router/mod.rs

@@ -67,7 +67,7 @@ async fn request_client_approval(
     client_pubkey: VerifyingKey,
 ) -> Result<bool, ApprovalError> {
     if user_agents.is_empty() {
-        return Err(ApprovalError::NoUserAgentsConnected).into();
+        return Err(ApprovalError::NoUserAgentsConnected);
     }
 
     let mut pool = JoinSet::new();
@@ -76,7 +76,6 @@ async fn request_client_approval(
     for weak_ref in user_agents {
         match weak_ref.upgrade() {
             Some(agent) => {
-                let client_pubkey = client_pubkey.clone();
                 let cancel_rx = cancel_rx.clone();
                 pool.spawn(async move {
                     agent
@@ -167,7 +166,7 @@ impl MessageRouter {
         // handle in subtask to not to lock the actor
         tokio::task::spawn(async move {
             let result = request_client_approval(&weak_refs, client_pubkey).await;
-            let _ = reply_sender.send(result);
+            reply_sender.send(result);
         });
 
         reply